[PATCH v2 03/10] xfree86: duplicate xorg.conf device information before xf86NewInputDevice

2011-07-08 Thread Peter Hutterer
xf86ConfigLayout.inputs contains the information from the xorg.conf file. Passing this into xf86NewInputDevice means the device will get cleaned up on exit and the pointers in xf86ConfigLayout.inputs are left dangling. In the second server generation, this results in a server crash. Also, rename

[PATCH:x11perf 2/2] Add MKTEMP to DIR_SUBSTS in Makefile

2011-07-08 Thread Alan Coopersmith
Needed for commit 1188465112a1 to work after revert of 4af24b2f5b3f8f Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5cfedb4..30c9ec7 100644 --- a/Makefile.am +++

Re: [PATCH:x11perf 1/2] Revert Let autoconf generate x11perfcomp directly instead of doing it via sed

2011-07-08 Thread Jeremy Huddleston
Yeah ... autoconf has some ugly limitations, but then so does every build system... Reviewed-by: Jeremy Huddleston jerem...@apple.com On Jul 7, 2011, at 22:41, Alan Coopersmith wrote: This reverts commit 4af24b2f5b3f8f2c20271ae323b6fa528b9b2127. Letting autoconf do it failed to handle the

Re: Cross Compilation problem in libdmx package.

2011-07-08 Thread Mikhail Gusarov
Twas brillig at 12:14:53 08.07.2011 UTC+05 when ankitgarg...@gmail.com did gyre and gimble: Ag [root@localhost libdmx-1.1.1]# make Building from root? Really? Ag make all-recursive Ag make[1]: Entering directory `/home/ankit/Downloads/X_code/libdmx-1.1.1' Ag Making all in src Ag

Re: X server not responding when querying X pointer position

2011-07-08 Thread Thierry Reding
* Thierry Reding wrote: * Daniel Stone wrote: On Thu, Jul 07, 2011 at 11:46:43AM +0200, Thierry Reding wrote: * Daniel Stone wrote: The two most pertinent questions I can think of are: * are you using threads at all? I try to keep the number of threads used to a minimum,

Re: X server not responding when querying X pointer position

2011-07-08 Thread Daniel Stone
Hi, On Fri, Jul 08, 2011 at 12:51:19PM +0200, Thierry Reding wrote: * Thierry Reding wrote: * Daniel Stone wrote: Heh, threads are always problematic. Are you calling XInitThreads() before your first call to XOpenDisplay()? Actually I was just using Gtk+, without any explicit calls

Re: X server not responding when querying X pointer position

2011-07-08 Thread Thierry Reding
* Daniel Stone wrote: Hi, On Fri, Jul 08, 2011 at 12:51:19PM +0200, Thierry Reding wrote: * Thierry Reding wrote: * Daniel Stone wrote: Heh, threads are always problematic. Are you calling XInitThreads() before your first call to XOpenDisplay()? Actually I was just using

[PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Kees Cook
This replaces sprintf with snprintf to avoid crashing when creating various labels. https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 Signed-off-by: Kees Cook kees.c...@canonical.com --- xclipboard.c |3 ++- xcutsel.c|4 ++-- 2 files changed, 4 insertions(+), 3

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Alan Coopersmith
On 07/ 8/11 11:01 AM, Kees Cook wrote: This replaces sprintf with snprintf to avoid crashing when creating various labels. https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 Signed-off-by: Kees Cook kees.c...@canonical.com --- xclipboard.c |3 ++- xcutsel.c|4

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Julien Cristau
On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: This replaces sprintf with snprintf to avoid crashing when creating various labels. https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 Signed-off-by: Kees Cook kees.c...@canonical.com --- xclipboard.c |3 ++-

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Kees Cook
Hi, On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote: On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: This replaces sprintf with snprintf to avoid crashing when creating various labels. https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Julien Cristau
On Fri, Jul 8, 2011 at 12:10:31 -0700, Kees Cook wrote: I've been told in the past not use asprintf because it isn't portable, Right. and I do not find XtAsprintf in the include files: ../xclipboard/xclipboard.c:337:2: warning: implicit declaration of function ‘XtAsprintf’ ...

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread walter harms
Am 08.07.2011 21:10, schrieb Kees Cook: Hi, On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote: On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: This replaces sprintf with snprintf to avoid crashing when creating various labels.