[PATCH] Bug 38420: Xvfb crashes in miInitVisuals() when started with depth=2

2011-09-23 Thread Alan Coopersmith
From: Christopher Yeleighton https://bugs.freedesktop.org/show_bug.cgi?id=38420 Exit with fatal error message, not segfault. Signed-off-by: Alan Coopersmith --- hw/vfb/InitOutput.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/vfb/InitOutput.c b/hw/vfb/InitOutpu

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: > Hi Keith, > > I believe this failure is coming from > b61950dc616402bbf3fb0774e9289d32c0f42c83 which removed these from > xfree86/common/xf86str.h > > #include "xf86Pci.h" > #include > > I squashed your change below into b61950dc616402bb

Re: [PATCH xserver 1/2] scaled: use appropriate docbook copyright markup

2011-09-23 Thread Alan Coopersmith
For both patches against this doc: Reviewed-by: Alan Coopersmith -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System ___ xorg-devel@lists.x.org: X.Org development Archives: htt

Re: X.Org Foundation & copyright ownership (was: [PATCH xserver 3/3] Xserver-spec: use appropriate copyright markup)

2011-09-23 Thread Alan Coopersmith
On 09/23/11 09:47 AM, Gaetan Nadon wrote: *** Questions *** Does the X.Org Foundation want to be the owner of the rights for some material? I was under the impression it did not want to hold such rights for any material, contrary to the what X Consortium Inc. did. I don't think

Re: [PATCH xserver 3/3] dmx: add X11 version and release information

2011-09-23 Thread Alan Coopersmith
On 09/23/11 11:11 AM, Gaetan Nadon wrote: Signed-off-by: Gaetan Nadon --- hw/dmx/doc/dmx.xml |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/dmx/doc/dmx.xml b/hw/dmx/doc/dmx.xml index 5d51417..1bf3313 100644 --- a/hw/dmx/doc/dmx.xml +++ b/hw/dmx/doc/dmx.xml @@ -1,6

Re: [PATCH xserver 2/3] dmx: fix type in the title

2011-09-23 Thread Alan Coopersmith
On 09/23/11 11:11 AM, Gaetan Nadon wrote: Signed-off-by: Gaetan Nadon --- hw/dmx/doc/dmx.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx/doc/dmx.xml b/hw/dmx/doc/dmx.xml index 7c542ab..5d51417 100644 --- a/hw/dmx/doc/dmx.xml +++ b/hw/dmx/doc/dmx.xml @@ -7,7

Re: [PATCH xserver 1/3] dmx: use appropriate docboook copyright markup

2011-09-23 Thread Alan Coopersmith
On 09/23/11 11:11 AM, Gaetan Nadon wrote: The copyright legal text is missing Signed-off-by: Gaetan Nadon --- hw/dmx/doc/dmx.xml | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/dmx/doc/dmx.xml b/hw/dmx/doc/dmx.xml index ce472c2..7c542ab 100644 --- a/hw/dmx

Re: [PATCH xserver 3/3] ddxDesign: drop the url in the coporate authors list

2011-09-23 Thread Alan Coopersmith
On 09/23/11 11:10 AM, Gaetan Nadon wrote: It was such an eyesore once rendered in html. Now it looks like other authors. Signed-off-by: Gaetan Nadon --- hw/xfree86/doc/ddxDesign.xml |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw

Re: [PATCH xserver 2/3] Xserver-spec: re-order markup to follow outpout order

2011-09-23 Thread Alan Coopersmith
On 09/23/11 09:47 AM, Gaetan Nadon wrote: No content change, no layout/ordering change. It is easier to find at the top. Signed-off-by: Gaetan Nadon --- doc/Xserver-spec.xml | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Alan Coopersmith --

Re: [PATCH xserver 1/3] Xserver-spec: add release information

2011-09-23 Thread Alan Coopersmith
On 09/23/11 09:47 AM, Gaetan Nadon wrote: +X Version 11, Release&fullrelvers; X server version&xserver.version; Does it print both release info lines when there are two? -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Windo

Re: [PATCH xserver] doc: Xinput: review title page

2011-09-23 Thread Alan Coopersmith
On 09/23/11 09:44 AM, Gaetan Nadon wrote: +X Version 11, Release&fullrelvers; Since this covers the Input API in the X server, which changes per X server release, often multiple times between katamari releases, I think it would be more useful to instead have: X server version &xserver.vers

[PULL: xserver master] cleanups from Alan & Gaetan

2011-09-23 Thread Alan Coopersmith
The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700) are available in the git repository at: git://people.freedesktop.org/~alanc/xserver.git master Alan Coopersmith (2): Assign ids t

[PATCH xserver] dix and os: gitignore dix.O and os.O

2011-09-23 Thread Gaetan Nadon
Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon --- dix/.gitignore |1 + os/.gitignore |1 + 2 files changed, 2 insertions(+), 0 deletions(-) create mode 100644 os/.gitignore diff --git a/dix/.gitignore b/dix/.gitignore index c1b4f20..65f2f8c 100644 --- a/dix/.gitignore +++

Re: [PATCH xserver 1/2] dtrace: use docbook copyright markup for copyright holder

2011-09-23 Thread Alan Coopersmith
On 09/23/11 06:38 AM, Gaetan Nadon wrote: No content change to copyright text. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon --- Requires patch "Assign ids to more tags in Xserver-Dtrace.xml" 99e7e4d916b724bea212c5ce0df36ccd9705d5c8 Since these depend on my patch, I

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
Hi Keith, I believe this failure is coming from b61950dc616402bbf3fb0774e9289d32c0f42c83 which removed these from xfree86/common/xf86str.h #include "xf86Pci.h" #include I squashed your change below into b61950dc616402bbf3fb0774e9289d32c0f42c83 and pushed the new branch. I'm also testing it o

Re: [PATCH xserver] dix and os: gitignore dix.O and os.O

2011-09-23 Thread Alan Coopersmith
On 09/23/11 12:16 PM, Gaetan Nadon wrote: Signed-off-by: Gaetan Nadon --- dix/.gitignore |1 + os/.gitignore |1 + 2 files changed, 2 insertions(+), 0 deletions(-) create mode 100644 os/.gitignore diff --git a/dix/.gitignore b/dix/.gitignore index c1b4f20..65f2f8c 100644 --- a/dix

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
On 09/23/2011 07:10 AM, Mark Kettenis wrote: From: Jeremy Huddleston Date: Thu, 22 Sep 2011 19:52:05 -0700 The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700) are available in the git repo

[PATCH xserver] dix and os: gitignore dix.O and os.O

2011-09-23 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon --- dix/.gitignore |1 + os/.gitignore |1 + 2 files changed, 2 insertions(+), 0 deletions(-) create mode 100644 os/.gitignore diff --git a/dix/.gitignore b/dix/.gitignore index c1b4f20..65f2f8c 100644 --- a/dix/.gitignore +++ b/dix/.gitignore @@ -1,2 +1,3 @

Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection

2011-09-23 Thread James Cloos
> "DS" == Daniel Stone writes: DS> (Real summary: That's your opinion. The development team have ours. Well, *some* of the development texm. Some of us agree that forcing the dpi to 96 is a b0rked regression. It is just that those with the contrary opinion are more vocal and have more tra

[PATCH xserver 2/2] scaled: add X version and release information

2011-09-23 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon --- hw/dmx/doc/scaled.xml |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/dmx/doc/scaled.xml b/hw/dmx/doc/scaled.xml index 0bf942c..db653c4 100644 --- a/hw/dmx/doc/scaled.xml +++ b/hw/dmx/doc/scaled.xml @@ -1,6 +1,7 @@ http://www.oasis-o

[PATCH xserver 1/2] scaled: use appropriate docbook copyright markup

2011-09-23 Thread Gaetan Nadon
The legal text is missing. Signed-off-by: Gaetan Nadon --- hw/dmx/doc/scaled.xml |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/dmx/doc/scaled.xml b/hw/dmx/doc/scaled.xml index 48c83e0..0bf942c 100644 --- a/hw/dmx/doc/scaled.xml +++ b/hw/dmx/doc/scaled.xml @@ -1

[PATCH xserver 3/3] dmx: add X11 version and release information

2011-09-23 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon --- hw/dmx/doc/dmx.xml |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/dmx/doc/dmx.xml b/hw/dmx/doc/dmx.xml index 5d51417..1bf3313 100644 --- a/hw/dmx/doc/dmx.xml +++ b/hw/dmx/doc/dmx.xml @@ -1,6 +1,7 @@ http://www.oasis-open.org/docbook

[PATCH xserver 2/3] dmx: fix type in the title

2011-09-23 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon --- hw/dmx/doc/dmx.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx/doc/dmx.xml b/hw/dmx/doc/dmx.xml index 7c542ab..5d51417 100644 --- a/hw/dmx/doc/dmx.xml +++ b/hw/dmx/doc/dmx.xml @@ -7,7 +7,7 @@ -Distributed Multihe

[PATCH xserver 1/3] dmx: use appropriate docboook copyright markup

2011-09-23 Thread Gaetan Nadon
The copyright legal text is missing Signed-off-by: Gaetan Nadon --- hw/dmx/doc/dmx.xml | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/dmx/doc/dmx.xml b/hw/dmx/doc/dmx.xml index ce472c2..7c542ab 100644 --- a/hw/dmx/doc/dmx.xml +++ b/hw/dmx/doc/dmx.xml @@ -13,

[PATCH xserver 3/3] ddxDesign: drop the url in the coporate authors list

2011-09-23 Thread Gaetan Nadon
It was such an eyesore once rendered in html. Now it looks like other authors. Signed-off-by: Gaetan Nadon --- hw/xfree86/doc/ddxDesign.xml |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw/xfree86/doc/ddxDesign.xml index db4e840..435

[PATCH xserver 2/3] ddxDesign: remove server version from the document title

2011-09-23 Thread Gaetan Nadon
Such version information is already written in the appropriate location Signed-off-by: Gaetan Nadon --- hw/xfree86/doc/ddxDesign.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw/xfree86/doc/ddxDesign.xml index 98c5d0e..db4e840 100644

[PATCH xserver 1/3] ddx-Design: add X Version and Release information

2011-09-23 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon --- hw/xfree86/doc/ddxDesign.xml |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw/xfree86/doc/ddxDesign.xml index 0290960..98c5d0e 100644 --- a/hw/xfree86/doc/ddxDesign.xml +++ b/hw/xfree86/doc/ddxDesign.xml @@

Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection

2011-09-23 Thread Michal Suchanek
On 23 September 2011 18:37, Alex Deucher wrote: > On Fri, Sep 23, 2011 at 10:58 AM, Michal Suchanek wrote: >> On 22 September 2011 19:34, Alan Coopersmith >> wrote: >>> On 09/22/11 08:32, Michal Suchanek wrote: Hello, Can anybody, please, explain how this bug[1] could have re

[PATCH xserver 3/3] Xserver-spec: use appropriate copyright markup

2011-09-23 Thread Gaetan Nadon
Use docbook copyright markup for year and holder. Signed-off-by: Gaetan Nadon --- *** Questions *** Does the X.Org Foundation want to be the owner of the rights for some material? I was under the impression it did not want to hold such rights for any material, contrary to the wha

[PATCH xserver 2/3] Xserver-spec: re-order markup to follow outpout order

2011-09-23 Thread Gaetan Nadon
No content change, no layout/ordering change. It is easier to find at the top. Signed-off-by: Gaetan Nadon --- doc/Xserver-spec.xml | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/Xserver-spec.xml b/doc/Xserver-spec.xml index 30c6127..aabd262 10

[PATCH xserver 1/3] Xserver-spec: add release information

2011-09-23 Thread Gaetan Nadon
It has been added in all docs (X Version 11, Release 7.6) Signed-off-by: Gaetan Nadon --- doc/Xserver-spec.xml |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/Xserver-spec.xml b/doc/Xserver-spec.xml index b14e489..30c6127 100644 --- a/doc/Xserver-spec.xml +++ b/doc/

[PATCH xserver] doc: Xinput: review title page

2011-09-23 Thread Gaetan Nadon
Add release number Refactor legal text for multi license copyright Remove duplicate paragraph Signed-off-by: Gaetan Nadon --- doc/Xinput.xml | 27 +++ 1 files changed, 11 insertions(+), 16 deletions(-) diff --git a/doc/Xinput.xml b/doc/Xinput.xml index 1ae7afe..dd63e74

Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection

2011-09-23 Thread Alex Deucher
On Fri, Sep 23, 2011 at 10:58 AM, Michal Suchanek wrote: > On 22 September 2011 19:34, Alan Coopersmith > wrote: >> On 09/22/11 08:32, Michal Suchanek wrote: >>> >>> Hello, >>> >>> Can anybody, please, explain how this bug[1] could have remained in >>> Xorg for two years assuming any sanity is re

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Keith Packard
On Fri, 23 Sep 2011 16:10:44 +0200 (CEST), Mark Kettenis wrote: > Unlike Tiago's origional changes this looks like it is actually going > somewhere, and generally this looks like a good idea, even if it > breaks some stuff temporarily. But I'd like to check that not too > many Linux-isms and x8

Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection

2011-09-23 Thread Michal Suchanek
On 23 September 2011 17:05, Daniel Stone wrote: > Hi, > > On 23 September 2011 15:58, Michal Suchanek wrote: >> There are obviously people sabotaging X already since the change went >> in more than two years ago and stayed in spite of being pointed out as >> bogus. > > I think that your emails ar

Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection

2011-09-23 Thread Daniel Stone
Hi, On 23 September 2011 15:58, Michal Suchanek wrote: > There are obviously people sabotaging X already since the change went > in more than two years ago and stayed in spite of being pointed out as > bogus. I think that your emails are bogus, and if you keep on sending them then you are clearl

Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection

2011-09-23 Thread Michal Suchanek
On 22 September 2011 19:34, Alan Coopersmith wrote: > On 09/22/11 08:32, Michal Suchanek wrote: >> >> Hello, >> >> Can anybody, please, explain how this bug[1] could have remained in >> Xorg for two years assuming any sanity is remaining among Xorg >> developers? > > If we were sane, we wouldn't s

Re: [PATCH v2 xserver] dix: Prevent access to freed memory if a client kills itself.

2011-09-23 Thread Jamey Sharp
Looks good to me! Reviewed-by: Jamey Sharp On 9/23/11, Rami Ylimäki wrote: > The 'Dispatch' function accesses freed client structure if a client > happens to kill itself in a request. For example, I have a test client > that is used to check that it handles the XIO error correctly. The XIO > er

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Matt Turner
On Fri, Sep 23, 2011 at 10:10 AM, Mark Kettenis wrote: >> From: Jeremy Huddleston >> Date: Thu, 22 Sep 2011 19:52:05 -0700 >> >> The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: >> >>   Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 >> -0700) >

Re: [PATCH-V2] xserver: Optional backtrace handler

2011-09-23 Thread Alan Coopersmith
On 09/23/11 05:23 AM, Barry Scott wrote: On Friday 23 September 2011 10:40:35 Simon Farnsworth wrote: > > diff --git a/include/os.h b/include/os.h > > index a553f57..48debe9 100644 > > --- a/include/os.h > > +++ b/include/os.h > > @@ -542,5 +542,8 @@ extern _X_EXPORT void Error(const char *str)

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Daniel Stone
Hi, On 23 September 2011 15:10, Mark Kettenis wrote: > Unlike Tiago's origional changes this looks like it is actually going > somewhere, and generally this looks like a good idea, even if it > breaks some stuff temporarily.  But I'd like to check that not too > many Linux-isms and x86-isms creep

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Mark Kettenis
> From: Jeremy Huddleston > Date: Thu, 22 Sep 2011 19:52:05 -0700 > > The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: > > Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 > -0700) > > are available in the git repository at: > > git://peop

[PATCH xserver 2/2] dtrace: fix typo in title

2011-09-23 Thread Gaetan Nadon
The word provider should be capitalized. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon --- doc/dtrace/Xserver-DTrace.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/dtrace/Xserver-DTrace.xml b/doc/dtrace/Xserver-DTrace.xml index bcba17d..c858bfe 100

[PATCH xserver 1/2] dtrace: use docbook copyright markup for copyright holder

2011-09-23 Thread Gaetan Nadon
No content change to copyright text. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon --- Requires patch "Assign ids to more tags in Xserver-Dtrace.xml" 99e7e4d916b724bea212c5ce0df36ccd9705d5c8 doc/dtrace/Xserver-DTrace.xml |6 +++--- 1 files changed, 3 insertions

Re: [libXext: PATCH] Fix id attributes, linkend and olinks

2011-09-23 Thread Gaetan Nadon
On Fri, 2011-09-23 at 09:02 -0400, Gaetan Nadon wrote: > On Thu, 2011-09-22 at 20:19 -0600, Matt Dew wrote: > > > On 09/22/2011 03:13 PM, Alan Coopersmith wrote: > > > On 09/21/11 16:53, Gaetan Nadon wrote: > > >> On Wed, 2011-09-21 at 14:05 -0600, Matt Dew wrote: > > >>> --- > > >>> specs/dbeli

Re: [libXext: PATCH] Fix id attributes, linkend and olinks

2011-09-23 Thread Gaetan Nadon
On Thu, 2011-09-22 at 20:19 -0600, Matt Dew wrote: > On 09/22/2011 03:13 PM, Alan Coopersmith wrote: > > On 09/21/11 16:53, Gaetan Nadon wrote: > >> On Wed, 2011-09-21 at 14:05 -0600, Matt Dew wrote: > >>> --- > >>> specs/dbelib.xml | 68 > >>> +++---

Re: [PATCH:libXi] Make shadow man pages generated by asciidoc work with Solaris man

2011-09-23 Thread Gaetan Nadon
On Thu, 2011-09-22 at 16:22 -0700, Alan Coopersmith wrote: > On 09/22/11 15:16, Peter Hutterer wrote: > > On Thu, Sep 22, 2011 at 08:51:01AM -0400, Gaetan Nadon wrote: > >> On Thu, 2011-09-22 at 09:21 +1000, Peter Hutterer wrote: > >> > >>> I've gone ahead and merged this patch for now. It has the

Re: [PATCH-V2] xserver: Optional backtrace handler

2011-09-23 Thread Barry Scott
On Friday 23 September 2011 10:40:35 Simon Farnsworth wrote: > > diff --git a/include/os.h b/include/os.h > > index a553f57..48debe9 100644 > > --- a/include/os.h > > +++ b/include/os.h > > @@ -542,5 +542,8 @@ extern _X_EXPORT void Error(const char *str); > > extern _X_EXPORT void LogPrintMarke

Re: [PATCH-V2] xserver: Optional backtrace handler

2011-09-23 Thread Simon Farnsworth
Review inline. Commit message is fine this time, so snipped. On Thursday 22 September 2011, Barry Scott wrote: > diff --git a/dix/main.c b/dix/main.c > index 16575ce..96b3f37 100644 > --- a/dix/main.c > +++ b/dix/main.c > @@ -147,6 +147,8 @@ int main(int argc, char *argv[], char *envp[]) > >

[PATCH v2 xserver] dix: Prevent access to freed memory if a client kills itself.

2011-09-23 Thread Rami Ylimäki
The 'Dispatch' function accesses freed client structure if a client happens to kill itself in a request. For example, I have a test client that is used to check that it handles the XIO error correctly. The XIO error is generated by requesting the client to kill itself with XKillClient. We don't ha

Re: [PATCH] dix: Prevent access to freed memory if a client kills itself.

2011-09-23 Thread Rami Ylimäki
On 09/22/2011 07:34 PM, Jamey Sharp wrote: This patch makes sense to me, but I have a couple of requests: I'm not sure why you extracted out a separate function; I'm not convinced that makes the code more clear, in this case. Originally, there was no good reason for extracting the code to a s