Re: [PATCH] pci: Restore pciTag as a deprecated function

2011-10-20 Thread Jeremy Huddleston
On Oct 19, 2011, at 23:45, Jamey Sharp wrote: >> I think we coddled the drivers enough with the current set of >> just-deprecations. This is too trivial. I'll just go through and >> make sure nobody is actually using it because drivers still build >> "successfully" due to us not using >> -Werro

Re: [PATCH] x11proto: add permille, ezh, and EZH to keysymdef.h

2011-10-20 Thread Marko Myllynen
Hi, On 2011-10-18 20:15, Matt Dew wrote: > On 10/17/2011 03:07 AM, Marko Myllynen wrote: >> >>> There's a comment in the keysymdef.h file: >> >> ezh/EZH happened to be in ranges covered by IPAExt_upper_mapping and >> LatinExtB_{upper,lower}_mapping mappings in KeyBind.c already but indeed >> permi

Re: [Pull v2] Glamor - fixed build failure, fixed coding style problem.

2011-10-20 Thread Jamey Sharp
On Wed, Oct 19, 2011 at 11:20:54AM -0700, Jeremy Huddleston wrote: > On Oct 19, 2011, at 1:02 AM, Zhigang Gong wrote: > > Just as I said above. Your thought do make sense. Currently glamor > > implements some GL based rendering functions. And in the long term, > > we may merge those functions into

[git pull] rhel fixes branch

2011-10-20 Thread Dave Airlie
Fixes from RHEL coverity scan + fbdev work. The following changes since commit c8413362049cee8c30e0a9d67f78f9ebefe8e71f: Merge remote-tracking branch 'herrb/master' (2011-10-18 07:45:24 -0700) are available in the git repository at: ssh://people.freedesktop.org/~airlied/xserver rhel-fixes

Re: [Pull v2] Glamor - fixed build failure, fixed coding style problem.

2011-10-20 Thread Michel Dänzer
On Mit, 2011-10-19 at 11:20 -0700, Jeremy Huddleston wrote: > > As I understand it, you want to allow accelerated 2D rendering at the > *DIX* level (whereas EXA and XAA are for Xorg DDX drivers). Actually, EXA is at the DIX level as well, and used by Xephyr. > That is a great goal, but another

Re: [Bug 42035] no way to turn off vsync

2011-10-20 Thread Michal Suchanek
Hello, On 20 October 2011 11:38, wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=42035 > > --- Comment #1 from Michel Dänzer 2011-10-20 02:38:29 > PDT --- >> According to comments in bug 28771 a the xorg ddx is hardcoded to wait for >> vsync > > That's not true anymore, the vline waits (

coverity fixes

2011-10-20 Thread Dave Airlie
This is a bunch of low hanging coverity fixes, there are a lot more, but some of them are a bit more intricate, and also there seems to be a fair few false positives (or me deluding myself). Dave. ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH 01/12] dix: fix double free around allocargbcursor.

2011-10-20 Thread Dave Airlie
From: Dave Airlie coverity scan pointed this out. In some of its error cases AllocARGBCursor freed the bits passed in, because it assigned them to the cursor and called FreeCursorBits, in one case it didn't, if it hadn't done the assignment. This standardises the interface so it always frees in

[PATCH 02/12] xfree86: drop unused pointer setup

2011-10-20 Thread Dave Airlie
From: Dave Airlie Coverity scan pointed this out. Drop unused randrp setup. Signed-off-by: Dave Airlie --- hw/xfree86/modes/xf86RandR12.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c index cb20d1c..d4

[PATCH 03/12] xf86: don't assign unused pointer.

2011-10-20 Thread Dave Airlie
From: Dave Airlie Pointed out by coverity scan. Signed-off-by: Dave Airlie --- hw/xfree86/common/xf86pciBus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/common/xf86pciBus.c b/hw/xfree86/common/xf86pciBus.c index eb5323c..21423ae 100644 --- a/hw/xfree86

[PATCH 04/12] xf86: don't call getscreenpixmap in enabledisablefbaccess

2011-10-20 Thread Dave Airlie
From: Dave Airlie This isn't used anywhere in here. Pointed out by coverity scan. Signed-off-by: Dave Airlie --- hw/xfree86/common/xf86Helper.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c index cf577

[PATCH 05/12] xnest/keyboard: fix dereference before null check

2011-10-20 Thread Dave Airlie
From: Dave Airlie pointed out by coverity. Signed-off-by: Dave Airlie --- hw/xnest/Keyboard.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/xnest/Keyboard.c b/hw/xnest/Keyboard.c index ec629dc..c138438 100644 --- a/hw/xnest/Keyboard.c +++ b/hw/xnest/Keyboard.c @

[PATCH 06/12] kdrive: fix dereference before null check.

2011-10-20 Thread Dave Airlie
From: Dave Airlie pointed out by coverity scan. Signed-off-by: Dave Airlie --- hw/kdrive/linux/evdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/kdrive/linux/evdev.c b/hw/kdrive/linux/evdev.c index 3797f09..c8fc5bc 100644 --- a/hw/kdrive/linux/evdev.c +++ b

[PATCH 07/12] ephyr: fix dereference before null check.

2011-10-20 Thread Dave Airlie
From: Dave Airlie same as the xnest case. Signed-off-by: Dave Airlie --- hw/kdrive/ephyr/ephyr.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c index 7ebf1c2..67376cc 100644 --- a/hw/kdrive/ephyr/ephyr.c +++ b/hw/kd

[PATCH 08/12] hal: free tmp_val in one missing case

2011-10-20 Thread Dave Airlie
From: Dave Airlie Pointed out by coverity scan. Signed-off-by: Dave Airlie Reviewed-by: Daniel Stone --- config/hal.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/config/hal.c b/config/hal.c index aa234eb..088c993 100644 --- a/config/hal.c +++ b/config/hal.c @@ -34

[PATCH 09/12] xv: test correct number of requests.

2011-10-20 Thread Dave Airlie
From: Dave Airlie Pointed out by coverity. Signed-off-by: Dave Airlie --- Xext/xvdisp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xext/xvdisp.c b/Xext/xvdisp.c index 364a90c..71bf722 100644 --- a/Xext/xvdisp.c +++ b/Xext/xvdisp.c @@ -1238,7 +1238,7 @@ ProcXvDisp

[PATCH 10/12] composite/xinerama: free newPix on error path.

2011-10-20 Thread Dave Airlie
From: Dave Airlie newPix could be leaked if AddResource failed. pointed out by coverity scan. Signed-off-by: Dave Airlie --- composite/compext.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/composite/compext.c b/composite/compext.c index 722587a..01bd578 100644

[PATCH 11/12] composite/xinerama: free overlayWin on error paths.

2011-10-20 Thread Dave Airlie
From: Dave Airlie pointed out by coverity scan. Signed-off-by: Dave Airlie --- composite/compext.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/composite/compext.c b/composite/compext.c index 01bd578..16daf23 100644 --- a/composite/compext.c +++ b/composite/co

[PATCH 12/12] exa: initialise mask_off_x and mask_off_y

2011-10-20 Thread Dave Airlie
From: Dave Airlie These get used at the end of the function in a calculation, even the result isn't used its not pretty. pointed out by coverity. Signed-off-by: Dave Airlie --- exa/exa_render.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exa/exa_render.c b/exa/ex

Re: [PATCH xserver] composite: Update borderClip in compAllocPixmap()

2011-10-20 Thread Ville Syrjälä
On Wed, Oct 19, 2011 at 05:26:09PM -0700, Keith Packard wrote: > On Sun, 9 Oct 2011 01:11:04 +0300, Ville Syrjala wrote: > > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=22566 > > Merged. >e4787ec..a5266dc master -> master Cheers. Jeremy, I assume you want to cherry-pick this fo

Re: [PATCH 1/6] dix: add ScrollInfo to DeviceChangedEvents

2011-10-20 Thread Daniel Stone
Hi, On Thu, Oct 20, 2011 at 04:25:41PM +1000, Peter Hutterer wrote: > @@ -482,6 +483,41 @@ appendValuatorInfo(DeviceChangedEvent *dce, > xXIValuatorInfo *info, int axisnumbe > } > > static int > +appendScrollInfo(DeviceChangedEvent *dce, xXIScrollInfo *info, int > axisnumber) > +{ > +if

Re: [PATCH 2/6] dix: drop unused argument from XISendDeviceChangedEvent

2011-10-20 Thread Daniel Stone
On Thu, Oct 20, 2011 at 04:25:42PM +1000, Peter Hutterer wrote: > Instead of device and master (and just using master), drop the master > argument and let the callers pass in the device the event is to be sent for. > > No effective functional changes. > > Signed-off-by: Peter Hutterer Reviewed-

Re: [PATCH 5/6] dix: accept a NULL master for CreateClassesChangedEvent

2011-10-20 Thread Daniel Stone
On Thu, Oct 20, 2011 at 04:25:45PM +1000, Peter Hutterer wrote: > If a floating device changes, the master is NULL but we must still create a > DCE for it. > > Signed-off-by: Peter Hutterer Reviewed-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org d

Re: [PATCH 6/6] Xi: send DeviceChangedEvents when the scroll valuators change value

2011-10-20 Thread Daniel Stone
Hi, On Thu, Oct 20, 2011 at 04:25:46PM +1000, Peter Hutterer wrote: > @@ -1139,7 +1141,16 @@ SetScrollValuator(DeviceIntPtr dev, int axnum, enum > ScrollType type, double incr > ax->scroll.type = type; > ax->scroll.increment = increment; > ax->scroll.flags = flags; > -/* FIXME:

Re: [PATCH 3/6] dix: pass the flags into the CreateClassesChangedEvent

2011-10-20 Thread Daniel Stone
On Thu, Oct 20, 2011 at 04:25:43PM +1000, Peter Hutterer wrote: > No effective functional changes, prep work for future patches. > > Signed-off-by: Peter Hutterer Reviewed-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org development Archives: http:/

Re: [PATCH RESEND 1/5] input: switch InputOption to use XF86OptionRec storage.

2011-10-20 Thread Daniel Stone
Hi, On Thu, Oct 20, 2011 at 01:05:28PM +1000, Peter Hutterer wrote: > Use the same struct for both InputOption and XF86OptionRec so we don't need > to convert to and fro the two in the config backends. > > Signed-off-by: Peter Hutterer > Reviewed-by: Dan Nicholson > @@ -670,8 +671,8 @@ point

Re: [PATCH RESEND 2/5] xfree86: use xf86AddNewOption instead of xf86addNewOption

2011-10-20 Thread Daniel Stone
On Thu, Oct 20, 2011 at 01:05:29PM +1000, Peter Hutterer wrote: > The former strdups for us. If the strdup fails we miss out on the > CorePointer option (default on anyway) and we're likely to fall over soon > anyway, so let's pretend this is the same behaviour. > > Signed-off-by: Peter Hutterer

Re: [PATCH RESEND 5/5] xfree86: use NewInputDeviceRequest for xorg.conf devices too

2011-10-20 Thread Daniel Stone
Hi, On Thu, Oct 20, 2011 at 01:05:32PM +1000, Peter Hutterer wrote: > diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c > index 96e98c1..cb4be42 100644 > --- a/hw/xfree86/common/xf86Config.c > +++ b/hw/xfree86/common/xf86Config.c > @@ -1196,6 +1196,10 @@ checkCoreInputDe

Re: [PATCH RESEND 3/5] xfree86: Fix a comment, the old function doesn't exist anymore

2011-10-20 Thread Daniel Stone
On 20 October 2011 04:05, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-dev

Re: [PATCH RESEND 4/5] dix: move #if statement to stop compiler warning

2011-10-20 Thread Daniel Stone
On 20 October 2011 04:05, Peter Hutterer wrote: > ptrveloc.c: In function 'QueryTrackers': > ptrveloc.c:598:34: warning: variable 'used_offset' set but not used > [-Wunused-but-set-variable] > > used_offset is used, but only in the debugging code. Move the #if statement > to ignore that warning. >

Re: [PATCH 4/6] Xi: ensure the deviceid for DeviceChangedEvents is always the right one

2011-10-20 Thread Daniel Stone
On 20 October 2011 07:25, Peter Hutterer wrote: > If we're sending the event for a given device, make sure the deviceid is > that of the device. > This allows callers to use the same DCE for slave and master without having > to fiddle the DCE's internal fields. > > Signed-off-by: Peter Hutterer

[PATCH] xf86Crtc: handle no outputs with no modes harder.

2011-10-20 Thread Dave Airlie
From: Dave Airlie If you started an X server with no connected outputs, we pick a default 1024x768 mode, however if you then ran an xvidmode using app against that server it would segfault the server due to not finding any valid modes. This was due to the no output mode set code, only adding the

Re: [PATCH 03/12] xf86: don't assign unused pointer.

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie Pointed out by coverity scan. Signed-off-by: Dave Airlie --- hw/xfree86/common/xf86pciBus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/common/xf86pciBus.c b/hw/xfree86/common/xf86pciBus.c index

Re: [PATCH 05/12] xnest/keyboard: fix dereference before null check

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie pointed out by coverity. Signed-off-by: Dave Airlie --- hw/xnest/Keyboard.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/xnest/Keyboard.c b/hw/xnest/Keyboard.c index ec629dc..c138438 100644 --- a/hw/xnes

Re: [PATCH 06/12] kdrive: fix dereference before null check.

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie pointed out by coverity scan. Signed-off-by: Dave Airlie --- hw/kdrive/linux/evdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/kdrive/linux/evdev.c b/hw/kdrive/linux/evdev.c index 3797f09..c8fc5bc 10

Re: [PATCH 07/12] ephyr: fix dereference before null check.

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie same as the xnest case. Signed-off-by: Dave Airlie --- hw/kdrive/ephyr/ephyr.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c index 7ebf1c2..67376cc 100644 -

Re: [PATCH 09/12] xv: test correct number of requests.

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie Pointed out by coverity. Signed-off-by: Dave Airlie --- Xext/xvdisp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xext/xvdisp.c b/Xext/xvdisp.c index 364a90c..71bf722 100644 --- a/Xext/xvdisp.c +++ b/Xext/x

Re: [PATCH 10/12] composite/xinerama: free newPix on error path.

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie newPix could be leaked if AddResource failed. pointed out by coverity scan. Signed-off-by: Dave Airlie --- composite/compext.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/composite/compext.c b/composite/

Re: [PATCH] xf86Crtc: handle no outputs with no modes harder.

2011-10-20 Thread Alex Deucher
On Thu, Oct 20, 2011 at 9:43 AM, Dave Airlie wrote: > From: Dave Airlie > > If you started an X server with no connected outputs, we pick a default > 1024x768 mode, however if you then ran an xvidmode using app against that > server it would segfault the server due to not finding any valid modes.

Re: [PATCH 3/5] Xi: avoid overrun of callback array.

2011-10-20 Thread Jamey Sharp
On Wed, Oct 19, 2011 at 05:01:45PM +0100, Dave Airlie wrote: > From: Dave Airlie > > This code had an off-by-one and would allow writing one past the end of > the callbacks array. I think you mean "reading" one past the end? I don't see any bad pointer writes here, though I'm only looking at the

Re: [Pull v2] Glamor - fixed build failure, fixed coding style problem.

2011-10-20 Thread Eric Anholt
On Thu, 20 Oct 2011 09:54:29 +0200, Jamey Sharp wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > This is also like Xgl, as I recall, in that Xgl was a large development > effort happening inside a company (Novell, in that case) and then being > dropped on the X.Org community

Re: [PATCH] xf86Crtc: handle no outputs with no modes harder.

2011-10-20 Thread Keith Packard
On Thu, 20 Oct 2011 14:43:01 +0100, Dave Airlie wrote: > + scrn->modes = xf86ModesAdd(scrn->modes, > +xf86CVTMode(scrn->display->virtualX, > +scrn->display->virtualY, > +60,

Re: [PATCH] xf86Crtc: handle no outputs with no modes harder.

2011-10-20 Thread Dave Airlie
On Thu, Oct 20, 2011 at 6:37 PM, Keith Packard wrote: > On Thu, 20 Oct 2011 14:43:01 +0100, Dave Airlie wrote: > >> +     scrn->modes = xf86ModesAdd(scrn->modes, >> +                                xf86CVTMode(scrn->display->virtualX, >> +                                            scrn->display-

Re: [PATCH] Xnest: Remove socket and its lock file on exit

2011-10-20 Thread Julien Cristau
Sorry I didn't catch this before it hit master, but: On Mon, Oct 10, 2011 at 12:19:19 -0700, Jeremy Huddleston wrote: > diff --git a/hw/xnest/Events.c b/hw/xnest/Events.c > index 619427d..2399313 100644 > --- a/hw/xnest/Events.c > +++ b/hw/xnest/Events.c > @@ -198,6 +198,8 @@ xnestCollectEvents(v

Re: [PATCH] Xnest: Remove socket and its lock file on exit

2011-10-20 Thread Jeremy Huddleston
On Oct 20, 2011, at 12:08, Julien Cristau wrote: >> if (xnestParentWindow != (Window) 0 && >>X.xdestroywindow.window == xnestParentWindow) >> +CloseWellKnownConnections(); >> +OsCleanup(1); >> exit (0); > That looks broken, don't you need braces around the if branch? Als

flagging implicit function declarations as errors (was: [PATCH] pci: Restore pciTag as a deprecated function)

2011-10-20 Thread Alan Coopersmith
On 10/19/11 23:45, Jamey Sharp wrote: On Wed, Oct 19, 2011 at 10:47:17AM -0700, Jeremy Huddleston wrote: I think we coddled the drivers enough with the current set of just-deprecations. This is too trivial. I'll just go through and make sure nobody is actually using it because drivers still bu

Re: [PATCH 11/12] composite/xinerama: free overlayWin on error paths.

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie pointed out by coverity scan. Signed-off-by: Dave Airlie --- composite/compext.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/composite/compext.c b/composite/compext.c index 01bd578..16daf23 100644 ---

Re: [PATCH 12/12] exa: initialise mask_off_x and mask_off_y

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie These get used at the end of the function in a calculation, even the result isn't used its not pretty. I can't quite follow the second line of that comment - the xMask & yMask calculation results are passed to the pExaScr->info->Composite

Re: [PATCH 02/12] xfree86: drop unused pointer setup

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie Coverity scan pointed this out. Drop unused randrp setup. Signed-off-by: Dave Airlie --- hw/xfree86/modes/xf86RandR12.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree

[PATCH] xfree86 doc: replace driver "keyboard" with "kbd"

2011-10-20 Thread Peter Hutterer
We've deprecated keyboard a long time ago Signed-off-by: Peter Hutterer --- hw/xfree86/doc/ddxDesign.xml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw/xfree86/doc/ddxDesign.xml index a4baad5..0d5e952 100644 --- a/hw/xfree86/doc/ddxD

Re: [PATCH RESEND 5/5] xfree86: use NewInputDeviceRequest for xorg.conf devices too

2011-10-20 Thread Peter Hutterer
On Thu, Oct 20, 2011 at 02:17:57PM +0100, Daniel Stone wrote: > Hi, > > On Thu, Oct 20, 2011 at 01:05:32PM +1000, Peter Hutterer wrote: > > diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c > > index 96e98c1..cb4be42 100644 > > --- a/hw/xfree86/common/xf86Config.c > > ++

Re: [PATCH 01/12] dix: fix double free around allocargbcursor.

2011-10-20 Thread Alan Coopersmith
On 10/20/11 03:44, Dave Airlie wrote: From: Dave Airlie coverity scan pointed this out. In some of its error cases AllocARGBCursor freed the bits passed in, because it assigned them to the cursor and called FreeCursorBits, in one case it didn't, if it hadn't done the assignment. This standardi

Re: [PATCH] xfree86 doc: replace driver "keyboard" with "kbd"

2011-10-20 Thread Alan Coopersmith
On 10/20/11 16:15, Peter Hutterer wrote: We've deprecated keyboard a long time ago Signed-off-by: Peter Hutterer --- hw/xfree86/doc/ddxDesign.xml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw/xfree86/doc/ddxDesign.xml index a4baa

Re: [PATCH 1/6] dix: add ScrollInfo to DeviceChangedEvents

2011-10-20 Thread Peter Hutterer
On Thu, Oct 20, 2011 at 02:03:25PM +0100, Daniel Stone wrote: > Hi, > > On Thu, Oct 20, 2011 at 04:25:41PM +1000, Peter Hutterer wrote: > > @@ -482,6 +483,41 @@ appendValuatorInfo(DeviceChangedEvent *dce, > > xXIValuatorInfo *info, int axisnumbe > > } > > > > static int > > +appendScrollInfo(

[PATCH inputproto] Use touchid, not touch_id in XIAllowEvents

2011-10-20 Thread Peter Hutterer
Be consistent with other usages of touchid. Signed-off-by: Peter Hutterer --- XI2proto.h |2 +- specs/XI2proto.txt |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/XI2proto.h b/XI2proto.h index 2460cf5..56df401 100644 --- a/XI2proto.h +++ b/XI2proto.h @@ -6

Re: [PATCH inputproto] Use touchid, not touch_id in XIAllowEvents

2011-10-20 Thread Chase Douglas
On 10/20/2011 05:07 PM, Peter Hutterer wrote: > Be consistent with other usages of touchid. > > Signed-off-by: Peter Hutterer Fine with me. Reviewed-by: Chase Douglas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

[PULL] device changed events, input device init fixes

2011-10-20 Thread Peter Hutterer
commit a7b75651cad0d208a2add480a074050c8e96bb44 The following changes since commit af3f64fb77c13180e513ee99d1fd9a1b624fd8ea: Merge remote-tracking branch 'hramrach/pull' (2011-10-19 17:33:07 -0700) are available in the git repository at: git://people.freedesktop.org/~whot/xserver for-keith

Re: [PATCH] x11proto: add permille, ezh, and EZH to keysymdef.h

2011-10-20 Thread Matt Dew
On 10/20/2011 01:47 AM, Marko Myllynen wrote: Hi, On 2011-10-18 20:15, Matt Dew wrote: On 10/17/2011 03:07 AM, Marko Myllynen wrote: There's a comment in the keysymdef.h file: ezh/EZH happened to be in ranges covered by IPAExt_upper_mapping and LatinExtB_{upper,lower}_mapping mappings in K

Glamor - next step

2011-10-20 Thread Zhigang Gong
Hi folks, Thanks for your valuable advices. To incrementally merge glamor with current video driver is indeed a more reasonable and less risk solution than merge it directly into xorg. The idea to bind BOs to a textures works fine. Actually, I already did so when I try to get DRI2 work with gla

Re: [PATCH] test: Add unit test for mieq

2011-10-20 Thread Peter Hutterer
On Wed, Oct 19, 2011 at 10:55:46AM -0700, Jeremy Huddleston wrote: > > On Oct 18, 2011, at 10:03 PM, Peter Hutterer wrote: > > > On Mon, Oct 17, 2011 at 11:59:38PM -0700, Jeremy Huddleston wrote: > >> > >> Signed-off-by: Jeremy Huddleston > >> --- > >> > >> The comments only really make sense

[PATCH synaptics] eventcomm: print strerror(errno), not of rc

2011-10-20 Thread Peter Hutterer
Found by coverity. Signed-off-by: Peter Hutterer --- src/eventcomm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index e0a6965..cd08f13 100644 --- a/src/eventcomm.c +++ b/src/eventcomm.c @@ -227,7 +227,7 @@ event_get_abs(InputInfoPt