On Sat, Jun 08, 2013 at 10:22:25AM -0700, Matt Turner wrote:
On Sat, Jun 8, 2013 at 9:07 AM, Matthieu Herrb matthieu.he...@laas.fr wrote:
Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
I'm inclined to push these, but they cause redefinition warnings
during compilation:
Well, I think I tested the patch and did not see those warnings,
but now I am getting them as well.
Since they are added to the .h file, perhaps they should be removed
from XAW3D_CPPFLAGS and xaw3d.pc's
On 06/ 8/13 11:28 AM, Thomas Klausner wrote:
On Fri, Jun 07, 2013 at 08:39:52PM -0700, Alan Coopersmith wrote:
On 06/ 2/13 01:38 PM, Thomas Klausner wrote:
---
configure.ac | 4 +-
src/netbsd_pci.c | 471 +++
2 files changed, 342
On Sun, Jun 09, 2013 at 09:32:37AM -0700, Alan Coopersmith wrote:
On 06/ 8/13 11:28 AM, Thomas Klausner wrote:
On Fri, Jun 07, 2013 at 08:39:52PM -0700, Alan Coopersmith wrote:
On 06/ 2/13 01:38 PM, Thomas Klausner wrote:
---
configure.ac | 4 +-
src/netbsd_pci.c | 471
The padding is *before* the rate field, so the rate is placed on a 32bit
boundary. This change adds explicit padding between height and rate,
and removes extraneous padding after the rate field, which the server
never sent and xlib never read.
This changes sizeof(xvEncodingInfo). Hopefully
Thanks for the feedback! I've split the patch into the two halves and
updated return values, etc. I'm not too familiar with the Data API,
so I left things as-is for the time-being. If the second patch isn't
right, hopefully the first is still useful. :)
Thanks,
-Kees
This fixes the two callers of GetReqExtra to check that req is non-NULL
to avoid crashing now that GetReqExtra does internal bounds-checking on
the resulting buffer sizes.
Additionally updates comment describing return values to use names
instead of only literal values.
Signed-off-by: Kees Cook
Two users of GetReqExtra pass arbitrarily sized allocations from the
caller (ModMap and Host). Adjust _XGetRequest() (called by the GetReqExtra
macro) to double-check the requested length and invalidate req when
this happens. Users of GetReqExtra passing lengths greater than the Xlib
buffer size
On Sun, Jun 02, 2013 at 10:38:41PM +0200, Thomas Klausner wrote:
---
configure.ac | 4 +-
src/netbsd_pci.c | 471
+++
2 files changed, 342 insertions(+), 133 deletions(-)
Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr
diff
