Re: [PATCH][vmware] build: add explicit option to enable/disable VMWGFX

2013-09-13 Thread Gaetan Nadon
On 13-09-13 10:33 AM, Julien Cristau wrote: > On Fri, Sep 13, 2013 at 09:08:22 +0100, Burton, Ross wrote: > >> On 13 September 2013 06:01, Jakob Bornecrantz wrote: >>> If I'm reading this correctly this will cause the build to fail if >>> you don't give it the disable flag if xatracker is missing?

Re: [PATCH][vmware] build: add explicit option to enable/disable VMWGFX

2013-09-13 Thread Julien Cristau
On Fri, Sep 13, 2013 at 09:08:22 +0100, Burton, Ross wrote: > On 13 September 2013 06:01, Jakob Bornecrantz wrote: > > If I'm reading this correctly this will cause the build to fail if > > you don't give it the disable flag if xatracker is missing? > > I'm on the fence if we want this, is this a

Re: [PATCH] xf86VGAarbiter,vgaHW: Only wrap co-operating VGA drivers

2013-09-13 Thread Chris Wilson
On Fri, Sep 13, 2013 at 01:40:51PM +0200, Mark Kettenis wrote: > > Date: Fri, 13 Sep 2013 11:09:45 +0100 > > From: Chris Wilson > > > > On Fri, Sep 13, 2013 at 11:56:26AM +0200, Mark Kettenis wrote: > > > Wouldn't it make sense to move all arbitration for KMS devices into > > > the kernel? For t

Re: [PATCH] xf86VGAarbiter,vgaHW: Only wrap co-operating VGA drivers

2013-09-13 Thread Mark Kettenis
> Date: Fri, 13 Sep 2013 11:09:45 +0100 > From: Chris Wilson > > On Fri, Sep 13, 2013 at 11:56:26AM +0200, Mark Kettenis wrote: > > Wouldn't it make sense to move all arbitration for KMS devices into > > the kernel? For the broken intel devices that can't turn off legacy > > VGA access completel

Re: [PATCH] xf86VGAarbiter,vgaHW: Only wrap co-operating VGA drivers

2013-09-13 Thread Chris Wilson
On Fri, Sep 13, 2013 at 11:56:26AM +0200, Mark Kettenis wrote: > Wouldn't it make sense to move all arbitration for KMS devices into > the kernel? For the broken intel devices that can't turn off legacy > VGA access completely you'd then have the kernel report that it > doesn't need any legacy res

Re: [PATCH][vmware] build: add explicit option to enable/disable VMWGFX

2013-09-13 Thread Jakob Bornecrantz
On Fri, Sep 13, 2013 at 10:08 AM, Burton, Ross wrote: > On 13 September 2013 06:01, Jakob Bornecrantz > wrote: > > If I'm reading this correctly this will cause the build to fail if > > you don't give it the disable flag if xatracker is missing? > > I'm on the fence if we want this, is this a pro

Re: [PATCH] xf86VGAarbiter,vgaHW: Only wrap co-operating VGA drivers

2013-09-13 Thread Mark Kettenis
> Date: Thu, 12 Sep 2013 22:16:58 +0100 > From: Chris Wilson > > On Thu, Sep 12, 2013 at 11:55:57PM +0300, Ville Syrjälä wrote: > > On Thu, Sep 12, 2013 at 12:37:44PM +0100, Chris Wilson wrote: > > > Presently, we wrap every single operation on every driver if the kernel > > > reports that there

Re: [PATCH] xf86VGAarbiter,vgaHW: Only wrap co-operating VGA drivers

2013-09-13 Thread Chris Wilson
On Thu, Sep 12, 2013 at 06:40:18PM -0400, Daniel Stone wrote: > Hi, > > On 12 September 2013 07:37, Chris Wilson wrote: > > The approach taken in this patch is to first only enable VGA arbitration > > for drivers that require VGA resources. This is detected by moving the > > initialisation from t

Re: [PATCH][vmware] build: add explicit option to enable/disable VMWGFX

2013-09-13 Thread Burton, Ross
On 13 September 2013 06:01, Jakob Bornecrantz wrote: > If I'm reading this correctly this will cause the build to fail if > you don't give it the disable flag if xatracker is missing? > I'm on the fence if we want this, is this a problem you have > run into? Correct, defaults to enabled and will