Re: [PULL] systemd integration patches

2014-01-28 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 01/28/2014 12:39 AM, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: Hans de Goede (5): dbus-core: Make dbus-core no longer mutually exclusive with udev dbus-core: Attempt to connect to dbus ASAP xf86Events: split

Re: [PATCH 07/12] hotplug: Modify OdevAttributes for server-managed fd support

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 08:01 AM, Dave Airlie wrote: On 16 Jan 2014 00:33, Hans de Goede hdego...@redhat.com wrote: With systemd-logind support, the xserver, rather then the drivers will be responsible for opening/closing the fd for drm nodes. The initial open will happen on probe from

Re: [PATCH 05/12] xf86Events: add Enable/DisableInputDeviceForVTSwitch functions

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 07:35 AM, Peter Hutterer wrote: On Wed, Jan 15, 2014 at 03:32:19PM +0100, Hans de Goede wrote: Factor this code out into functions so that it can be re-used for the systemd-logind device pause/resume paths. Signed-off-by: Hans de Goede hdego...@redhat.com I'd probably

Re: [PULL] systemd integration patches

2014-01-28 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 01/28/2014 09:08 AM, Hans de Goede wrote: Hi, On 01/28/2014 12:39 AM, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: Hans de Goede (5): dbus-core: Make dbus-core no longer mutually exclusive with udev dbus-core:

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 07:46 AM, Peter Hutterer wrote: On Thu, Jan 23, 2014 at 02:58:17PM +0100, Hans de Goede wrote: Hi, On 01/23/2014 01:56 PM, Daniel Stone wrote: Hi, On 23 January 2014 11:16, Hans de Goede hdego...@redhat.com wrote: Ok, I've put it back in config (while keeping the other

Re: [PATCH 08/12] systemd-logind: Add systemd-logind core

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 08:15 AM, Peter Hutterer wrote: On Wed, Jan 15, 2014 at 03:32:22PM +0100, Hans de Goede wrote: This commits add the bulk of the systemd-logind integration code, but does not hook it up yet other then calling its init and fini functions, which don't do that much. snip @@

Re: [PATCH 08/12] systemd-logind: Add systemd-logind core

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 08:52 AM, David Herrmann wrote: Hi Peter On Tue, Jan 28, 2014 at 8:15 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Jan 15, 2014 at 03:32:22PM +0100, Hans de Goede wrote: This commits add the bulk of the systemd-logind integration code, but does not hook it

Re: [Mesa-dev] What use do swap interval 1 and OML_sync_control divisor and remainder have?

2014-01-28 Thread Pekka Paalanen
Hi Ian and Jason On Mon, 27 Jan 2014 12:26:23 -0700 Ian Romanick i...@freedesktop.org wrote: On 01/24/2014 04:32 AM, Pekka Paalanen wrote: Hi, I am investigating what kind of Wayland protocol extensions would be needed to support proper presentation timing. Looking at existing works,

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Hans de Goede
Hi, On 01/23/2014 02:58 PM, Hans de Goede wrote: Hi, On 01/23/2014 01:56 PM, Daniel Stone wrote: snip 8d972e0c xf86Xinput: Modify API for server-managed fd support I worry a little that drivers won't necessarily support this - would be nice to check by forcing them to define

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 02:14 PM, Julien Cristau wrote: On Tue, Jan 28, 2014 at 11:33:01 +0100, Hans de Goede wrote: As for the worries of drivers not being prepared to deal with this, systemd_logind_take_fd will only succeed for evdev devices, and AFAIK we've only 2 drivers for those evdev and

Re: [PULL] systemd integration patches

2014-01-28 Thread Keith Packard
Hans de Goede hdego...@redhat.com writes: Correction, Peter Hutterer has just reviewed the other 3 and given his: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Awesome! So all are reviewed now, can you pull as is, or do you want a new pull-req with Peter's Reviewed-by added to the

Re: [PULL] systemd integration patches

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 05:35 PM, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: Correction, Peter Hutterer has just reviewed the other 3 and given his: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Awesome! So all are reviewed now, can you pull as is, or do you want a

Re: [PATCH 07/12] hotplug: Modify OdevAttributes for server-managed fd support

2014-01-28 Thread Dave Airlie
On Tue, Jan 28, 2014 at 6:49 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 01/28/2014 08:01 AM, Dave Airlie wrote: On 16 Jan 2014 00:33, Hans de Goede hdego...@redhat.com wrote: With systemd-logind support, the xserver, rather then the drivers will be responsible for opening/closing

Re: [PATCH] modesetting: 24bpp are too confusing, shadow our way out.

2014-01-28 Thread Dave Airlie
We should already be hiding this from clients -- 24bpp front buffer exposes 32bpp images and shared memory pixmaps. Are you saying that in-server software rendering to 24bpp object is broken? Well clients doing things direct to the 24bpp window might have issues? I can't tell for sure, its a

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Peter Hutterer
On Tue, Jan 28, 2014 at 10:12:30AM +0100, Hans de Goede wrote: 8d972e0c xf86Xinput: Modify API for server-managed fd support I worry a little that drivers won't necessarily support this - would be nice to check by forcing them to define I_SUPPORT_SERVER_MANAGED_FDS or something; either

[PATCH libX11 2/2] nls: remove duplicate Hebrew compose sequences

2014-01-28 Thread Ran Benita
Some of the hebrew keysyms come in different spellings, but are just aliases, so the sequences are duplicates. Remove the ones which keysymdef.h marks 'deprecated'. Signed-off-by: Ran Benita ran...@gmail.com --- nls/en_US.UTF-8/Compose.pre | 10 -- 1 file changed, 10 deletions(-) diff

[PATCH libX11 1/2] nls: remove duplicate 'ohorn' and 'uhorn' compose sequences

2014-01-28 Thread Ran Benita
Since Ohorn == U01A0 and ohorn == U01A1, when translated to keysyms: #define XK_Ohorn 0x10001a0 /* U+01A0 LATIN CAPITAL LETTER O WITH HORN */ #define XK_ohorn 0x10001a1 /* U+01A1 LATIN SMALL LETTER O WITH HORN */ (and similarly for uhorn), there is

[PATCH libX11 0/2] Remove duplicate compose sequences

2014-01-28 Thread Ran Benita
I was playing with en_US.UTF-8 file a bit. These patches fix the issues I found while constructing the trie. Happily the sequences are all prefix-free, so there are only some duplicates to remove. Ran Benita (2): nls: remove duplicate 'ohorn' and 'uhorn' compose sequences nls: remove

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Peter Hutterer
On Tue, Jan 28, 2014 at 04:54:00PM +0100, Hans de Goede wrote: Hi, On 01/28/2014 02:14 PM, Julien Cristau wrote: On Tue, Jan 28, 2014 at 11:33:01 +0100, Hans de Goede wrote: As for the worries of drivers not being prepared to deal with this, systemd_logind_take_fd will only succeed for

Re: [PATCH 10/12] config-udev: Don't try to add drm devices twice

2014-01-28 Thread Peter Hutterer
On Wed, Jan 15, 2014 at 03:32:24PM +0100, Hans de Goede wrote: Before this commit we were trying to add most drm devices twice, once from xf86platformProbe() and once from config_udev_init(). This results in somewhat confusing messages in Xorg.log, ie: (II) xfree86: Adding drm device

Re: [PATCH 11/12] config-udev: Refactor input device addition for delayed input device probing

2014-01-28 Thread Peter Hutterer
On Wed, Jan 15, 2014 at 03:32:25PM +0100, Hans de Goede wrote: With systemd-logind we need to delay input device probing when switched away (iow not on the active vt). This is a preparation patch for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/udev.c | 150

Re: [PATCH 09/12] systemd-logind: Hookup systemd-logind integration

2014-01-28 Thread Peter Hutterer
On Wed, Jan 15, 2014 at 03:32:23PM +0100, Hans de Goede wrote: This commits makes the changes necessary outside of the systemd-logind core to make the server use systemd-logind managed fds for input devices and drm nodes. Signed-off-by: Hans de Goede hdego...@redhat.com minus the comments

Re: [PATCH 12/12] config-udev: Add delayed input device probing

2014-01-28 Thread Peter Hutterer
On Wed, Jan 15, 2014 at 03:32:26PM +0100, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- config/udev.c| 35 ++-- hw/xfree86/os-support/linux/systemd-logind.c | 4 include/hotplug.h

[PATCH resend 1/4] Link libvgahw with $(PCIACCESS_LIBS) as well

2014-01-28 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/vgahw/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/hw/xfree86/vgahw/Makefile.am b/hw/xfree86/vgahw/Makefile.am index f0b6574..4b718b4 100644 --- a/hw/xfree86/vgahw/Makefile.am +++

[PATCH resend 2/4] On realloc failure, free font_path_string instead of leaking it

2014-01-28 Thread Alan Coopersmith
Flagged by cppcheck 1.62: [dix/dixfonts.c:1792]: (error) Common realloc mistake: 'font_path_string' nulled but not freed upon failure Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- dix/dixfonts.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH resend 3/4] xf86DeleteScreen: move check for NULL pScrn before first dereference

2014-01-28 Thread Alan Coopersmith
Flagged by cppcheck 1.62: [hw/xfree86/common/xf86Helper.c:220] - [hw/xfree86/common/xf86Helper.c:231]: (warning) Possible null pointer dereference: pScrn - otherwise it is redundant to check it against null. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---

[PATCH resend 4/4] Add RANDR 1.4 requests events to dix/protocol.txt

2014-01-28 Thread Alan Coopersmith
Checked against randrproto.txt randr.h Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- dix/protocol.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/dix/protocol.txt b/dix/protocol.txt index 8e152ed..f83f38c 100644 --- a/dix/protocol.txt +++

[PATCH resend 0/4] assorted odds and ends

2014-01-28 Thread Alan Coopersmith
The first three were originally mailed on 12/26, the last one on 1/18. I've gone ahead and pushed the Xlib side of the RANDR 1.4 request/error/event names patch to the libX11 git repo already. Alan Coopersmith (4): Link libvgahw with $(PCIACCESS_LIBS) as well On realloc failure, free

Re: [PATCH resend 0/4] assorted odds and ends

2014-01-28 Thread Peter Hutterer
On Tue, Jan 28, 2014 at 08:27:48PM -0800, Alan Coopersmith wrote: The first three were originally mailed on 12/26, the last one on 1/18. I've gone ahead and pushed the Xlib side of the RANDR 1.4 request/error/event names patch to the libX11 git repo already. Alan Coopersmith (4): Link

Re: [PATCH] modesetting: 24bpp are too confusing, shadow our way out.

2014-01-28 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: We should already be hiding this from clients -- 24bpp front buffer exposes 32bpp images and shared memory pixmaps. Are you saying that in-server software rendering to 24bpp object is broken? Well clients doing things direct to the 24bpp window might

Re: [PATCH] Replace 'pointer' with the equivalent 'void *'.

2014-01-28 Thread Knut Petersen
On 27.01.2014 22:59, Keith Packard wrote: Gaetan Nadon mems...@videotron.ca writes: On 14-01-27 03:00 PM, Keith Packard wrote: Here's a patch for libXfont. I have no patch for xfs, and would welcome anyone to go ahead and fix that. xfs is fine. My source tree became into an invalid state at