Re: [PATCH 0/3] xkb: Fix ISOLock

Hi Andreas, On Thu, Jan 23, 2014 at 09:00:11PM +0100, wettstein...@solnet.ch wrote: The goal of the following patches is to make ISOLock work. The most severe issues addressed were in the server, where the code used the incorrect byte to look for the affect flags, and where the ClearLocks

Re: [PATCH 2/7] xkb: add a call to init an XkbRMLVOSet from const chars

Hi, On 02/03/2014 01:07 AM, Peter Hutterer wrote: On Fri, Jan 31, 2014 at 05:30:58PM +0100, Hans de Goede wrote: Hi, On 01/31/2014 12:36 AM, Peter Hutterer wrote: On Thu, Jan 30, 2014 at 09:40:33AM +0100, Hans de Goede wrote: Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: Just forcing

Re: [PATCH] dri3: Don't enable the DRI3 extension unless some screen supports it

Keith Packard kei...@keithp.com writes: There's no reason to advertise this extension unless one of the hardware drivers actually supports it. Not listing it means it's slightly easier for users to tell what's going on. On the other hand, not listing it means we may have applications that

[PATCH 6/8] xephyr: Build support for rendering with glamor using a -glamor option.

Signed-off-by: Eric Anholt e...@anholt.net --- configure.ac | 3 + glamor/glamor.c| 11 ++ glamor/glamor.h| 2 + hw/kdrive/ephyr/Makefile.am| 20 ++- hw/kdrive/ephyr/ephyr.c| 36 +++-- hw/kdrive/ephyr/ephyr.h

[PATCH 4/8] glamor: Fix attempting to compile shaders with no active context.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_core.c b/glamor/glamor_core.c index 5246c98..5883809 100644 --- a/glamor/glamor_core.c +++ b/glamor/glamor_core.c @@ -215,6 +215,7 @@

[PATCH 5/8] glamor: Promote the screen pixmap to a texture when it starts as MEMORY.

If you're building a new X Server and trying to light up glamor, one of the first things you want to do is get it rendering the screen to a texture so you can later draw that to some real output (or possibly not draw it at all, if it's Xvfb-like). Don't just leave it in a segfaulting MEMORY

[PATCH 3/8] glamor: Put in a pluggable context switcher for GLX versus EGL.

The GLX side just gets the context from the current state. That's also something I want to do for EGL, so that the making a context is separate from initializing glamor, but I think I need the modesetting driver in the server before I think about hacking on that more. The previous code was

[PATCH 8/8] xephyr: Use GLX swap events to reduce repaints.

If there's a swap already outstanding, don't bother queueing another one until this one has completed. The assumption here is that our screen paints are cheap compared to everything else going on, so we don't need to queue them up way ahead of time. The swap events also give us information we

[PATCH 7/8] xephyr: Pass incoming XCB events to the Xlib event filter.

This is the same thing that Qt ended up doing to get DRI2's event mangling to happen despite using an XCB event loop. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyr.c| 3 +++ hw/kdrive/ephyr/ephyr_glamor_glx.c | 39 ++

[PATCH 2/8] glamor: Rename glamor_get/put_dispatch to glamor_get/put_context.

It used to be the thing that returned your dispatch table and happeend to set up the context, but now it just sets up the context. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 8 glamor/glamor_copyarea.c | 18 +- glamor/glamor_core.c

xephyr-glamor series

Additionally, there's a rendering bug when you run some Render-using applications (cairogears -xrender TRAP shows it off very well) that I think is fallback-related but I haven't quite tracked it down yet. You can see some fallback fixes in glamor-server I wrote while trying to fix this. This

[PATCH 02/15] glamor: Drop fixed function transformation matrix setup.

gl_ModelViewProjection and friends aren't used in our shaders, so this setup didn't do anything. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index 9fe2b2e..41d5f5a

[PATCH 03/15] glamor: yInverted is a boolean value, so use the Bool type.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 4 ++-- glamor/glamor_priv.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index f1c71ea..ba2a1f4 100644 --- a/glamor/glamor.c +++ b/glamor/glamor.c @@ -308,10 +308,10

[PATCH 04/15] glamor: Drop a bunch of GLES2 ifdefs.

Now that we're using epoxy, we can write code using both desktop and ES symbols and decide what to use at runtime. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 40 +++- glamor/glamor_copyarea.c | 15 ++-

[PATCH 14/15] glamor: Move the EGL DRI3 code to GLAMOR_HAS_GBM.

There's nothing dependent on the presence of DRI3 code in the server for this, but it does rely on GBM. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_egl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c

[PATCH 01/15] glamor: Drop useless glEnable/glDisable(GL_TEXTURE_2D) calls.

Those calls are only for enabling texture handling in the fixed function pipeline, while everything we do is with shaders. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_copyarea.c | 4 glamor/glamor_pixmap.c| 6 -- glamor/glamor_putimage.c | 2 --

[PATCH 07/15] glamor: Unifdef the cache format indices.

We only ask for GL_RGB on desktop GL as far as I can see, but now if GLES2 did happen to ask for GL_RGB it would return a cache index instead of -1. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 4 glamor/glamor_utils.h | 18 ++ 2 files changed, 2

[PATCH 15/15] xephyr: Allow initializing glamor with gles2 (on GLX).

This should be useful for glamor development, so you can test both paths (which are significantly different, and apparently glamor_gradient.c was broken on GLES2 as of the import). Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyr_glamor_glx.c | 24 +++-

[PATCH 09/15] glamor: Unifdef the picture-format-to-format-and-type functions.

There's no way these should be in a header file, but I'll leave that cleanup until later. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 50 +- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git

[PATCH 10/15] glamor: Move shader precision stuff from build time to shader compile time.

This is the last desktop-versus-ES2 build ifdef in core glamor. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 81b46b6..e28a021 100644 ---

[PATCH 11/15] glamor: Fix typo in setting v_position's attrib location.

Assuming it was the first attribute assigned by the GL, it would have ended up with location 0 anyway. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_gradient.c b/glamor/glamor_gradient.c

[PATCH 08/15] glamor: Move glamor_get_tex_format_type_from_pictformat to a .c file.

A pair of 150 lines of inlined switch statements in a header file is crazy. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 303 + glamor/glamor_utils.h | 303 - 2 files

[PATCH 12/15] glamor: Don't bother keeping references to shader stages for gradients.

They never get reattached to any other program, so saving them to unreference later is a waste of code. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 88 glamor/glamor_priv.h | 9 - 2 files changed, 6

[PATCH 05/15] glamor: Add a screen argument to drop an ifdef from glamor_set_alu().

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_copyarea.c | 7 --- glamor/glamor_fill.c | 4 ++-- glamor/glamor_pixmap.c | 17 +++-- glamor/glamor_priv.h | 2 +- glamor/glamor_tile.c | 4 ++-- 5 files changed, 20 insertions(+), 14 deletions(-) diff

[PATCH 06/15] glamor: Pass pixmaps around to unifdef glamor_iformat_for_depth().

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 6 +++--- glamor/glamor_picture.c | 3 +-- glamor/glamor_pixmap.c | 4 ++-- glamor/glamor_utils.h | 26 -- 4 files changed, 18 insertions(+), 21 deletions(-) diff --git a/glamor/glamor.c

[PATCH 13/15] glamor: Fix linking of the gradient shaders on GLES2.

GLES2 sensibly doesn't allow you to attach multiple shaders for the same stage to a single program. This means we have to attach the whole thing in one glShaderSource call. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 68

Re: [PATCH 0/3] xkb: Fix ISOLock

Hello Ran, Do you happen to have a keymap which is using any of the ISO stuff? I do not have a keymap that use ISOLock. Furthermore, bugzilla does not seem to have any bug report on ISOLock. xkeyboard-config removed it from the compat section about two years ago, which means ISOLock cannot be

Re: [PATCH 5/5] test: Fix compiler warning on 64-bit.

Mark Kettenis mark.kette...@xs4all.nl writes: From: Eric Anholt e...@anholt.net Date: Mon, 27 Jan 2014 11:36:09 -0800 We all know that XIDs are 32 bits, even if 32-bit headers call them long. --- test/hashtabletest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH:xf86-video-ati] Make RADEONCopySwap deal with misaligned buffers.

When using xvideo on alignement critical architectures (for example a sparc64 with the XVR100 graphics adapter) some screen positions (easily reproducable with xfce and gmplayer by moving the video window partly out of the screen on the left side) cause misaligned pointers being passed to

Re: [PATCH 04/15] glamor: Drop a bunch of GLES2 ifdefs.

Le lundi 03 février 2014 à 11:03 -0800, Eric Anholt a écrit : -#ifndef GLAMOR_GLES2 -if (gl_version GLAMOR_GL_VERSION_ENCODE(1, 3)) { -ErrorF(Require OpenGL version 1.3 or latter.\n); -goto fail; -} -#else -if (gl_version GLAMOR_GL_VERSION_ENCODE(2, 0)) { -

Re: [PATCH] dix: Clear any existing selections before initializing privates

On Mon, 2013-12-30 at 09:15 -0600, Andrew Eikum wrote: If there is a selection left over from a previous execution of the main loop, and that selection has privates allocated for it, the X server will crash. This is because dixResetPrivates() resets the privates refcounts to zero without

Re: [PATCH] glx: Remove left-over glthread.c

On Wed, 2014-01-22 at 15:08 -0800, Eric Anholt wrote: Jon TURNEY jon.tur...@dronecode.org.uk writes: Commit be668096 glx: convert to direct GL dispatch (v2) removes glthread.c from Makefile.am along with the rest of the dispatch table code, but doesn't remove glthread.c itself.

Re: State of the present-extension?

On Thu, 2014-01-23 at 10:19 +0100, Clemens Eisserer wrote: I recently saw Keith's video about tear-free X11 applications using the present extension and would like to work use this extension in OpenJDKs's Xrender backend. However I had a hard time to find information how to use it and which

Re: [PATCH 01/15] glamor: Drop useless glEnable/glDisable(GL_TEXTURE_2D) calls.

On Mon, 2014-02-03 at 11:03 -0800, Eric Anholt wrote: Those calls are only for enabling texture handling in the fixed function pipeline, while everything we do is with shaders. Signed-off-by: Eric Anholt e...@anholt.net Series is: Reviewed-by: Adam Jackson a...@redhat.com

Re: [PATCH 1/5] glx: Stop relying on libGL ABI bugs for glGetCompressedTexImage().

On Mon, 2014-01-27 at 11:36 -0800, Eric Anholt wrote: In theory, the linux libGL ABI exposes just GL 1.2 plus GLX 1.3. But, thanks to libglapi, we're letting glGetCompressedTexImageARB() be exposed too. The GLX code was inappropriately relying on it by using GL_GLEXT_PROTOTYPES. 1-4 of this

[PATCH v2 3/7] input: un-constify InputAttributes

Introduced in fecc7eb1cf66db64728ee2d68cd9443df7e70879 and reverts most of that but it's helpfully mixed with other stuff. InputAttributes are not const, they're strdup'd everywhere but the test code and freed properly. Revert the const char changes and fix the test up instead. Signed-off-by:

[PATCH] __glGetProcAddress: explictly cast function pointers to void *

Fixes Solaris Studio compiler warning error: glxext.c, line 557: warning: assignment type mismatch: pointer to void = pointer to function(void) returning void glxext.c, line 559: error: operands have incompatible types: pointer to void : pointer to function(void)

[PATCH] Add check for link from output to crtc before optimizing out a CrtcSet call

The function RRCrtcSet call checks to see if the config being set is already configured, but, doesn't check that the selected outputs are connected to the crtc before skipping. This means that the following sequence will omit the final CrtcSet call to the driver: CRTC c1 connect to output o

Re: [PATCH:xf86-video-ati] Make RADEONCopySwap deal with misaligned buffers.

On Mon, 2014-02-03 at 20:36 +0100, Martin Husemann wrote: When using xvideo on alignement critical architectures (for example a sparc64 with the XVR100 graphics adapter) some screen positions (easily reproducable with xfce and gmplayer by moving the video window partly out of the screen on the

Re: [PATCH 04/15] glamor: Drop a bunch of GLES2 ifdefs.

On Mon, 2014-02-03 at 11:03 -0800, Eric Anholt wrote: Now that we're using epoxy, we can write code using both desktop and ES symbols and decide what to use at runtime. Nice. diff --git a/glamor/glamor_copyarea.c b/glamor/glamor_copyarea.c index 498a06e..8cc7cad 100644 ---