glamor.h cannot be included without first including xorg-server.h, this also
applies to including it from configure snippets.
Without this the configure glamor checks fail on systems with the latest
glibc, throwing this error:
In file included from /usr/include/xorg/misc.h:115:0,
This uses a single large triangle and a scissor to draw the video
instead of two triangles.
Signed-off-by: Keith Packard
---
glamor/glamor_xv.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/glamor/glamor_xv.c b/glamor/glamor_xv.c
index 68a06a4..3f3e064 100644
Dave Airlie writes:
> From: Fedora X Ninjas
>
> If the user wants to set one of the slave devices as
> the primary output, we shouldn't fail to do so,
> we were returning BadMatch which was tripping up
> gnome-settings-daemon and bad things ensues.
>
> Fix all the places we use primaryOutput to
Egbert Eich writes:
> Hi Keith,
>
> sorry for delaying this. I was occupied with other things and
> therefore wanted to wait for a bigger time window.
This patch doesn't appear to have been merged yet; do you want to try
and figure out what the status is?
--
keith.pack...@intel.com
pgpkegHMW
pharris says that the resets should not be done in the hotplugging case.
This may fix a crash reported against XQuartz:
http://xquartz.macosforge.org/trac/ticket/869
Signed-off-by: Jeremy Huddleston Sequoia
CC: Peter Harris
CC: Kristian Høgsberg
---
os/connection.c | 7 ---
1 file changed
Dave Airlie writes:
> From: Dave Airlie
>
> When you include files from mesa that might want to use stdbool
> things get messed up.
>
> This is an API break I think and I've no idea what drivers might
> use this, so we can hold off on it.
Did you want to fix up this patch so that xf86Option.c c
Ross Burton writes:
> xshmfence is usable outside of DRI3, and is currently autodetected which isn't
> good for distributions where deterministic builds are desired.
Merged (with review).
2172714..4afedf5 master -> master
--
keith.pack...@intel.com
pgp9vg3u8E9q_.pgp
Description: PGP sign
GCC 4.2 doesn't accept 2 typedef declarations of the same type, so
remove the extra one from xf86Xinput.h and have xf86Xinput.h #include
xf86.h to make sure everyone using just that file gets the typedef.
Signed-off-by: Keith Packard
---
hw/xfree86/common/xf86Xinput.h | 5 +++--
1 file changed,
David Ung writes:
> ping?
>
>
> From: David Ung [dav...@nvidia.com]
> Sent: Thursday, July 17, 2014 5:19 PM
> To: xorg-devel@lists.x.org
> Cc: David Ung
> Subject: [PATCH] randr: Fix logic in RRPointerToNearestCrtc
>
> RRPointerToNearestCrtc is suppose to
Eric Anholt writes:
> Color key overlay implementations want to reuse this code, and XF86's
> had bugs.
It might be helpful to describe which bugs were in the xf86 code so that
these two implementations could be compared.
--
keith.pack...@intel.com
pgp8LOItOGuFH.pgp
Description: PGP signatur
Adam Jackson writes:
> Resend of the equivalent series from May. I'm sure I had to touch up
> some of it to account for whatever arch patches we added between then
> and now, but I forget which, so the individual patches lack versioning;
> sorry about that.
>
> Between this, the servermd.h rewri
Adam Jackson writes:
> The majority of arches end up on the right-shift path here. I can't
> think of any arch where that'd be slower than a divide, and semantically
> it makes more sense to think of this as a shift operation anyway.
>
> Signed-off-by: Adam Jackson
Merged (with review):
6dd
Adam Jackson writes:
> isItTimeToYield in the conditional effectively didn't do anything here.
> Take it out, and remove the comment since LBX proxies aren't a thing for
> us anymore.
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgp78FdZE9mK6.pgp
Description: PGP signature
Adam Jackson writes:
> Signed-off-by: Adam Jackson
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgp4rQekOkWX7.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
I
Adam Jackson writes:
> This came in between XFree86 4.3 and 4.4, I'm not entirely sure what it
> was meant to do.
It constructs a region for all windows in a tree of a specific
depth. Use this to compute window clipping in hardware that has multiple
planes of different depths.
However, it's not
Adam Jackson writes:
> Here's a trip down memory lane. Back when we merged kdrive we adopted
> kdrive's version of shadow, which used damage directly instead of
> hand-rolling it. However a couple of Xorg drivers referred to the
> accumulated damage region in the shadow private directly, so I a
Adam Jackson writes:
> This code is nonsensical. You end up creating a screen-sized pixmap
> that's totally detached from everything else, which you then listen for
> damage on, which means you'll never hear any damage, which means your
> shadow update hooks will never get called. Any driver us
Adam Jackson writes:
> Arguably this would be useful API, but it's never called, and a careful
> reading of the CPClipMask path reveals that callers would be fairly
> disappointed.
Yeah, kinda misses setting the actual clip rects.
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgpB3
Adam Jackson writes:
> Signed-off-by: Adam Jackson
Also eliminates a bug where the open-coded version wasn't checking the
return value from malloc.
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgpnbGzaFadP9.pgp
Description: PGP signature
__
Adam Jackson writes:
> Never been built since m12n, can't be needed.
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgp18RQog7qp1.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/arch
>> RRPointerToNearestCrtc is suppose to snap to the nearest Crtc,
>> but the code is buggy. Correct the calculation of delta x/y
>> values and choose the closest Crtc.
>
> This comment isn't terribly descriptive of the problems it's
> solving. There are two -- one where the dx/dy values end up of
Adam Jackson writes:
> Signed-off-by: Adam Jackson
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgp4LPhQfY8KL.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
I
Adam Jackson writes:
> Signed-off-by: Adam Jackson
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgpNHBHRbL3KK.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
I
Adam Jackson writes:
> I ported these to pciaccess in:
>
> commit 858fbbb40d7c69540cd1fb5315cebf811c6e7b3f
> Author: Adam Jackson
> Date: Fri Sep 16 13:33:04 2011 -0400
>
> pci: Port xf86MapLegacyIO to pciaccess
>
> As of yet there are still no drivers using them, and there
Adam Jackson writes:
> Given the #if 0 this was wrapping for no effect.
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgp2ZYpTEcPn0.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/a
Adam Jackson writes:
> Signed-off-by: Adam Jackson
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgpURkFIeRuD2.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
I
Adam Jackson writes:
> Never filled in.
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgpr6pbpYmgXL.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://
Adam Jackson writes:
> Cargo-culted from DRI1, not actually used for anything.
This also includes unrelated changes to pseudoramiX; if you split this
into two patches, these are
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgp6aFPoSuXOk.pgp
Description: PGP signature
_
Adam Jackson writes:
> i810, mga, savage, and tdfx do reference these slots, but only to set
> them to NULL, so while this does have API impact it's not actually used.
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgpJxzeNTSBrJ.pgp
Description: PGP signature
Adam Jackson writes:
> No real unifying theme here besides cleanup.
>
> Two patches here do require trivial driver changes. 06/22 removes an
> interface that simply can't work; naturally, two drivers (trident and
> xgixp) do in fact use it. The fix requires no thought beyond
> copypasta of, say
Use dix-config.h when present, otherwise use xorg-server.h
Signed-off-by: Keith Packard
---
include/servermd.h | 4
include/xorg-server.h.in | 3 +++
2 files changed, 7 insertions(+)
diff --git a/include/servermd.h b/include/servermd.h
index 0132d67..b3fe6df 100644
--- a/include/serv
On Mon, Jul 28, 2014 at 2:10 PM, Keith Packard wrote:
> This uses a single large triangle and a scissor to draw the video
> instead of two triangles.
>
> Signed-off-by: Keith Packard
Reviewed-by: Alex Deucher
> ---
> glamor/glamor_xv.c | 13 -
> 1 file changed, 8 insertions(+), 5
Adam Jackson writes:
> Per the spec:
>
> A bit-gravity of Forget indicates that the window contents are
> always discarded after a size change, even if backing-store or
> save-under has been requested. The window is tiled with its
> background (except, if no background is defined,
David Ung writes:
>>> RRPointerToNearestCrtc is suppose to snap to the nearest Crtc,
>>> but the code is buggy. Correct the calculation of delta x/y
>>> values and choose the closest Crtc.
>>
>> This comment isn't terribly descriptive of the problems it's
>> solving. There are two -- one where t
Alex Deucher writes:
> On Mon, Jul 28, 2014 at 2:10 PM, Keith Packard wrote:
>> This uses a single large triangle and a scissor to draw the video
>> instead of two triangles.
>>
>> Signed-off-by: Keith Packard
>
> Reviewed-by: Alex Deucher
Thanks! Merged.
29eaa61..8a60d1c master -> master
thanks, do you need me to re-upload another patch with the modify message? and
will you be doing the actual commit?
I am new to xorg submission.
David
From: Keith Packard [kei...@keithp.com]
Sent: Monday, July 28, 2014 1:07 PM
To: David Ung; xorg-devel@li
Reviewed-by: Jeremy Huddleston Sequoia
On Jul 22, 2014, at 08:46, Adam Jackson wrote:
> Cargo-culted from DRI1, not actually used for anything.
>
> Signed-off-by: Adam Jackson
> ---
> hw/xquartz/xpr/dri.c | 51 ---
> hw/xquartz/xpr/dri.h |
On Mon, 2014-07-28 at 13:04 -0700, Keith Packard wrote:
> Adam Jackson writes:
> > For redirected windows, size changes hit compReallocPixmap, which
> > normally attempts to preserve the previous pixmap in cw->pOldPixmap.
> > For ForgetGravity windows we now destroy the old pixmap before
> > alloc
Keith Packard writes:
> Eric Anholt writes:
>
>> Color key overlay implementations want to reuse this code, and XF86's
>> had bugs.
>
> It might be helpful to describe which bugs were in the xf86 code so that
> these two implementations could be compared.
Just the ones fixed in the next commit.
David Ung writes:
> thanks, do you need me to re-upload another patch with the modify
> message? and will you be doing the actual commit?
Yup, just send along another patch with a Signed-off-by: line and the
new message and I'll merge it in to the X server repository.
--
keith.pack...@intel.co
Adam Jackson writes:
> [censored] borders. True enough. Okay, so we can still take this
> shortcut if either:
>
> a) pixmap is resizing but border width has not changed
> b) pixmap is not resizing but border width has changed
c) pixmap is resizing by twice the change in border width in
Eric Anholt writes:
> Keith Packard writes:
>
>> Eric Anholt writes:
>>
>>> Color key overlay implementations want to reuse this code, and XF86's
>>> had bugs.
>>
>> It might be helpful to describe which bugs were in the xf86 code so that
>> these two implementations could be compared.
>
> Just
RRPointerToNearestCrtc is suppose to snap to the nearest Crtc,
but best_x and best_y is always positive, hence when calling
SetCursorPosition it will make the cursor even further away.
Correct delta x/y to allow negative values and also use
"width/height -1" in the calculation. Also choose the clo
43 matches
Mail list logo