Re: [PATCH xserver 1/5] glamor: Handle GL_OUT_OF_MEMORY when allocating texture images.

2015-11-10 Thread Keith Packard
Eric Anholt writes: > +if (glGetError() == GL_OUT_OF_MEMORY) { It seems like you'll need to call this in a loop in case multiple error bits are set? And, don't you need to call this (repeatedly) before the function which might generate an error in case there was an existing error pending?

Re: [PATCH xserver 05/11 v2] glamor: Hook up EGL DestroyPixmap through the normal wrap chain.

2015-11-10 Thread Michel Dänzer
On 11.11.2015 03:04, Eric Anholt wrote: > One less layering violation (EGL should call glamor, if anything, not > the other way around). > > v2: Move glamor.c's DestroyPixmap wrapping up above the > glamor_egl_screen_init() call, since glamor.c's DestroyPixmap > needs to be the bottom of t

Re: [PATCH] Xorg.wrap: activate libdrm based detection for KMS drivers

2015-11-10 Thread Michel Dänzer
On 11.11.2015 05:39, Arkadiusz Miśkiewicz wrote: > Xorg.wrap includes code guarded with WITH_LIBDRM for detecting KMS drivers. > Unfortunately it is never activated since code missed to include file > which defines WITH_LIBDRM. Fixes bug fdo#92894. The convention for referencing bugzilla entries i

Re: [PATCH xserver 10/11 v2] glamor: Delay making pixmaps shareable until we need to.

2015-11-10 Thread Michel Dänzer
On 11.11.2015 06:41, Eric Anholt wrote: > If a pixmap isn't getting exported as a dmabuf, then we don't need to > make an EGLImage/GBM bo for it. This should reduce normal pixmap > allocation overhead, and also lets the driver choose non-scanout > formats which may be much higher performance. > >

Re: [Spice-devel] [Patchwork] The infrequent patchwork update #1

2015-11-10 Thread Victor Toso
Hi, On Tue, Sep 29, 2015 at 04:33:07PM +0100, Damien Lespiau wrote: > Hi all, > > You may have noticed already, patchwork.freedesktop.org looks different. > > That new version includes: > - Some re-design. Design is very much an iterative process, thoughts > and comments are welcome, > - S

[PATCH xserver 10/11 v2] glamor: Delay making pixmaps shareable until we need to.

2015-11-10 Thread Eric Anholt
If a pixmap isn't getting exported as a dmabuf, then we don't need to make an EGLImage/GBM bo for it. This should reduce normal pixmap allocation overhead, and also lets the driver choose non-scanout formats which may be much higher performance. On Raspberry Pi, where scanout isn't usable as a te

[PATCH] Xorg.wrap: activate libdrm based detection for KMS drivers

2015-11-10 Thread Arkadiusz Miśkiewicz
Xorg.wrap includes code guarded with WITH_LIBDRM for detecting KMS drivers. Unfortunately it is never activated since code missed to include file which defines WITH_LIBDRM. Fixes bug fdo#92894. Signed-off-by: Arkadiusz Miśkiewicz --- hw/xfree86/xorg-wrapper.c | 1 + 1 file changed, 1 insertion(+

[PATCH xserver 05/11 v2] glamor: Hook up EGL DestroyPixmap through the normal wrap chain.

2015-11-10 Thread Eric Anholt
One less layering violation (EGL should call glamor, if anything, not the other way around). v2: Move glamor.c's DestroyPixmap wrapping up above the glamor_egl_screen_init() call, since glamor.c's DestroyPixmap needs to be the bottom of the stack (it calls fb directly and doesn't wrap)

Re: [PATCH] Raise the number of FD on WIN32/CYGWIN as well

2015-11-10 Thread Olivier Fourdan
Hi Jon, - Original Message - > Looks like I applied the patch [1]? > > [1] > http://cgit.freedesktop.org/xorg/proto/x11proto/commit/?id=edc04f87c74abacb57782dc947f81a2810a72537 Oh sorry, I overlooked that commit! Thanks! Olivier ___ xorg-devel

Re: [PATCH] Raise the number of FD on WIN32/CYGWIN as well

2015-11-10 Thread Jon Turney
On 10/11/2015 15:28, Olivier Fourdan wrote: On 26/08/2015 16:24, Olivier Fourdan wrote: The value of FD_SETSIZE for those targets in xserver's configure.ac:403 probably needs to be increased to match (See the comment on xserver commit ed2c2a68) Yeah, well, I changed that already to 512 in comm

Re: [PATCH] Raise the number of FD on WIN32/CYGWIN as well

2015-11-10 Thread Olivier Fourdan
Hi all - Original Message - > On 26/08/2015 16:24, Olivier Fourdan wrote: > >> The value of FD_SETSIZE for those targets in xserver's configure.ac:403 > >> probably needs to be increased to match (See the comment on xserver > >> commit ed2c2a68) > > > > Yeah, well, I changed that already t

Re: [PATCH xserver] XDMCP: Fix format in XDMCP fatal error printing

2015-11-10 Thread Daniel Martin
On 10 November 2015 at 11:19, Egbert Eich wrote: > From: Egbert Eich > > XdmcpFatal() calls FatalError() with '%*.*s' in the format string. > FatalError() uses the async safe versions of printf() which only > support a subset of the POSIX printf formats - they don't contain > the '*' width and pr

[PATCH xserver] XDMCP: Fix format in XDMCP fatal error printing

2015-11-10 Thread Egbert Eich
From: Egbert Eich XdmcpFatal() calls FatalError() with '%*.*s' in the format string. FatalError() uses the async safe versions of printf() which only support a subset of the POSIX printf formats - they don't contain the '*' width and precision specifiers. Bugzilla: https://bugzilla.opensuse.org/