Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Hans de Goede
Hi, On 16-09-16 04:00, Michel Dänzer wrote: On 16/09/16 06:50 AM, Eric Anholt wrote: Hans de Goede writes: When using reverse prime we do 2 copies, 1 from the primary GPU's framebuffer to a shared pixmap and 1 from the shared pixmap to the secondary GPU's framebuffer. This means that on the

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Michel Dänzer
On 16/09/16 04:18 PM, Hans de Goede wrote: > On 16-09-16 04:00, Michel Dänzer wrote: >> On 16/09/16 06:50 AM, Eric Anholt wrote: >>> Hans de Goede writes: >>> When using reverse prime we do 2 copies, 1 from the primary GPU's framebuffer to a shared pixmap and 1 from the shared pixmap to

[PATCH xf86-input-libinput] Fix --with-xorg-conf-dir default value

2016-09-16 Thread Michel Dänzer
From: Michel Dänzer If --prefix isn't specified on the command line, $prefix contains "NONE" at this point, not the default prefix value. So make install would attempt to install the xorg.conf.d snippet to ${DESTDIR}NONE/share/X11/xorg.conf.d/. Avoid this by leaving ${prefix} verbatim in the def

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v3).

2016-09-16 Thread Hans de Goede
Hi, On 15-09-16 20:53, Michael Thayer wrote: Hello, On 15.09.2016 19:18, Hans de Goede wrote: Hi, * drop the special case for loading a cursor sprite when the cursor is hidden: we set HARDWARE_CURSOR_UPDATE_UNHIDDEN, so all calls to load_cursor will be followed by calls to show_cur

Re: [PATCH xserver] damage: Add screen func called before damage event delivery

2016-09-16 Thread Hans de Goede
Hi, On 16-09-16 08:26, Michel Dänzer wrote: On 16/09/16 01:37 PM, Keith Packard wrote: This lets the video driver flush rendering to the kernel before the client receives a damage event to a pixmap which the client has direct rendering access to. I'm afraid I'm not sure this is going in a goo

Re: [PATCH xserver] damage: Add screen func called before damage event delivery

2016-09-16 Thread Michel Dänzer
On 16/09/16 05:37 PM, Hans de Goede wrote: > On 16-09-16 08:26, Michel Dänzer wrote: >> On 16/09/16 01:37 PM, Keith Packard wrote: >>> This lets the video driver flush rendering to the kernel before the >>> client receives a damage event to a pixmap which the client has direct >>> rendering access

Re: [PATCH xserver] damage: Add screen func called before damage event delivery

2016-09-16 Thread Hans de Goede
Hi, On 16-09-16 10:59, Michel Dänzer wrote: On 16/09/16 05:37 PM, Hans de Goede wrote: On 16-09-16 08:26, Michel Dänzer wrote: On 16/09/16 01:37 PM, Keith Packard wrote: This lets the video driver flush rendering to the kernel before the client receives a damage event to a pixmap which the cl

Re: [PATCH xserver] damage: Add screen func called before damage event delivery

2016-09-16 Thread Michel Dänzer
On 16/09/16 06:14 PM, Hans de Goede wrote: > On 16-09-16 10:59, Michel Dänzer wrote: >> On 16/09/16 05:37 PM, Hans de Goede wrote: >>> On 16-09-16 08:26, Michel Dänzer wrote: On 16/09/16 01:37 PM, Keith Packard wrote: > @@ -1943,3 +1948,13 @@ DamageReportDamage(DamagePtr pDamage, > Reg

DUMMYAdjustFrame does nothing useful

2016-09-16 Thread Antoine Martin
Hi, This function does absolutely nothing except dereferencing some pointers. Can we get rid of it? (or just replace it with a no-op) What is it meant to do? Here it is in full: * Mandatory */ void DUMMYAdjustFrame(ADJUST_FRAME_ARGS_DECL) { SCRN_INFO_PTR(arg); int Base; Base = (y * p

30-bpp mode for dummy - exposes a bug somewhere else?

2016-09-16 Thread Antoine Martin
Hi, Adding support for 10 bits per pixel mode to the dummy driver: -- a/src/dummy_driver.c +++ b/src/dummy_driver.c @@ -313,6 +313,7 @@ DUMMYPreInit(ScrnInfoPtr pScrn, int flags) case 15: case 16: case 24: +case 30: break; default: xf

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Hans de Goede
Hi, On 16-09-16 09:58, Michel Dänzer wrote: On 16/09/16 04:18 PM, Hans de Goede wrote: On 16-09-16 04:00, Michel Dänzer wrote: On 16/09/16 06:50 AM, Eric Anholt wrote: Hans de Goede writes: When using reverse prime we do 2 copies, 1 from the primary GPU's framebuffer to a shared pixmap and

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Eric Anholt
Hans de Goede writes: > Hi, > > On 16-09-16 09:58, Michel Dänzer wrote: >> On 16/09/16 04:18 PM, Hans de Goede wrote: >>> On 16-09-16 04:00, Michel Dänzer wrote: On 16/09/16 06:50 AM, Eric Anholt wrote: > Hans de Goede writes: > >> When using reverse prime we do 2 copies, 1 from

[PATCH xserver] modesetting: Fix build without glamor

2016-09-16 Thread Olivier Fourdan
Build would abort if configure without glamor: | present.c: error: implicit declaration of function | ‘ms_flush_drm_events’ [-Werror=implicit-function-declaration] | if (errno != EBUSY || ms_flush_drm_events(screen) < 0) { ms_flush_drm_events() is avaialble only with glamor, so avoid the

Re: [PATCH xserver] modesetting: Fix build without glamor

2016-09-16 Thread Hans de Goede
Hi, On 16-09-16 17:20, Olivier Fourdan wrote: Build would abort if configure without glamor: | present.c: error: implicit declaration of function | ‘ms_flush_drm_events’ [-Werror=implicit-function-declaration] | if (errno != EBUSY || ms_flush_drm_events(screen) < 0) { ms_flush_drm_eve

Re: [PULL] Windows-DRI extension

2016-09-16 Thread Emil Velikov
On 15 September 2016 at 20:12, Jon Turney wrote: > On 15/09/2016 14:14, Emil Velikov wrote: >> >> On 15 September 2016 at 13:06, Jon Turney wrote: >>> >>> Please consider pulling into master. >>> >>> The following changes since commit >>> 52d6a1e832a5e62289dd4f32824ae16a78dfd7e8: >>> >>> Hold in

Re: [PATCH xserver] modesetting: Fix build without glamor

2016-09-16 Thread Olivier Fourdan
> There already was a fix for this posted a while ago, > but that still needs to be merged. Ah yeah, a couple of times even :) Cheers, Olivier ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://l

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Keith Packard
Michel Dänzer writes: > I'm afraid not, because your patch only affects damage records for clients. Right, but it exposes a screen func for doing drawable-specific flushing. I thought that might be useful. -- -keith signature.asc Description: PGP signature ___

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Keith Packard
Hans de Goede writes: > So it looks like we really need glFinish to ensure proper ordering here > (and I've just deleted the v2 of this patchset with flush with I had > prepared). If you need glFinish, then your drivers are broken. glFlush and suitable fences provides sufficient information to a

modesetting: allow switching from software to hardware cursors (v4)

2016-09-16 Thread Michael Thayer
Split this up into the three following patches as suggested by Hans. Many thanks for your patience! Regards, Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-809

[PATCH xserver] modesetting: only fall back to drmModeSetCursor() on -EINVAL

2016-09-16 Thread Michael Thayer
This change effectively reverts commit 074cf58. We were falling back from drmModeSetCursor2() to drmModeSetCursor() whenever the first failed. This fall-back only makes sense on pre-mid-2013 kernels which implemented the cursor_set hook but not cursor_set2, and in this case the call to drmModeSet

[PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

2016-09-16 Thread Michael Thayer
When the X server asks us to load a hardware cursor, that request is always followed up by a request to show it if we report success, or to hide it if we report failure. Therefore it makes no sense to suppress the request if the cursor is not currently visible. Signed-off-by: Michael Thayer ---

Re: [PATCH xserver] modesetting: fix compile error when --disable-glamor

2016-09-16 Thread Keith Packard
Michel Dänzer writes: > But either way, with the bugzilla tag fixed, > > Reviewed-by: Michel Dänzer Merged with commit message updated as suggested. d81f9ce..7f6fa4e master -> master -- -keith signature.asc Description: PGP signature ___ xorg-

Re: [PATCH xserver] damage: Add screen func called before damage event delivery

2016-09-16 Thread Keith Packard
Michel Dänzer writes: > I'm afraid I'm not sure this is going in a good direction. Yeah, with the WriteToClient changes from a few months ago, I think we need to do something though. We used to be able to rely on no events being delivered before the BlockHandler was invoked. That's no longer tru

[PATCH xserver] modesetting: allow switching from software to hardware cursors (v4).

2016-09-16 Thread Michael Thayer
Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to only permanently switch to a software cursor if -ENXIO is returned (which means hardware cursors not supported), and to otherwise still try a hardware cursor fir

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Eric Anholt
Keith Packard writes: > Hans de Goede writes: > >> So it looks like we really need glFinish to ensure proper ordering here >> (and I've just deleted the v2 of this patchset with flush with I had >> prepared). > > If you need glFinish, then your drivers are broken. glFlush and suitable > fences p

Re: [PULL] Windows-DRI extension

2016-09-16 Thread Eric Anholt
Emil Velikov writes: > On 15 September 2016 at 20:12, Jon Turney wrote: >> On 15/09/2016 14:14, Emil Velikov wrote: >>> >>> On 15 September 2016 at 13:06, Jon Turney wrote: Please consider pulling into master. The following changes since commit 52d6a1e832a5e62289dd4f3282

Re: [PATCH xserver] Add SyncSharedPixmap ScreenRec hook

2016-09-16 Thread Keith Packard
>> Signed-off-by: Michel Dänzer > > Reviewed-by: Alex Deucher Merged. 7f6fa4e..bd8ecd9 master -> master -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH xserver] xfree86/modes: Set RandR primary output from CreateScreenResources

2016-09-16 Thread Keith Packard
>> Signed-off-by: Michel Dänzer > > Reviewed-by: Alex Deucher Merged. bd8ecd9..5b9f3ea master -> master -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: Proposed X server 1.19 schedule

2016-09-16 Thread Keith Packard
Hans de Goede writes: Looks like all of these have been merged, thanks for tracking what remained to be done! > https://patchwork.freedesktop.org/patch/106849/ > https://patchwork.freedesktop.org/patch/106850/ > > https://patchwork.freedesktop.org/patch/105350/ > https://patchwork.freedesktop.or

[PATCH xf86-input-libinput] Initializing strip association with wrong index

2016-09-16 Thread Keith Packard
This looks like a cut&paste coding error to me, and it generated a compiler warning about possibly uninitialized value. Signed-off-by: Keith Packard --- src/xf86libinput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index 888ba21..2

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v4).

2016-09-16 Thread Michael Thayer
On 16.09.2016 17:52, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to only permanently switch to a software cursor if -ENXIO is returned (which means hardware cursors not supported), and

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-16 Thread Keith Packard
Eric Anholt writes: > glFlush by the spec does (not) provide any guarantees that things have > made it to the kernel. We have just assumed that, but I think the > Radeon driver may be violating that assumption these days. I'd say the radeon driver needs fixing then; we really don't have any oth

Re: [PATCH 1/1] glx: Initialize glx even if there are currently no screens attached

2016-09-16 Thread Jeremy Huddleston Sequoia
Ping. > On Sep 11, 2016, at 03:44, Jeremy Huddleston Sequoia > wrote: > > Failure to do so causes an overvlow in glxClientCallback > > Application Specific Information: > X.Org X Server 1.18.99.1 Build Date: 20160911 > = > ==52118

Re: [PATCH 1/1] randr: Initialize RandR even if there are currently no screens attached

2016-09-16 Thread Jeremy Huddleston Sequoia
Ping. > On Sep 11, 2016, at 02:23, Jeremy Huddleston Sequoia > wrote: > > Failure to do so causes an overvlow in RRClientCallback(). > > = > ==41262==ERROR: AddressSanitizer: global-buffer-overflow on address > 0x000103ccfbc8 at

Re: [ANNOUNCE] xorg-server 1.18.99.2

2016-09-16 Thread Jeremy Huddleston Sequoia
> On Sep 16, 2016, at 13:57, Keith Packard wrote: > > > I think we're ready for RC1 at this point, but wanted to give people a > chance to scream about "just one more API change" until tomorrow. Let me > know if there's something I'm missing; if I don't hear anything, I'll be > tagging RC1 in t

Re: weird Xwayland and compositor deadlock issue [WAS: [PATCH xserver v2] xwayland: handle EAGAIN and EINTR gracefully]

2016-09-16 Thread Jasper St. Pierre
Hi, Based on my reading of the spec, writing an ICCCM-compliant WM *requires* blocking, since the behavior of an UnmapNotify depends on the attributes of a window. We cannot process any X11 events while we are retrieving the attributes of a mapped window inside MapRequest. If we want to modify th

Re: XLoadQueryFont() not returning with recent xserver master

2016-09-16 Thread Jeremy Huddleston Sequoia
I bisected the issue to: f993091e7db81b0420e23c485378cba112278839 is the first bad commit commit f993091e7db81b0420e23c485378cba112278839 Author: Keith Packard Date: Thu May 26 10:40:44 2016 -0700 os: Switch server to poll(2) [v3] Eliminates all of the fd_set mangling in the serve