Re: [PATCH] xwayland: Clear pending cursor frame callbacks on pointer enter

2016-02-03 Thread Bryce Harrington
ight not have been shown. In that case we'll > + * have a cursor surface frame callback pending which we need to > + * clear so that we can continue submitting new cursor frames. */ > +if (xwl_seat->cursor_frame_cb) { > + wl_callback_destroy(xwl_seat->cursor

[PATCH 1/2] release.sh: Clarify where the tarball was seen

2016-01-20 Thread Bryce Harrington
From: Bryce Harrington Signed-off-by: Bryce Harrington --- release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release.sh b/release.sh index ef384de..0a1c607 100755 --- a/release.sh +++ b/release.sh @@ -595,7 +595,7 @@ process_module() { if [ "x$

[PATCH 2/2] release.sh: Don't quit on dry runs if tarball already uploaded

2016-01-20 Thread Bryce Harrington
From: Bryce Harrington When doing practice runs of the script, we aren't going to be uploading anything, so don't treat it as a fatal error if the tarball is already uploaded, as this may hide potential subsequent issues that the user should know about. Signed-off-by: Bryce

Re: State of Wayland

2015-09-17 Thread Bryce Harrington
On Thu, Sep 17, 2015 at 03:15:29PM -0400, Olivier Fourdan wrote: > > Hi Bryce, > > - Original Message - > > That'd be great, thanks Olivier! > > > > I'm not sure if the wayland patchwork is representative of Xwayland > > patches, as we tend to prune PW to show only items bound for weston

Re: State of Wayland

2015-09-17 Thread Bryce Harrington
On Thu, Sep 17, 2015 at 10:27:13AM -0400, Olivier Fourdan wrote: > Hi Bryce, > > cc'ing xorg-devel as well, see below, I would like to help with xwayland. > > - Original Message - > > I've assembled a blog post with a run-down of our current status on > > Wayland - bugs needing attention,

Re: [PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

2015-07-15 Thread Bryce Harrington
On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote: > Hello gents, > > On 15 July 2015 at 09:51, Marek Chalupa wrote: > > Reviewed-by: Marek Chalupa > > > > (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html) > > > > On 05/16/2015 07:38 AM, Dima Ryazanov wrote: >

Re: [PATCH 0/6] xfree86: Handle drm race condition

2013-04-10 Thread Bryce Harrington
On Tue, Apr 09, 2013 at 07:15:58PM -0700, Keith Packard wrote: > Bryce Harrington writes: > > > So, feel free to revert the patches if the thinking is it's just adding > > clutter, but you may still want the first patch in the series as it adds > > a missing close(

Re: [PATCH] xfree86: Revert workaround for drm race condition.

2013-04-10 Thread Bryce Harrington
On Wed, Apr 10, 2013 at 11:05:40PM -0700, Bryce Harrington wrote: > Revert 70739e817b2d64bc020ea491f23a3574bdb6155e and mostly revert > c31eac647a9ecf0fb20dc98266cadf0ba923ba14. > > Further investigation shows the encountered race condition is between > lightdm and plymouth-splash,

[PATCH] xfree86: Revert workaround for drm race condition.

2013-04-10 Thread Bryce Harrington
s job coordination logic, and can (and should) be fixed within those limiations. Not in xserver itself. This leaves some of the diagnostic improvements from the recent patch series, in case others run into a similar situation. Signed-off-by: Bryce Harrington --- hw/xfree86/os-support/linux/lnx_platf

Re: [PATCH 0/6] xfree86: Handle drm race condition

2013-04-09 Thread Bryce Harrington
On Mon, Apr 08, 2013 at 03:50:16PM -0700, Keith Packard wrote: > Dave Airlie writes: > > > Don't think I did, from what I can see these are just local Ubuntu > > races at startup between plymouth, lightdm and X, > > Maybe I was misreading stuff, but I saw a separate kernel thread about > the X s

Re: [PATCH 0/6] xfree86: Handle drm race condition

2013-04-08 Thread Bryce Harrington
On Mon, Apr 08, 2013 at 09:16:02AM -0700, Keith Packard wrote: > Bryce Harrington writes: > > > We have not root-caused the bug yet, but are able to reproduce it > > synthetically. Currently we suspect the actual breakage is underneath X > > (plymouth/lightdm/ker

[PATCH 6/6] xfree86: Be verbose if waiting on opening the drm device

2013-03-19 Thread Bryce Harrington
Signed-off-by: Bryce Harrington Reviewed-by: Chris Wilson --- hw/xfree86/os-support/linux/lnx_platform.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/linux/lnx_platform.c b/hw/xfree86/os-support/linux/lnx_platform.c index 977d590..444f8f5

[PATCH 5/6] xfree86: Fix race condition failure opening drm.

2013-03-19 Thread Bryce Harrington
libdrm. To address this we need to re-set ourselves as the drm master, and keep trying to set the interface until it works (or until we give up). See https://bugs.launchpad.net/ubuntu/+source/libdrm/+bug/982889 Signed-off-by: Bryce Harrington Reviewed-by: Chris Wilson --- hw/xfree86/os-sup

[PATCH 4/6] xfree86: Keep trying to set interface on drm for 2 seconds.

2013-03-19 Thread Bryce Harrington
And if we've had to delay booting due to not being able to set the interface, fess up. Signed-off-by: Bryce Harrington Reviewed-by: Chris Wilson --- hw/xfree86/os-support/linux/lnx_platform.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/xf

[PATCH 3/6] xfree86: Provide more details on failure

2013-03-19 Thread Bryce Harrington
Signed-off-by: Bryce Harrington Reviewed-by: Chris Wilson --- hw/xfree86/os-support/linux/lnx_platform.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/linux/lnx_platform.c b/hw/xfree86/os-support/linux/lnx_platform.c index 6ee219a..3ae2db1

[PATCH 2/6] xfree86: Track error code and add label for error handling.

2013-03-19 Thread Bryce Harrington
Signed-off-by: Bryce Harrington Reviewed-by: Chris Wilson --- hw/xfree86/os-support/linux/lnx_platform.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/os-support/linux/lnx_platform.c b/hw/xfree86/os-support/linux/lnx_platform.c index 69a5b8c

[PATCH 1/6] xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set.

2013-03-19 Thread Bryce Harrington
Signed-off-by: Bryce Harrington Reviewed-by: Chris Wilson --- hw/xfree86/os-support/linux/lnx_platform.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/xfree86/os-support/linux/lnx_platform.c b/hw/xfree86/os-support/linux/lnx_platform.c index 76f5583..69a5b8c 100644 --- a/hw/xfree86

[PATCH 0/6] xfree86: Handle drm race condition

2013-03-19 Thread Bryce Harrington
/ubuntu/+source/libdrm/+bug/982889 Bryce Harrington (6): xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set. xfree86: Track error code and add label for error handling. xfree86: Provide more details on failure xfree86: Keep trying to set interface on drm for 2 seconds

Other unresolved patches Ubuntu is following

2013-02-08 Thread Bryce Harrington
ts suggest doing a more extensive code refactoring, but given it's been a few months maybe that's more than the patch author is prepared to do for now. Bryce On Fri, Feb 08, 2013 at 03:56:00PM -0800, Bryce Harrington wrote: > Here are a few patches we've been carrying in Ubuntu fo

[PATCH 3/3] Xext: "xauth generate" with large timeout crashes Xorg #27134

2013-02-08 Thread Bryce Harrington
, and the patch was not picked up. We have carried the patch in Ubuntu since Jun 2010 as it was confirmed to fix the reported issue. ref: http://lists.x.org/archives/xorg-devel/2010-April/006992.html Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27134 Signed-off-by: Bryce Harrington --- Xext

[PATCH 2/3] xfree86: Man page shouldn't say Device is mandatory anymore

2013-02-08 Thread Bryce Harrington
man xorg.conf states that the 'Device' identifier is required in the 'Screen' section, yet current xserver defaults properly and boots up fine without it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=20742 Signed-off-by: Bryce Harrington --- hw/xfree86/man/

[PATCH 1/3] xfree86: Use fbdev/vesa driver on Oaktrail, Medfield, CDV rather than -intel

2013-02-08 Thread Bryce Harrington
cember. ref: https://bugzilla.novell.com/show_bug.cgi?id=772279 ref: https://bugs.launchpad.net/ubuntu/+bug/1069031 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=60514 Signed-off-by: Bryce Harrington --- hw/xfree86/common/xf86pciBus.c | 64 +++- 1 file changed, 56 insert

[PATCH 0/3] Three fixes carried in Ubuntu

2013-02-08 Thread Bryce Harrington
matted them and verified they apply to current git. Bryce Harrington (3): xfree86: Use fbdev/vesa driver on Oaktrail, Medfield, CDV rather than -intel xfree86: Man page shouldn't say Device is mandatory anymore Xext: "xauth generate" with large timeout crashes

[PATCH 3/3] Xext: "xauth generate" with large timeout crashes Xorg #27134

2013-02-08 Thread Bryce Harrington
, and the patch was not picked up. We have carried the patch in Ubuntu since Jun 2010 as it was confirmed to fix the reported issue. ref: http://lists.x.org/archives/xorg-devel/2010-April/006992.html Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27134 Signed-off-by: Bryce Harrington --- Xext

[PATCH 2/3] xfree86: Man page shouldn't say Device is mandatory anymore

2013-02-08 Thread Bryce Harrington
man xorg.conf states that the 'Device' identifier is required in the 'Screen' section, yet current xserver defaults properly and boots up fine without it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=20742 Signed-off-by: Bryce Harrington --- hw/xfree86/man/

[PATCH 1/3] xfree86: Use fbdev/vesa driver on Oaktrail, Medfield, CDV rather than -intel

2013-02-08 Thread Bryce Harrington
cember. ref: https://bugzilla.novell.com/show_bug.cgi?id=772279 ref: https://bugs.launchpad.net/ubuntu/+bug/1069031 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=60514 Signed-off-by: Bryce Harrington --- hw/xfree86/common/xf86pciBus.c | 64 +++- 1 file changed, 56 insert

[PATCH 0/3] Three fixes carried in Ubuntu

2013-02-08 Thread Bryce Harrington
matted them and verified they apply to current git. Bryce Harrington (3): xfree86: Use fbdev/vesa driver on Oaktrail, Medfield, CDV rather than -intel xfree86: Man page shouldn't say Device is mandatory anymore Xext: "xauth generate" with large timeout crashes

Re: [PATCH] dix: Save touchpoint last coordinates before transform. #49347

2012-11-21 Thread Bryce Harrington
https://bugs.launchpad.net/ubuntu-nexus7/+bug/1076627 Tested-by: Bryce Harrington > --- > dix/devices.c |2 -- > dix/getevents.c| 19 ++- > dix/touch.c|1 - > include/inputstr.h |3 +-- > 4 files changed, 7 insertions(+), 18 delet

Re: [PATCH] TouchListenerAcceptReject: Warn and return early on bad listener index

2012-04-20 Thread Bryce Harrington
Reviewed-by: Bryce Harrington On Fri, Apr 20, 2012 at 11:08:15AM -0700, Chase Douglas wrote: > Signed-off-by: Chase Douglas > --- > dix/touch.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dix/touch.c b/dix/touch.c > index dd16367..4

Re: [PATCH 00/10] Miscellaneous input fixes

2012-04-19 Thread Bryce Harrington
e: > > http://cgit.freedesktop.org/~cndougla/xserver/log/?h=input-fixes Aside from my couple comments earlier, which are perhaps unlikely corner cases, for the 17 patches 4c1dfd21...00cf1c40: Reviewed-by: Bryce Harrington ___ xorg-devel@

Re: [PATCH 04/10] When activating an explicit grab, update owning listener

2012-04-19 Thread Bryce Harrington
On Tue, Apr 17, 2012 at 04:33:23PM -0700, Chase Douglas wrote: > Pointer passive grabs may be changed by the grabbing client. This allows > for a selecting client to change an implicit grab to an active grab, > which is the mechanism used for pop-up windows like application menus. > > We need to d

Re: [PATCH 1/5] Split out helper function TouchListenerAcceptReject()

2012-04-19 Thread Bryce Harrington
On Wed, Apr 11, 2012 at 11:22:10AM -0700, Chase Douglas wrote: > This will be used for accepting and rejecting touches in the future. > > Signed-off-by: Chase Douglas > --- > dix/events.c| 11 +--- > dix/touch.c | 68 ++ > inclu

Re: [PATCH 0/6] Fix signal-unsafe logging

2012-04-06 Thread Bryce Harrington
On Fri, Apr 06, 2012 at 01:20:22PM -0700, Bryce Harrington wrote: > On Fri, Apr 06, 2012 at 12:00:50PM -0700, Chase Douglas wrote: > > On 04/06/2012 11:25 AM, Chase Douglas wrote: > > This is all preliminary, based on a few minutes of testing. I'll follow > > up after

Re: [PATCH 0/6] Fix signal-unsafe logging

2012-04-06 Thread Bryce Harrington
On Fri, Apr 06, 2012 at 12:00:50PM -0700, Chase Douglas wrote: > On 04/06/2012 11:25 AM, Chase Douglas wrote: > This is all preliminary, based on a few minutes of testing. I'll follow > up after more people have tested it out. After bypassing the test error, I've built xserver debs, installed, and

Re: [PATCH 0/6] Fix signal-unsafe logging

2012-04-06 Thread Bryce Harrington
On Fri, Apr 06, 2012 at 12:00:50PM -0700, Chase Douglas wrote: > On 04/06/2012 11:25 AM, Chase Douglas wrote: > > Because corruption can occur, I suggest this be applied to the 1.12 > > stable series as well. However, I don't know for sure that corruption is > > occurring, so it's not a clear cut c

Re: [PATCH 0/6] Fix signal-unsafe logging

2012-04-06 Thread Bryce Harrington
Finally, two known signal context logging paths have been fixed to use > LogMessageVerbSigSafe(). > > Because corruption can occur, I suggest this be applied to the 1.12 > stable series as well. However, I don't know for sure that corruption is > oc

Re: Stable branch reformatting issues

2012-03-23 Thread Bryce Harrington
On Mon, Mar 19, 2012 at 06:58:59PM -0700, Chase Douglas wrote: > I think that's a bit overkill. If we are going to reformat the 1.11 and > earlier branches, then we might as well leave it at that and let the > downstreams worry about it. Or, actually have someone maintain a > pre-formatted branch.

Re: [PATCH 1/5] Xext: drop InitServertime() declaration.

2012-03-16 Thread Bryce Harrington
Series (1-3, 4v2, 5): Reviewed-by: Bryce Harrington On Tue, Mar 13, 2012 at 12:01:39AM -0700, Jeremy Huddleston wrote: > Series (1-3, 4v2, 5): > Reviewed-by: Jeremy Huddleston > > On Mar 12, 2012, at 4:20 PM, Peter Hutterer wrote: > > > Not implemented anywhere. > >

[PATCH xrandr-utils 4/4] Refactor name_t into XRUName

2012-02-15 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- examples/xrandr.c| 202 -- include/X11/extensions/XrandrUtils.h | 38 +++ man/XrandrUtils.man | 15 +++ src/Makefile.am |3 +- src/names.c

[PATCH xrandr-utils 0/4] rotations, reflections, names

2012-02-15 Thread Bryce Harrington
Refactors three more chunks of xrandr into libXrandrUtils, and associated tests. Since there were no further comments to the last set of patches, they've been posted to git.freedesktop.org. Bryce Harrington (4): Refactor rotations into library Refactor reflection support into library.

[PATCH xrandr-utils 1/4] Refactor rotations into library

2012-02-15 Thread Bryce Harrington
This is perhaps the simplest way to refactor out the code, but I'm not happy with it. It adds three api calls when it seems like 2 ought to be sufficient. Also, one routine returns 0 on error, the other -1, and that's no good. Signed-off-by: Bryce Harrington --- M

[PATCH xrandr-utils 3/4] Add an A/B test comparing our xrandr's output with the installed xrandr

2012-02-15 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- examples/before_and_after.sh | 23 +++ examples/xrandr.c|5 - 2 files changed, 27 insertions(+), 1 deletions(-) create mode 100755 examples/before_and_after.sh diff --git a/examples/before_and_after.sh b/examples

[PATCH xrandr-utils 2/4] Refactor reflection support into library.

2012-02-15 Thread Bryce Harrington
This follows the same API style as rotation. Signed-off-by: Bryce Harrington --- examples/xrandr.c| 36 ++ include/X11/extensions/XrandrUtils.h |9 +++ man/XrandrUtils.man | 18 + src/XrandrUtils.c| 56

Re: [PATCH xf86-input-synaptics 00/12] Clickpad support

2012-02-11 Thread Bryce Harrington
On Sat, Feb 11, 2012 at 04:32:10PM +, Daniel Stone wrote: > > What Bryce was saying is when you go from one touch on the touchpad to > > two, but before the button is pressed, the cursor freezes. As soon as > > the button is pressed, the cursor unfreezes so you can click and drag > > with two f

Re: [PATCH xf86-input-synaptics 00/12] Clickpad support

2012-02-10 Thread Bryce Harrington
On Fri, Feb 10, 2012 at 05:11:10AM +0100, Chase Douglas wrote: > On 02/10/2012 03:52 AM, Chase Douglas wrote: > > This patch series adds proper clickpad support. Clickpads are trackpads that > > have buttons integrated into their touch surface. In order to press the > > buttons > > one has to be i

[PATCH intel-gpu-tools 1/1] drmtest: exit() rather than abort() for simple usage errors.

2012-01-24 Thread Bryce Harrington
ut it. As the code is displaying a unique error message prior to termination, it should be discoverable enough where in the code the failure occurs, so an exit(1) should be sufficient for termination. Signed-off-by: Bryce Harrington --- lib/drmtest.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [PATCH v2 xrandr-utils 0/7] Refactor xrandr internals into libxrandr-utils

2012-01-06 Thread Bryce Harrington
On Fri, Jan 06, 2012 at 04:36:28PM -0800, Bryce Harrington wrote: > > This tree is also available in my personal git repository on fdo. > ssh://people.freedesktop.org/~bryce/libXrandrUtils > > Bryce Harrington (7): > Initial doc files. > Initial packaging an

[PATCH xrandr-utils 7/8] Drop rectangle_t.

2012-01-06 Thread Bryce Harrington
There are no internal users. box_t (now XRUBox) serves essentially the same purpose. Signed-off-by: Bryce Harrington --- examples/xrandr.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/examples/xrandr.c b/examples/xrandr.c index 6d921fb..a69eea3 100644 --- a

[PATCH xrandr-utils 5/8] Add unit test suite and a basic test of the geometry structs.

2012-01-06 Thread Bryce Harrington
This follows the style of the X server test suite, using autoconf's built-in support for make check using asserts. The first test trivially checks the geometry structures. Signed-off-by: Bryce Harrington --- COPYING |1 + Makefile.am |2 +- configure.ac |1 +

[PATCH xrandr-utils 2/8] Initial packaging and directory structure.

2012-01-06 Thread Bryce Harrington
This is copied directly from libXrandr with some tweaking based on xrandr configs. Signed-off-by: Bryce Harrington --- .gitignore | 78 ++ Makefile.am | 37 autogen.sh

[PATCH xrandr-utils 6/8] Refactor geometry structs in xrandr.c to use libXrandrUtil's

2012-01-06 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- examples/.gitignore |1 + examples/xrandr.c | 33 + 2 files changed, 10 insertions(+), 24 deletions(-) create mode 100644 examples/.gitignore diff --git a/examples/.gitignore b/examples/.gitignore new file mode 100644

[PATCH xrandr-utils 4/8] Copy a few basic structs and enums from xrandr.c into header.

2012-01-06 Thread Bryce Harrington
Adopt header style and struct naming scheme from libXrandr's Xrandr.h. In particular, rename enums from foobar_t to XRUFoobar. Signed-off-by: Bryce Harrington --- include/X11/extensions/XrandrUtils.h | 47 ++ man/XrandrUtils.man |

[PATCH xrandr-utils 1/8] Initial doc files.

2012-01-06 Thread Bryce Harrington
COPYING is taken from xrandr since this package will largely be repackaging code from that tool. README is adapted from libXrandr. Keith Packard is the owner of the xrandr code and thus is primary author of this codebase. Signed-off-by: Bryce Harrington --- AUTHORS |1 + COPYING | 21

[PATCH v2 xrandr-utils 0/7] Refactor xrandr internals into libxrandr-utils

2012-01-06 Thread Bryce Harrington
configuration logic, rather than duplicated across Qt, gtk, and other client-side tools. This first set of changes just sets up the directory structure and migrates a couple structures as proof of concept. Posting it at this early stage for feedback it's going in the correct direction. B

Re: [PATCH xrandr-utils 0/6] Refactor xrandr internals into libxrandr-utils

2011-12-22 Thread Bryce Harrington
On Wed, Dec 21, 2011 at 07:58:09PM -0800, Jamey Sharp wrote: > On Wed, Dec 21, 2011 at 06:47:07PM -0800, Bryce Harrington wrote: > > Begin refactoring the xrandr command line tool's internals into a > > utility library. This is to provide a higher level abstraction for >

Re: [PATCH xrandr-utils 4/6] Add unit test suite and a basic test of the geometry structs.

2011-12-22 Thread Bryce Harrington
On Thu, Dec 22, 2011 at 07:47:38PM -0500, Gaetan Nadon wrote: > On 11-12-21 09:47 PM, Bryce Harrington wrote: > >+static void geometry_rectangle(void) > >+{ > >+XRURectangle r; > > The 'make check' target fails which causes 'make distch

Re: [PATCH xrandr-utils 2/6] Import xrandr.c and its test as implementation examples.

2011-12-22 Thread Bryce Harrington
On Thu, Dec 22, 2011 at 07:36:06PM -0500, Gaetan Nadon wrote: > On 11-12-22 10:11 AM, Gaetan Nadon wrote: > >>diff --git a/examples/Makefile.am b/examples/Makefile.am > >>new file mode 100644 > >>index 000..86e9943 > >>--- /dev/null > >>+++ b/examples/Makefile.am > >>@@ -0,0 +1,13 @@ > >>+bin_P

[PATCH xrandr-utils 6/6] Drop rectangle_t.

2011-12-21 Thread Bryce Harrington
There are no internal users. box_t (now XRUBox) serves essentially the same purpose. Signed-off-by: Bryce Harrington --- examples/xrandr.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/examples/xrandr.c b/examples/xrandr.c index 6d921fb..a69eea3 100644 --- a

[PATCH xrandr-utils 5/6] Refactor geometry structs in xrandr.c to use libXrandrUtil's

2011-12-21 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- examples/.gitignore |1 + examples/xrandr.c | 33 + 2 files changed, 10 insertions(+), 24 deletions(-) create mode 100644 examples/.gitignore diff --git a/examples/.gitignore b/examples/.gitignore new file mode 100644

[PATCH xrandr-utils 3/6] Copy a few basic structs and enums from xrandr.c into header.

2011-12-21 Thread Bryce Harrington
Adopt header style and struct naming scheme from libXrandr's Xrandr.h. In particular, rename enums from foobar_t to XRUFoobar. Signed-off-by: Bryce Harrington --- include/X11/extensions/XrandrUtils.h | 47 ++ man/XrandrUtils.man |

[PATCH xrandr-utils 0/6] Refactor xrandr internals into libxrandr-utils

2011-12-21 Thread Bryce Harrington
n the correct direction. Bryce Harrington (6): Initial packaging and directory structure. Import xrandr.c and its test as implementation examples. Copy a few basic structs and enums from xrandr.c into header. Add unit test suite and a basic test of the geometry structs. Refactor geometry structs i

[PATCH xrandr-utils 4/6] Add unit test suite and a basic test of the geometry structs.

2011-12-21 Thread Bryce Harrington
This follows the style of the X server test suite, using autoconf's built-in support for make check using asserts. The first test trivially checks the geometry structures. Signed-off-by: Bryce Harrington --- configure.ac |1 + test/.gitignore |2 + test/Makefile.am |

[PATCH xrandr-utils 1/6] Initial packaging and directory structure.

2011-12-21 Thread Bryce Harrington
This is copied directly from libXrandr with some tweaking based on xrandr configs. Signed-off-by: Bryce Harrington --- .gitignore | 78 ++ Makefile.am | 37 autogen.sh

[PATCH] test: Fix typo and drop documentation references to glib.

2011-11-30 Thread Bryce Harrington
The X server doesn't use glib for the tests any more. Signed-off-by: Bryce Harrington --- test/README | 17 +++-- 1 files changed, 3 insertions(+), 14 deletions(-) diff --git a/test/README b/test/README index 5759a72..618130c 100644 --- a/test/README +++ b/test/README @@

Re: [PATCH] test: Fix a couple of typos in documentation.

2011-11-30 Thread Bryce Harrington
On Tue, Nov 29, 2011 at 11:57:30PM -0800, Jeremy Huddleston wrote: > For the first hunk, > Reviewed-by: Jeremy Huddleston > > For the second hunk, we don't use glib for the tests any more. I'd just > delete the sentence about g_test_bug. See: > > commit 196d679bed2e9959d2fca89d4ee4bbc551681d0

Re: [PATCH xinput 1/1] Print usage when run with --help

2011-11-30 Thread Bryce Harrington
XOpenDisplay(NULL); > > if (display == NULL) { > -- > 1.7.7 Reviewed-by: Bryce Harrington ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xinput: Assume 'list' by default if no args given.

2011-11-30 Thread Bryce Harrington
On Tue, Nov 29, 2011 at 11:49:01PM -0800, Jeremy Huddleston wrote: > Does anything trigger usage() now? Can you send a followup (or squash in) > support for 'xinput --help' for further consistency? Yes, both -h and --help are already supported. Also, it prints usage on any unrecognized command.

[PATCH] test: Fix a couple of typos in documentation.

2011-11-29 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- test/README |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/test/README b/test/README index 5759a72..59b1f47 100644 --- a/test/README +++ b/test/README @@ -15,8 +15,9 @@ of the X server. Unless the test suite replicates the

[PATCH] xinput: Assume 'list' by default if no args given.

2011-11-29 Thread Bryce Harrington
xrandr lists all outputs by default when run with no args. So, make xinput list all inputs by default when run the same way, so the tools are consistent. Signed-off-by: Bryce Harrington Reviewed-by: Chase Douglas --- src/xinput.c | 11 +-- 1 files changed, 5 insertions(+), 6

Re: [PATCH] xinput: Assume 'list' by default if no args given.

2011-11-29 Thread Bryce Harrington
On Tue, Nov 29, 2011 at 05:11:16PM -0800, Chase Douglas wrote: > On 11/29/2011 04:57 PM, Bryce Harrington wrote: > > xrandr lists all outputs by default when run with no args. So, make > > xinput list all inputs by default when run the same way, so the tools > > are consis

[PATCH] xinput: Assume 'list' by default if no args given.

2011-11-29 Thread Bryce Harrington
xrandr lists all outputs by default when run with no args. So, make xinput list all inputs by default when run the same way, so the tools are consistent. Signed-off-by: Bryce Harrington --- src/xinput.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src

[PATCH] Fix minor typo in xsetpointer usage statement.

2011-11-29 Thread Bryce Harrington
Remove extraneous right parens in usage docs. Signed-off-by: Bryce Harrington --- xsetpointer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xsetpointer.c b/xsetpointer.c index 8ffbaa5..566b9f4 100644 --- a/xsetpointer.c +++ b/xsetpointer.c @@ -75,7 +75,7 @@ main

Re: Xserver driver merging pros & cons

2011-09-16 Thread Bryce Harrington
On Thu, Sep 15, 2011 at 01:30:02PM -0700, Chase Douglas wrote: > Note that I'm speaking here with my personal developer hat on. Bryce > Harrington and Chris Halse Rogers would be better to chime in on > Canonical support for Ubuntu, but I imagine that it really doesn't >

[PATCH] Check for OOM condition in XISendDeviceHierarchyEvent

2011-02-16 Thread Bryce Harrington
When system is out of memory, calloc can fail returning a NULL pointer. Check for this before dereferencing it, and bail out if it fails. Ref.: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/720445 Signed-off-by: Bryce Harrington --- Xi/xichangehierarchy.c |2 ++ 1 files

Re: [PATCH] Check for NULL pointer from pixman_image_create_bits()

2011-02-07 Thread Bryce Harrington
On Mon, Feb 07, 2011 at 11:15:24AM +0100, Soeren Sandmann wrote: > Bryce Harrington writes: > > > pixman_image_create_bits() can return NULL under a variety of > > circumstances. If this happens, it will segfault when dereferenced in > > pixman_image_set_ac

[PATCH] Check for NULL pointer from pixman_image_create_bits()

2011-02-03 Thread Bryce Harrington
/ubuntu/+source/xorg-server/+bug/705078 Signed-off-by: Bryce Harrington --- fb/fbpict.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fb/fbpict.c b/fb/fbpict.c index 7636040..79b462b 100644 --- a/fb/fbpict.c +++ b/fb/fbpict.c @@ -163,7 +163,8 @@ create_bits_picture

[PATCH -cirrus] Add a check for max_pitch values for GD5446 / FAUmachine

2011-01-14 Thread Bryce Harrington
is pretty rare hardware but is simulated by FAUmachine. Patch originally provided to Ubuntu by Stefan Potyra. Recently integrated into Debian by KiBi. Signed-off-by: Bryce Harrington --- src/alp_driver.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/src

Re: libpciaccess bogus bridge data - commit 2bda5b73

2010-12-06 Thread Bryce Harrington
On Mon, Dec 06, 2010 at 09:35:48AM -0800, Jesse Barnes wrote: > On Wed, 1 Dec 2010 18:54:22 -0800 > Bryce Harrington wrote: > > > Jesse, > > > > I have a question about change 2bda5b73 that you did to libpciaccess > > last year, to stop pci_device_get_bridge_bus

Re: [PATCH] Fix detection of multi-function cards

2010-12-01 Thread Bryce Harrington
On Thu, Dec 02, 2010 at 03:09:41AM +, Matt Turner wrote: > On Thu, Dec 2, 2010 at 2:42 AM, Bryce Harrington wrote: > > Bit 7 of the pci device header type is an indicator of multi-function > > devices, so needs to be masked when examining the bridge type. > > Thanks

libpciaccess bogus bridge data - commit 2bda5b73

2010-12-01 Thread Bryce Harrington
Jesse, I have a question about change 2bda5b73 that you did to libpciaccess last year, to stop pci_device_get_bridge_buses() from looking at bus data if the bridge data was not read. A ubuntu bug reporter says that this check is preventing his device from getting detected properly - see https:/

[PATCH] Fix detection of multi-function cards

2010-12-01 Thread Bryce Harrington
Bit 7 of the pci device header type is an indicator of multi-function devices, so needs to be masked when examining the bridge type. Thanks go to Chih-Pin Wu for finding the bug and its fix. Signed-off-by: Bryce Harrington --- src/common_bridge.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [Xcb] Thinking towards 7.6 katamari, including xcb

2009-10-28 Thread Bryce Harrington
On Wed, Oct 28, 2009 at 08:38:21AM -0700, Keith Packard wrote: > Excerpts from Alex Deucher's message of Wed Oct 28 08:00:59 -0700 2009: > > While, I'd like to delete a lot of compat cruft in the drivers as > > well, I'm concerned about lack of user testing if we merge the > > driver back into the

Re: [Xcb] Thinking towards 7.6 katamari, including xcb

2009-10-28 Thread Bryce Harrington
On Wed, Oct 28, 2009 at 07:39:41PM +1100, Daniel Stone wrote: > On Wed, Oct 28, 2009 at 12:42:40AM -0700, Keith Packard wrote: > > But, if doing 3 month releases of the whole server tree means that > > we'll scare OSVs away from our project, then I wonder how they manage > > the Linux kernel today.

Re: [Xcb] Thinking towards 7.6 katamari, including xcb

2009-10-26 Thread Bryce Harrington
On Mon, Oct 26, 2009 at 01:28:40PM -0700, Keith Packard wrote: > > Deployment is -largely- distro driven. with our past track record regarding > > QA I'm not sure how many distros are willing to deploy a new server update > > during their stable cycle. At which point you end with server releases be