Wow, I wish I knew about this series before I started cleaning up the drivers...
Where was this series sent? I don't see it in my xorg-devel log.
By all means, take it over. Do you want to maintain it? If so, get yourself
an fd.o account, so you can get yourself commit access to the driver.
On Oct 20, 2011, at 15:22, Alan Coopersmith wrote:
> I do see some warnings in build logs that it would turn into errors, and they
> all seem to be in drivers, and frankly, only the first two of them do I really
> care about:
>
> "radeon_accel.c", line 433: warning: implicit function declaration
Signed-off-by: Jeremy Huddleston
---
1) Is DixReadAccess the right access for these?
2) What conditional CPP logic should I use for doing LookupWindow on older
servers?
src/sis_driver.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/sis_driver.c b/src
Seems like "the right thing" to me
Reviewed-by: Jeremy Huddleston
On Oct 29, 2011, at 09:40, Anssi Hannula wrote:
> On 20.04.2011 14:34, Anssi Hannula wrote:
>> From 003e32786053eb01e2a84697487aa134214f140c Mon Sep 17 00:00:00 2001
>> From: Anssi Hannula
>>
For future reference, please send patches to the list as a new thread,
preferibly with git-send-email or git-format-patch and your own mailer.
On Oct 29, 2011, at 12:54, Michal Suchanek wrote:
> Hello,
>
> Sending the patch for bug 41653.
>
> The following changes since commit 91131037a2d2e070
On Oct 29, 2011, at 14:01, Tormod Volden wrote:
> On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston
> wrote:
>> So, what's the point of having all these in common? Why don't they just
>> live in the drivers? It seems silly to have these defined in the serv
Reviewed-by: Jeremy Huddleston
On Oct 29, 2011, at 10:39, Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
>
> Split out of the prior patch "Convert strncpy/strncat to strlcpy/strlcat"
>
> hw/xfree86/common/xf86pciBus.c |5 ++---
> 1 fi
What about namespacing the ones in xserver instead? I'm sure it's possible
they could conflict with other platforms as well.
On Oct 29, 2011, at 10:24, Alan Coopersmith wrote:
> On 10/29/11 00:16, Jeremy Huddleston wrote:
>> Yuck. Is there really no other way to do that? W
Reviewed-by: Jeremy Huddleston
Why does xi2 "need" -wrap? Can we do these tests in a more portable way with
some clever macros?
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
> test/Makefile.am |2 --
> 1 files chang
For darwin, please also add:
DYLD_INSERT_LIBRARIES=/usr/lib/libgmalloc.dylib
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
> configure.ac | 16
> test/Makefile.am |1 +
> test/xi2/Makefile.am |1 +
> 3 files change
For all of them,
Reviewed-by: Jeremy Huddleston
In this one, it looks like fp should be a (const char *) also. If you throw
that in there in a followup patch, consider it r-b as well.
On Oct 28, 2011, at 21:41, Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
&g
Reviewed-by: Jeremy Huddleston
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
> configure.ac|2 +
> include/dix-config.h.in |3 ++
> include/os.h|4 +++
> os/Makefile.am |4
Sorry.
Reviewed-by: Jeremy Huddleston
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
> Since the check is for !(compilers that support __builtin_constant_p)
> it needs to be !(gcc or new enough Sun cc), but was written as
> !(gcc or too old Sun cc).
>
> Signed-off-by: A
Yuck. Is there really no other way to do that? What exactly are the conflicts?
On Oct 28, 2011, at 17:34, Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
> Xext/shm.c |6 ++
> hw/xfree86/os-support/xf86_OSlib.h |2 +-
> 2 files changed, 7 inser
Reviewed-by: Jeremy Huddleston
On Oct 27, 2011, at 22:07, Aaron Plattner wrote:
> Commit 587c3a2d1961834558193e8e14e8e381a077a253 fixed DoGetImage to
> check windows against their backing drawables, rather than against the
> screen dimensions, to prevent reading outside the bounds of r
The following 7 bug reports are in either the 1.11 or 1.12 tracker and have
patches attached or sent to the list which either fix the underlying issue or
work around a crash due to the issue. I'd like to get these reviewed and
merged. If you're in the CC of this email, then you have "dropped t
The following changes since commit 5701ab4a441eb113abd0851b0d71b82d12112854:
Merge remote-tracking branch 'whot/for-keith' (2011-10-24 22:09:00 -0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (3):
XQuart
While we do need to get to the root cause, the extra sanity checking in here is
good.
Reviewed-by: Jeremy Huddleston
On Oct 11, 2011, at 5:38 AM, Michal Suchanek wrote:
>> Looks like Xorg crashes on exit after 463dd87
>>
>> To reproduce:
>>
>> export DIS
On Oct 25, 2011, at 1:22 AM, Mark Kettenis wrote:
>> From: Jeremy Huddleston
>> Date: Mon, 24 Oct 2011 19:41:00 -0700
>>
>> On Oct 24, 2011, at 7:05 PM, Keith Packard wrote:
>>
>>> And, do we allow the use of
>>> strndup in the server?
>>
Thanks. Sorry for missing those.
Reviewed-by: Jeremy Huddleston
On Oct 24, 2011, at 8:41 PM, Alan Coopersmith wrote:
> Two instances found in the SIOCGIFCONF code for listing network interfaces.
>
> Signed-off-by: Alan Coopersmith
> ---
> os/access.c |4 ++--
>
Reviewed-by: Jeremy Huddleston
On Oct 24, 2011, at 7:59 PM, Peter Hutterer wrote:
> If key/value allocation failed, don't bother adding another InputOption. And
> make sure the memory allocated is large enough for the trailing \0
>
> Signed-off-by: Peter Hutterer
>
On Oct 24, 2011, at 7:05 PM, Keith Packard wrote:
> And, do we allow the use of
> strndup in the server?
Alan just asked that a few days ago ;).
I wouldn't be against using strndup, but there would need to be an in-tree
implementation provided for systems that lack it (like OSX 10.6 and prior)
Reviewed-by: Jeremy Huddleston
On Oct 23, 2011, at 23:02, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> Xi/xiquerydevice.c |7 +++
> dix/eventconvert.c | 14 --
> 2 files changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/Xi
On Oct 20, 2011, at 06:04, Ville Syrjälä wrote:
> On Wed, Oct 19, 2011 at 05:26:09PM -0700, Keith Packard wrote:
>> On Sun, 9 Oct 2011 01:11:04 +0300, Ville Syrjala wrote:
>>
>>> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=22566
>>
>> Merged.
>> e4787ec..a5266dc master -> master
>
Should those commit messages really have "v2" and "v3" in them? It sounds like
they were updated based on feedback during review, which isn't really something
that needs to be mentioned in the commit log...
On Oct 20, 2011, at 01:52, Dave Airlie wrote:
> Fixes from RHEL coverity scan + fbdev
Why not change the format string to use %ld for sizeof() instead of casting?
For the others (and this one if you feel strongly about the casting):
Reviewed-by: Jeremy Huddleston
On Oct 21, 2011, at 20:56, Alan Coopersmith wrote:
> Mostly due to difference between sizeof & int on
I'm confused by the comment, "and just using master" ... because the prototype
changes:
> -XISendDeviceChangedEvent(DeviceIntPtr device, DeviceIntPtr master,
> DeviceChangedEvent *dce)
> +XISendDeviceChangedEvent(DeviceIntPtr device, DeviceChangedEvent *dce)
which seems like you were just using
On Oct 20, 2011, at 12:08, Julien Cristau wrote:
>> if (xnestParentWindow != (Window) 0 &&
>>X.xdestroywindow.window == xnestParentWindow)
>> +CloseWellKnownConnections();
>> +OsCleanup(1);
>> exit (0);
> That looks broken, don't you need braces around the if branch? Als
On Oct 19, 2011, at 23:45, Jamey Sharp wrote:
>> I think we coddled the drivers enough with the current set of
>> just-deprecations. This is too trivial. I'll just go through and
>> make sure nobody is actually using it because drivers still build
>> "successfully" due to us not using
>> -Werro
On Oct 19, 2011, at 17:19, Keith Packard wrote:
> Note that the intel driver does not build with this change; the ancient
> i810/i815 bits rely on the old IOADDRESS apis.
Yeah, you can probably do changes similar to the ones I made in other drivers
to just restrict support to one PCI domain for
>> tam_key = (strchr(string, '=') - string);
>> -newopt->key = (char *)malloc(tam_key);
>> +newopt->key = (char *)malloc(tam_key + 1);
>> strncpy(newopt->key, string, tam_key);
>> newopt->key[tam_key] = '\0';
>> newopt->value = strdup(strchr(strin
On Oct 19, 2011, at 1:02 AM, Zhigang Gong wrote:
>>> For
>>> the client
>>> side application, cairo is a good 2D libraries to utilize GPU hardware
>>> acceleration.
>>> I'm not familiar with spice. Just googled it, and it seems that it's a
>>> protocol to offload
>>> some CPU/GPU intensive tasks t
On Oct 18, 2011, at 10:03 PM, Peter Hutterer wrote:
> On Mon, Oct 17, 2011 at 11:59:38PM -0700, Jeremy Huddleston wrote:
>>
>> Signed-off-by: Jeremy Huddleston
>> ---
>>
>> The comments only really make sense wrt the mieq changes that I have
>> pendi
ers still build "successfully" due to
us not using -Werror=implicit-function-declaration
Perhaps we should add -Werror=implicit-function-declaration to all the
drivers...
On Oct 19, 2011, at 12:20 AM, Jeremy Huddleston wrote:
>
> This partially reverts b3d56d06ef840bbbe16ec3c37e1
Reviewed-by: Jeremy Huddleston
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> If the pGCPriv->flags == 2, then we try to assign the freed pGCPriv->XAAOps
> avoid this by clearing the flags in to be destroyed pGCPriv.
>
> Reported by coverity.
Reviewed-by: Jeremy Huddleston
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> this code wasn't allocating enough space and was assigning the NULL
> one past the end.
>
> Pointed out by coverity.
>
> Signed-off-by: Dave Airlie
> ---
Reviewed-by: Jeremy Huddleston
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This code had an off-by-one and would allow writing one past the end of
> the callbacks array.
>
> Pointed out by coverity.
>
> Signed-off-by: Dave Airlie
>
I actually prefer Alan's suggestion, so with his version:
Reviewed-by: Jeremy Huddleston
On Oct 19, 2011, at 9:51 AM, Alan Coopersmith wrote:
> On 10/19/11 09:01, Dave Airlie wrote:
>> From: Dave Airlie
>>
>> Initialise the pAttr->values to NULL so if the value
Reviewed-by: Jeremy Huddleston
Looks good, but style-wise, I liked the mode = pScrn->monitor->Modes where it
was before ... meh
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
> From: Adam Jackson
>
> So on RHEL5 anaconda sets an xorg.conf with a fixed 800x600 mode in it,
&g
This partially reverts b3d56d06ef840bbbe16ec3c37e170078b7f98b04 to allow
driver developers time to adjust.
Signed-off-by: Jeremy Huddleston
---
The commit that deprecated the PCITAG type had these leftovers that I didn't
mean to get rid of just yet.
hw/xfree86/os-support/bus/Pci.c |
So the tdfx driver has this hunk of code in it currently does the following:
#if USE_PCIVGAIO
hwp->PIOOffset = pTDFX->PIOBase[0] - 0x300;
#endif
Can someone please explain to me why it's doing that?
___
xorg-devel@lists.x.org: X.Org development
Archi
On Oct 18, 2011, at 2:23 AM, Zhigang Gong wrote:
>> -Original Message-
>> From: Jeremy Huddleston [mailto:jerem...@apple.com]
>> Sent: Tuesday, October 18, 2011 3:56 PM
>> To: Zhigang Gong
>> Cc: 'Keith Packard'; xorg-devel@lists.x.org
>&g
FWIW, there are a couple conflicts with my pending PULL request, but they're
trivial to address:
CONFLICT (content): Merge conflict in include/xorg-config.h.in
CONFLICT (content): Merge conflict in hw/xfree86/dixmods/Makefile.am
Your spacing in hw/xfree86/dixmods/Makefile.am is bad, and you're
ping
On Oct 16, 2011, at 2:42 AM, Jeremy Huddleston wrote:
> This was a regression.
>
> Introduced by: 08363c5830bdea34012dcd954b45ccfdc79a3a7e and
> 32db27a7f867b503c2840ca7b815e96d10be9210
> Masked by: 1e69fd4a60147287b31e53bfc61543fb17bb82c8
>
>
Signed-off-by: Jeremy Huddleston
---
The comments only really make sense wrt the mieq changes that I have pending,
but the test should work regardless.
test/input.c | 69 ++
1 files changed, 69 insertions(+), 0 deletions(-)
diff
On Oct 17, 2011, at 4:58 PM, Peter Hutterer wrote:
>> +if (new_nevents <= eventQueue->nevents)
>> +return FALSE;
>> +
>> +if (!eventQueue) {
>> +ErrorF("[mi] mieqGrowQueue called with a NULL eventQueue\n");
>> +return FALSE;
>> +}
>
> this condition needs to b
Looks to me like you want those to be declared 'static inline'
Why not have EvdevBitIsSet and EvdevSetBit use BitIsSet/SetBit with
endianness-fu?
On Oct 17, 2011, at 11:34 AM, Max Schwarz wrote:
> We can't use BitIsSet/SetBit from the server (inputstr.h) since they
> operate on byte arrays. Ev
Reviewed-by: Jeremy Huddleston
On Oct 17, 2011, at 10:00 AM, Gaetan Nadon wrote:
> Spaces or tabs do not affect the text output layout.
>
> Signed-off-by: Gaetan Nadon
> ---
> hw/xwin/man/XWinrc.man | 10 +-
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
&
This should force the server to have -fno-strict-aliasing even once it
is removed from the warning flags.
See: https://bugs.freedesktop.org/show_bug.cgi?id=31238
Signed-off-by: Jeremy Huddleston
---
configure.ac |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git xorg
PCI_CHIP_GD7556 0x004C
#endif
if it wants to work on older servers without the change ...
On Oct 17, 2011, at 1:48 AM, Jeremy Huddleston wrote:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=1837
>
> Signed-off-by: Jeremy Huddleston
> ---
> hw/xfree86/common/xf86PciInfo.h |1
https://bugs.freedesktop.org/show_bug.cgi?id=1837
Signed-off-by: Jeremy Huddleston
---
hw/xfree86/common/xf86PciInfo.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/xfree86/common/xf86PciInfo.h b/hw/xfree86/common/xf86PciInfo.h
index 356c7db..2825ece 100644
--- a
On Oct 16, 2011, at 10:30 PM, Keith Packard wrote:
> On Sun, 16 Oct 2011 22:14:31 -0700, Jeremy Huddleston
> wrote:
>
>> +if ((miEventQueue.tail - miEventQueue.head) % miEventQueue.nevents >=
>> (miEventQueue.nevents >> 1) &&
>
> I missed th
On Oct 16, 2011, at 10:15 PM, Keith Packard wrote:
> On Sun, 16 Oct 2011 21:56:43 -0700, Jeremy Huddleston
> wrote:
>
>> n_events_at_tail ? I'm not really sure what to call it.
>
> If I had a good idea, I would have suggested it :-) Perhaps just don't
> bot
On Oct 16, 2011, at 10:12 PM, Keith Packard wrote:
> On Sun, 16 Oct 2011 21:16:13 -0700, Jeremy Huddleston
> wrote:
>>
>> The last 64 events in the event queue will be reserved for release
>> events in order to help return the system to a cleaner state when
>> i
identify the true hog in cases where one backtrace might be
insufficient.
Signed-off-by: Jeremy Huddleston
---
Ok ... 5th time's the charm?
Responded to Keith's recent comments
mi/mieq.c | 174 -
1 files changed, 138 inserti
On Oct 16, 2011, at 9:44 PM, Keith Packard wrote:
> On Sun, 16 Oct 2011 21:16:09 -0700, Jeremy Huddleston
> wrote:
>
>> +/* We block signals, so SIGIO does trigger mieqEnqueue to write to the
>> + * queue as we're modifying it.
>> + */
>> +
The last 64 events in the event queue will be reserved for release
events in order to help return the system to a cleaner state when
it comes back from a soft wedge.
Signed-off-by: Jeremy Huddleston
---
mi/mieq.c | 50 +++---
1 files changed, 39
identify the true hog in cases where one backtrace might be
insufficient.
Signed-off-by: Jeremy Huddleston
---
Changes since previous version:
Respond to Peter's feedback
mi/mieq.c | 169 -
1 files changed, 133 insertions(+
On Oct 16, 2011, at 8:44 AM, Keith Packard wrote:
> On Sat, 15 Oct 2011 23:31:35 -0700, Jeremy Huddleston
> wrote:
>
>> Yes. This patch was motivated by some server bugs I read through in
>> bugzilla today. Apparently some DRI drivers can hog the CPU for a
>> whil
On Oct 16, 2011, at 1:47 PM, Jeremy Huddleston wrote:
>> I'm not sure we need to be even this verbose; just a single warning when
>> the queue is blocked and another one when it starts working again should
>> be sufficient. I fear flooding the disk with errors if this happ
On Oct 16, 2011, at 9:32 AM, walter harms wrote:
>> @@ -487,8 +487,7 @@ int ScreenNum;
>> * actually mmap the start of the page, then the start of video
>> * I/O space is added as an internal offset.
>> */
>> -IOPortBase = (unsigned int)xf86MapInfoMap(memInfoP
identify the true hog in cases where one backtrace might be
insufficient.
Signed-off-by: Jeremy Huddleston
---
Changes from v2:
Responded to keithp's comments
mi/mieq.c | 129 ++--
1 files changed, 107 insertions(+), 22 deletions(-)
On Oct 16, 2011, at 8:44 AM, Keith Packard wrote:
> On Sat, 15 Oct 2011 23:09:30 -0700, Jeremy Huddleston
> wrote:
>
>> +if (new_queue == NULL)
>> +FatalError("Unable to allocate memory for the event queue.\n");
>
> This function should be
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038
Signed-off-by: Matt Kraai
Reviewed-by: Jeremy Huddleston
---
Ok, so I really don't understand why ppc had its own ioBase in
os-support/linux/lnx_video.c rather than using IOPortBase. In any event, I
want to nuke this code r
This addresses issues on 64bit systems where the IOPortBase is higher in
memory space.
Partially fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038
Signed-off-by: Jeremy Huddleston
---
hw/xfree86/common/compiler.h |2 +-
hw/xfree86/os-support/bsd/arm_video.c | 21
gt; From: Jeremy Huddleston
>> Date: Sun, 16 Oct 2011 02:27:08 -0700
>>
>> This allows scan.c to build with -Wincompatible-pointer-types
>>
>> Build regression introduced by: efa5269f23c2237eb5368bf5245ffbbf35714153
>>
>> Signed-off-by: Jeremy Huddleston
Did you not see v3 which was sent before your email? ;)
On Oct 16, 2011, at 4:00 AM, Mark Kettenis wrote:
>> From: Jeremy Huddleston
>> Date: Sat, 15 Oct 2011 23:17:37 -0700
>>
>> This patch changes from a static length event queue (512) to one that starts
>>
On Oct 16, 2011, at 3:49 AM, Mark Kettenis wrote:
>>
>> This addresses issues on 64bit systems where the IOPortBase is higher in
>> memory space.
>
>> -_X_EXPORT unsigned int IOPortBase; /* Memory mapped I/O port area */
>> +_X_EXPORT pointer IOPortBase; /* Memory mapped I/O port area */
>
>
identify the true hog in cases where one backtrace might be
insufficient.
Signed-off-by: Jeremy Huddleston
---
Changes since v2:
mieqGrowQueue is done in mieqProcessInputEvents rather than mieqEnqueue
since the latter can be called from a signal handler
mi/mieq.c | 122
On Oct 16, 2011, at 2:19 AM, Julien Cristau wrote:
> On Sat, Oct 15, 2011 at 23:09:30 -0700, Jeremy Huddleston wrote:
>
>> This patch changes from a static length event queue (512) to one that starts
>> at 128 and grows to 4096 as it overflows, logging each time it grows.
This was a regression.
Introduced by: 08363c5830bdea34012dcd954b45ccfdc79a3a7e and
32db27a7f867b503c2840ca7b815e96d10be9210
Masked by: 1e69fd4a60147287b31e53bfc61543fb17bb82c8
Signed-off-by: Jeremy Huddleston
---
hw/xnest/Keyboard.c | 25 +
1 files
This allows scan.c to build with -Wincompatible-pointer-types
Build regression introduced by: efa5269f23c2237eb5368bf5245ffbbf35714153
Signed-off-by: Jeremy Huddleston
---
hw/xfree86/parser/scan.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/parser
, at 11:23 PM, Keith Packard wrote:
> On Sat, 15 Oct 2011 23:09:30 -0700, Jeremy Huddleston
> wrote:
>
>> This patch changes from a static length event queue (512) to one that starts
>> at 128 and grows to 4096 as it overflows, logging each time it grows.
>
> Are there c
identify
the true hog in cases where one backtrace might be insufficient.
Signed-off-by: Jeremy Huddleston
---
Change since v1:
Fixed whitespace indentation issues with the first version.
mi/mieq.c | 96 -
1 files changed, 76 insertions
identify
the true hog in cases where one backtrace might be insufficient.
Signed-off-by: Jeremy Huddleston
---
I tested the logic by setting:
#define INITIAL_QUEUE_SIZE 2
#define MAXIMUM_QUEUE_SIZE 8
#define DROP_BACKTRACE_FREQUENCY 2
#define DROP_BACKTRACE_MAX
This version of the patch also isn't complete because ioBase_phys is an
unsigned int. It allows iobases in the 0x100-0x range to work, but
not 0x1 and higher. The followup 2-part series I just sent should work
even if __NR_pciconfig_iobase is higher.
The long term fix is t
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038
Signed-off-by: Matt Kraai
Reviewed-by: Jeremy Huddleston
---
hw/xfree86/os-support/linux/lnx_video.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/xfree86/os-support/linux/lnx_video.c
b/hw
This addresses issues on 64bit systems where the IOPortBase is higher in
memory space.
Partially fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038
Signed-off-by: Jeremy Huddleston
---
hw/xfree86/common/compiler.h |2 +-
hw/xfree86/os-support/bsd/arm_video.c | 11
Rec));
>> +memset(&floating_sprite, 0, sizeof(SpriteInfoRec));
>
> But changing these to:
> memset(&vcp_sprite, 0, sizeof(vcp_sprite));
> et al would be even better ...
>
> With that:
> Reviewed-by: Daniel Stone
>
> Cheers,
> Daniel
> __
Co-authored-by: Jeremy Huddleston
Signed-off-by: Peter Hutterer
Reviewed-by: Peter Hutterer
Reviewed-by: Jeremy Huddleston
---
dix/inpututils.c | 63
include/inpututils.h |6 ++
test/input.c | 128
Is there a bug report open for this? I want to make sure it doesn't get lost
since there hasn't been a review on it and it's still a bit in progress.
I'm sorry I can't really comment on this patch as I'm not familiar with the
those APIs.
On Oct 11, 2011, at 12:11 AM, Tomáš Trnka wrote:
> Bug
This looks mostly correct, but I want someone a bit more familiar with the Xorg
DDX to comment on it as well.
Reviewed-by: Jeremy Huddleston
On Oct 11, 2011, at 10:16 AM, Michal Suchanek wrote:
> Hello,
>
> this is a patch that fixes a long-standing issue with the X server.
>
&g
Pushed, thanks.
On Oct 12, 2011, at 4:05 PM, Choe Hwanjin wrote:
> I've updated my patch to make it look more like the patch from SuSE.
> My patch still have slight difference, because I've fix some bad tabs.
> See the attachment.
>
> 2011/10/12 Jeremy Huddleston :
>
IOPortBase is exported. While I agree that compiler.h and most of the bus
support in xf86 should die in a fire, you really shouldn't change the symbol
name for no good reason.
1) I would prefer to see a fix for siliconmotion driver to have it "do the
right thing" by not calling into this broke
Merged
603ad66..bbe6a69 server-1.11-branch -> server-1.11-branch
On Oct 13, 2011, at 23:35, Peter Hutterer wrote:
> Commit bbe6a69da398dba93679c23c3c50f9916cb562ca
>
> The following changes since commit 603ad6608a0dbe2fb1bdc4bcd8b4117f2b0bc8b2:
>
> XQuartz: pbproxy: Add missing AM_OBJCFLAG
On Oct 12, 2011, at 6:12 PM, Alan Coopersmith wrote:
> On 10/12/11 10:50 AM, Keith Packard wrote:
>> 2. I'd love to figure out how to fork at the time of the error; this
>> would encourage people to actually use this option regularly.
>>
>> posix threads makes the usual libc fork() func
Please send any merge requests or nominations by Thursday for inclusion in
1.11.2 RC1.
Thanks,
Jeremy
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Oct 11, 2011, at 18:34, Choe Hwanjin wrote:
> I've made my patch again against libX11 git master
> 22ba43d198dcca86c88eb15a56fc7d8fc47c422e.
> This patch already has changes that revert commit
> 1a1a42a3ca1dfaf42f1094936b71c140fc030fcb.
> I don't see any significant differences between your pat
m fetch for !PC machines
pci: Remove xf86MapDomainMemory
int10: Port internal users off xf86MapVidMem
Jeremy Huddleston (12):
loader: when creating sdksyms.c only include shmint.h if MITSHM is
enabled #29109
Xnest: Remove socket and its lock file on exit
Xephyr: Remove
On Oct 11, 2011, at 11:47, James Cloos wrote:
>>>>>> "JH" == Jeremy Huddleston writes:
>
> JH> +: "ffi" Ufb03 # LATIN SMALL
> LIGATURE FFI
> JH> +: "ffl" Ufb04 # LATIN SMALL
&
Thanks Javier!
Pushed.
On Oct 11, 2011, at 00:46, Javier Pello wrote:
> On Fri, 2011-10-07 at 10:18:20 -0700, Jeremy Huddleston wrote:
>> +char name[PATH_MAX];
>> +int flags = O_RDONLY;
>> +int prot = PROT_READ;
>> +int fd;
>> +int
+ : "ffi" Ufb03 # LATIN SMALL LIGATURE FFI
+ : "ffl" Ufb04 # LATIN SMALL LIGATURE FFL
Why are those notandinstead?
On Oct 9, 2011, at 23:45, Marko Myllynen wrote:
> This patch adds few new compose sequences to the en_US map, ligatures
> common in
You are missing this in src/SMlibint.h:
#include
string.h includes the prototype for memset().
Also, please add a Signed-off-by: line to your commit message along with my:
Reviewed-by: Jeremy Huddleston
Once the above are fixed, please resend to the list, and I'll push it in.
Thanks
ic.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=7869
Reviewed-by: Jeremy Huddleston
---
This is the version that OpenSuSE pulled in
modules/im/ximcp/imDefFlt.c | 16 ++--
modules/im/ximcp/imDefIc.c |4
modules/im/ximcp/imDefLkup.c | 12
module
Choe, I'm a bit confused here. This looks like an older version of your patch
from:
https://bugs.freedesktop.org/attachment.cgi?id=13405
Bernd provided an updated version
https://bugs.freedesktop.org/attachment.cgi?id=21093
which took into account changes in libX11
http://cgit.freedesktop.org/x
Ok, thanks for addressing my concerns.
Reviewed-by: Jeremy Huddleston
On Oct 11, 2011, at 06:08, Yann Droneaud wrote:
> Le lundi 10 octobre 2011 à 14:00 -0700, Jeremy Huddleston a écrit :
>> The src changes look right, but I'm wondering if this is a documentation bug
>
On Oct 11, 2011, at 02:52, Michal Suchanek wrote:
> Hello,
>
> While valgrinding the X server to track a double free in one of my
> patches I found the errors below.
>
> I run Xorg +extension GLX +extension RANDR +extension RENDER -logfile
> /scratch/xdummy.log -config ~hramrach/xdummy.conf :1
Reviewed-by: Jeremy Huddleston
On Sep 23, 2011, at 20:42, Alan Coopersmith wrote:
> From: Christopher Yeleighton
>
> https://bugs.freedesktop.org/show_bug.cgi?id=38420
>
> Exit with fatal error message, not segfault.
>
> Signed-off-by: Alan Coopersmith
> ---
>
Signed-off-by: Jeremy Huddleston
---
doc/Xserver-spec.xml | 10 +-
include/os.h |1 -
os/backtrace.c |5 +++--
os/log.c | 14 --
os/xprintf.c |5 +++--
5 files changed, 7 insertions(+), 28 deletions(-)
diff --git a/doc
On Oct 10, 2011, at 18:24, Peter Hutterer wrote:
> There are only very few callers. IMO we should replace them with
>ErrorF("%s", strerror(errno));
> and remove this one completely.
Except that it is exported:
os.h:extern _X_EXPORT void Error(const char *str);
How about deprecating it in
501 - 600 of 1444 matches
Mail list logo
