: https://bugs.freedesktop.org/show_bug.cgi?id=92914
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
v2: Less intrusive patch
v3: Simpler patch, no need to skip the output being removed, simply
remove it from the list prior to walk the list.
hw/xwayland/xwayland-output.
: https://bugs.freedesktop.org/show_bug.cgi?id=92914
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
v2: Less intrusive patch
hw/xwayland/xwayland-output.c | 68 ---
1 file changed, 45 insertions(+), 23 deletions(-)
diff --git a/hw/xwayland/xw
cgi?id=93045
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
hw/xwayland/xwayland-glamor.c | 4 +++-
hw/xwayland/xwayland-output.c | 4
hw/xwayland/xwayland-shm.c| 4 +++-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayl
Hi
- Original Message -
> > Or does Xwayland perhaps have a requirement for compositors to have
> > no output space to the left and/or right of 0,0?
>
> I don't know if there's such a written requirement, but reading the code as
> you did, I don't think it expect outputs to a have
Hi Pekka,
> I see that the above is old code just moved and I don't really know
Yes, it is old code that I simply moved up in the source so I could reuse it
without adding a forward declaration :-)
> how Xwayland works here, but that code looks strange to me. I don't
> know what useful meaning
: https://bugs.freedesktop.org/show_bug.cgi?id=92914
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
hw/xwayland/xwayland-output.c | 149 --
1 file changed, 85 insertions(+), 64 deletions(-)
diff --git a/hw/xwayland/xwayland-output.c b/hw/xw
If the existing outputs are arranged to a different layout, the screen
dimension need to be updated as it depends on the actual layout.
So update the screen dimension on geometry changes as well.
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
hw/xwayland/xwayland-output
Hi all
- Original Message -
> On 26/08/2015 16:24, Olivier Fourdan wrote:
> >> The value of FD_SETSIZE for those targets in xserver's configure.ac:403
> >> probably needs to be increased to match (See the comment on xserver
> >> commit ed2c2a68)
> >
&g
Hi Jon,
- Original Message -
> Looks like I applied the patch [1]?
>
> [1]
> http://cgit.freedesktop.org/xorg/proto/x11proto/commit/?id=edc04f87c74abacb57782dc947f81a2810a72537
Oh sorry, I overlooked that commit!
Thanks!
Olivier
___
Hi Jonas,
- Original Message -
> On Mon, Oct 12, 2015 at 05:35:20AM -0400, Olivier Fourdan wrote:
> > Hi Jonas,
> >
> > > In Wayland, a client (in this case XWayland) should set the cursor
> > > surface when it receives pointer focus. Not doing
Hi Krzysztof,
Quick question, as I haven't heard back from you, do you plan to follow
up on these patches or should I fix them?
Cheers,
Olivier
On 14/10/15 18:24, Olivier Fourdan wrote:
Hi
- Original Message -
More worryingly, I tried xvidtune with that patch applied and that
led
Hi Krzysztof,
- Original Message -
> From: Krzysztof Sobiecki
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=87806
>
> Signed-off-by: Krzysztof A. Sobiecki
> ---
So if I understand correctly, this patch adds the client interface but does
Hi
- Original Message -
> More worryingly, I tried xvidtune with that patch applied and that
> led to a crash in Xwayland - I'll investigate further to see if this
> is something in my tree or with the patch as I suspect.
Quick follow up, the crash occurs in VidModeGetMonitor() from
Hi Jonas,
> In Wayland, a client (in this case XWayland) should set the cursor
> surface when it receives pointer focus. Not doing this will leave the
> curser at whatever it was previously.
>
> When running on XWayland, the X server will not be the entity that
> controls what actual pointer
Hi all,
Any chance to get a review of this patch?
Cheers,
Olivier
- Original Message -
> As mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=92076#c5
>
> Tested-by: Artem Chudinov
>
> Cheers,
> Olivier
> ___
>
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92076
> Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
> ---
> hw/xwayland/xwayland-output.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
As mentioned in https://bugs.freedesktop.org/
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92076
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
hw/xwayland/xwayland-output.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/xwayland/xwayland-output.c b/hw/xwayland/xwayland-output.c
Hi Adam,
- Original Message -
> Ugh. abidiff is still complaining, and I'm not entirely sure it's
> wrong. The problem is there's a SpriteRec embedded in the middle of
> TouchPointInfoRec, so changing the former at all changes the latter. It
> seems icky to me to have that be a SpriteRec
Hi Adam,
Could you please pull from the following git tree some fixes for Xwayland (some
are quite old).
Cheers,
Olivier
---
The following changes since commit 58d54ee82dfae5486bc09d04d2760c922d54d631:
glamor: explicitly check for GL_OES_EGL_image (2015-09-17 11:03:15 -0400)
are available
On 21/09/15 11:19, Daniel Stone wrote:
Hi,
On 21 September 2015 at 09:52, Jonas Ådahl wrote:
In Wayland, a client (in this case XWayland) should set the cursor
surface when it receives pointer focus. Not doing this will leave the
curser at whatever it was previously.
When
Hi Adam,
> At this point in the 1.18 cycle we're meant to be locking down ABI,
> which means this series can't quite go in as-is:
>
> > @@ -212,6 +212,7 @@ typedef struct _GrabRec {
> > [...]
>
> Breaks SpriteRec layout.
>
> > @@ -524,6 +527,7 @@ typedef struct _Screen {
> > [...]
>
> Breaks
Hey Carlos,
On 27/05/15 18:41, Carlos Garnacho wrote:
This struct holds information about each individual, ongoing touchpoint.
A list of these is held by the xwl_seat.
Signed-off-by: Carlos Garnacho
lgtm
Rebased and added this patch to my tree, but I don't have the
On 27/05/15 18:41, Carlos Garnacho wrote:
A DeviceIntPtr with touch valuators is also created in order to deliver
the translated touch events. The lifetime of xwl_touch structs is tied
to the wayland ones, finishing in either wl_touch.up() or wl_touch.cancel()
Signed-off-by: Carlos Garnacho
Hi Jasper, Daniel,
On 06/04/15 18:52, Daniel Stone wrote:
On 23 February 2015 at 15:40, Daniel Stone wrote:
On 21 February 2015 at 19:53, Jasper St. Pierre wrote:
[...]
Signed-off-by: Jasper St. Pierre
Acked-by: Daniel
On 28/08/15 06:28, Peter Hutterer wrote:
No functional changes.
Signed-off-by: Peter Hutterer
For the series, lgtm.
Applied all 3 patches in my tree.
Cheers,
Olivier
___
xorg-devel@lists.x.org: X.Org development
On 29/05/15 11:45, Carlos Garnacho wrote:
Hey Jasper,
On Wed, May 27, 2015 at 7:56 PM, Jasper St. Pierre
wrote:
I'm planning on removing this hook and just make compositors deal with
the fallout. Unfortunately, it hasn't been merged yet.
On 27/05/15 18:42, Carlos Garnacho wrote:
These sequences are forgotten to all purposes.
Signed-off-by: Carlos Garnacho
lgtm.
Applied in my tree.
Cheers,
Olivier
___
xorg-devel@lists.x.org: X.Org development
Archives:
art <ch...@demorecorder.com>
> Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
> Reviewed-by: Adam Jackson <a...@redhat.com>
> ---
> v1: Original version sent by Christian Linhart
> v2: Updated patch from Olivier Fourdan reviewed by Adam Jackson
> http://pa
Hi Bryce,
cc'ing xorg-devel as well, see below, I would like to help with xwayland.
- Original Message -
> I've assembled a blog post with a run-down of our current status on
> Wayland - bugs needing attention, features in the works, etc.
> Thanks go to Pekka for helping gather all the
Hi Bryce,
- Original Message -
> That'd be great, thanks Olivier!
>
> I'm not sure if the wayland patchwork is representative of Xwayland
> patches, as we tend to prune PW to show only items bound for weston and
> wayland specifically. But perhaps we can get a patchwork queue set up
>
;
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
Reviewed-by: Adam Jackson <a...@redhat.com>
---
v1: Original version sent by Christian Linhart
v2: Updated patch from Olivier Fourdan reviewed by Adam Jackson
http://patchwork.freedesktop.org/patch/46062/
v3: Updated patch to add de
/show_bug.cgi?id=91763
Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
include/resource.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/resource.h b/include/resource.h
index 597f7b6..5871a4c 100644
--- a/include/resource.h
+++ b/include/resource.h
@@
Hi Jon,
Yeap, the previous fix was working only when --enable-dmx wasn't set
(default).
When set, it would fail with the error you reported (I hit that just yesterday
as well!)
I can confirm your patch fixes the issue for me as well, you have my tested-by.
Cheers,
Olivier
- Original
on these platforms.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
Xpoll.h.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Xpoll.h.in b/Xpoll.h.in
index 01be164..2878591 100644
--- a/Xpoll.h.in
+++ b/Xpoll.h.in
@@ -165,7 +165,7 @@ typedef struct fd_set {
#else /* WIN32
from 256 to 512
but only for non WIN32/CYGWIN platforms.
The definition of XFD_SETSIZE being duplicated, we need to do the same
for WIN32/CYGWIN builds as well otherwise a newer X server trying to
use more than 256 clients would fail on these platforms.
Signed-off-by: Olivier Fourdan ofour
Hi Jon,
The value of FD_SETSIZE for those targets in xserver's configure.ac:403
probably needs to be increased to match (See the comment on xserver
commit ed2c2a68)
Yeah, well, I changed that already to 512 in commit d206c240 for consistency
(in doubt, I tried to keep consistent).
(The
Hi Jonas,
On 31 July 2015 at 09:52, Jonas Ådahl jad...@gmail.com wrote:
Might be missing something obvious but shouldn't it be possible to check
whether
WAYLAND_DISPLAY environment variable is set?
Y
eap, even simpler!
Cheers,
Olivier
___
Hi
Some apps should be run in a plain X11 session but not in XWayland (e.g. an
X11 screensaver makes no sense in Wayland/XWayland).
There is one atom WL_SURFACE_ID that should be created only on/by XWayland
(for obvious reasons), is that reliable enough to determine we're running
on XWayland?
Hi
- Original Message -
I'm still looking for a reviewer of the corresponding patch in Xpoll.h
itself (xproto). Perhaps patches 23 in the series discouraged
reviewers, but patch 1 is needed for this, otherwise the other
re-ordering patches are not sufficient.
I posted a comment to
Message -
To make sure we have enough file descriptors to manage at most 512
clients.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 328563e..16d2123 100644
Hi
From: Matthew Green m...@netbsd.org
Move the define of FD_SETSIZE before the include of select.h, so that
is actually does something useful.
Signed-off-by: Thomas Klausner w...@netbsd.org
---
Xpoll.h.in | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
Hi Keith,
Your repository isn't accessible via git:// protocol, which means only
people with fd.o accounts can fetch from it. I think all you'd need to
do is touch the git-daemon-export-ok file and it should work.
Yeap, seems that did the trick!
Thanks for the heads-up/trick/merge :)
Adding the dependency on xproto 7.0.28 that has been released last Wednesday
which includes the patch to increase the number of file descriptors.
This is required for the second (dependent) patch which has already been
reviewed by Adam, thus adding the R-b: Adam Jackson a...@redhat.com to that
Adam Jackson
a...@redhat.com
Signed-off-by: Adam Jackson a...@redhat.com
Signed-off-by: Olivier Fourdan ofour...@redhat.com
Reviewed-by: Adam Jackson a...@redhat.com
---
v2: Use the user set client limit in multiple places instead of MAXCLIENTS,
Bump value for MAXCLIENTS, MAXSELECT, MAXSOCKS
To make sure we have enough file descriptors to manage at most 512
clients.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 328563e..16d2123 100644
--- a/configure.ac
+++ b
Hi Keith,
Could you please pull from the following git tree the fix for Xwayland that
Chris contributed for bug https://bugs.freedesktop.org/show_bug.cgi?id=91072?
It's been reviewed by Michel Dänzer and the commit message contains the R-b.
Cheers,
Olivier
---
The following changes since
-by: Olivier Fourdan four...@gmail.com
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
v2: Much better/simpler solution suggested by Chris in bug 91072
v3: Fix funky spelling/syntax in commit message
hw/xwayland/xwayland-shm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Reported-and-tested-by: Olivier Fourdan four...@gmail.com
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
v2: Much better/simpler solution suggested by Chris in bug 91072
hw/xwayland/xwayland-shm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xwayland/xwayland-shm.c
usable clients in Xwayland (even if the client limit will
remain a theoretical limit unlikely to be reachable in Xwayland).
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
See also: http://lists.x.org/archives/xorg-devel/2015-May/046543.html
include/opaque.h | 1 +
os/WaitFor.c
of clients to a lower value, allowing
for more usable clients in Xwayland (even if the client limit will
remain a theoretical limit unlikely to be reachable in Xwayland).
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
See also: http://lists.x.org/archives/xorg-devel/2015-May/046543.html
increase the number of X resources per client or
vice-versa.
Parts of this patch are based on a similar patch from Adam Jackson
a...@redhat.com
Signed-off-by: Adam Jackson a...@redhat.com
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: Use the user set client limit in multiple places
Adam Jackson
a...@redhat.com
Signed-off-by: Adam Jackson a...@redhat.com
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: Use the user set client limit in multiple places instead of MAXCLIENTS,
Bump value for MAXCLIENTS, MAXSELECT, MAXSOCKS and OPEN_MAX to 512,
Requires
Hi
This needs http://patchwork.freedesktop.org/patch/50714/ to be applied on X
proto first.
Attaching the small programs I use to test this patch, of course the idea is
tio choose between the number of clients or the number of resources per client
(as both end up being in the same 29bit
to be of zero length, leading to sometimes rather large missing
portion of the arc.
Try to detect this case and work around it.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
mi/miarc.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/mi/miarc.c b/mi/miarc.c
index e8bc87e
Hi Alan,
- Original Message -
Looking back at the notes from when the Solaris Xsun made similar changes
long
ago (on an X11R6.4 code base), they say we had to change:
- MAXCLIENTS
- MAXSOCKS
- OPEN_MAX
- TRANS_OPEN_MAX
- XFD_SETSIZE
(If it's useful that Xsun code base
To allow up to 512 clients, the number of file descriptors being
monitored need to be increased accordingly.
Signed-off-by: Adam Jackson a...@redhat.com
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
Xpoll.h.in | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff
Adam Jackson
a...@redhat.com
Signed-off-by: Adam Jackson a...@redhat.com
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: Use the user set client limit in multiple places instead of MAXCLIENTS,
Bump value for MAXCLIENTS, MAXSELECT, MAXSOCKS and OPEN_MAX to 512,
Requires
With larger ellipses, rounding will cause some spans close to vertical
tangent to be of zero length, leading to sometimes rather large missing
portion of the arc.
Try to detect this case and work around it.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
mi/miarc.c | 10 ++
1
);
for (j = 0; j 1; j += 100)
XDrawArc(display, win, gc,
5 + j / 10, j / 2 - (1 - 1024 / 2),
1, 2 - j,
175 * 64, 10 * 64);
}
}
XCloseDisplay(display);
return 0;
}
Olivier Fourdan (1):
mi: reduce missing segments
Hi all,
Anyone got a chance to look further into this? (this is an old bug with several
unsuccessful attempted fixes)
Chris, what do you think of the wrap test for the sequence that must remain in
32bits?
Cheers,
Olivier
- Original Message -
From: Olivier Fourdan ofour...@redhat.com
Make sure X_BIG_ENDIAN/X_LITTLE_ENDIAN are defined before actually using
them.
Otherwise, byte order could be wrong even though endianess detection is
correct.
Reported-by: Tim Waugh twa...@redhat.com
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
include/dix-config.h.in | 8
1
Hi Christian,
On 27/03/15 15:50, Olivier Fourdan wrote:
On 21/03/15 15:32, Christian Linhart wrote:
[...]
I am not a libX11 maintainer, so it's not really a review or anything,
it's just some comments :-)
So I looked further into your patch (took me some time!) and came to the
following
Hi Christian,
On 21/03/15 15:32, Christian Linhart wrote:
I have made an alternative fix for the Xlib 32-bit
request number issue, that is described in the following bugreport.
https://bugs.freedesktop.org/show_bug.cgi?id=71338
Thanks for looking into this!
The approach of this fix is to
in the client.
Also, if we get here and the device is on, then that's definitely a bug,
warn about that.
https://bugs.freedesktop.org/show_bug.cgi?id=89296
Signed-off-by: Olivier Fourdan ofour...@redhat.com
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
v3: Check for valid device only
Message -
From: Olivier Fourdan ofour...@redhat.com
To: Peter Hutterer peter.hutte...@who-t.net
Cc: xorg-devel@lists.x.org
Sent: Wednesday, February 25, 2015 9:07:24 AM
Subject: Re: [RFC PATCH xf86-input-libinput v2] Do not crash if the device is
invalid
Hi Peter,
On 25/02/15 03:41, Peter
https://bugs.freedesktop.org/show_bug.cgi?id=89296
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: Move the test to LibinputSetProperty() and do it only once
src/libinput.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/libinput.c b/src/libinput.c
index 9613fbd
https://bugs.freedesktop.org/show_bug.cgi?id=89296
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
src/libinput.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/libinput.c b/src/libinput.c
index 9613fbd..3159373 100644
--- a/src/libinput.c
+++ b/src
On 21/02/15 20:53, Jasper St. Pierre wrote:
This was built as a hack for simple Wayland compositors like Weston
which were lazy and didn't want to configure windows server-side when
moved.
Since comboboxes and menus are separate toplevel O-R windows, this hack
breaks input as it needs to be
On 20/02/15 10:47, Olivier Fourdan wrote:
[...]
+cs = GetCompScreen(screen);
+if (cs-pOverlayWin cs-pOverlayWin-mapped) {
Although GetCompScreen() is actually a macro which calls
dixLookupPrivate() so maybe not a good idea to do that for every every
pointer event.
Cheers
Hi Jasper,
I was working on the same issue
(https://bugzilla.redhat.com/show_bug.cgi?id=1188289) but did not think
about translating the coordinates!
I applied your patch along with the patch for mutter (on mutter 3.14.3
as found in F21) not to map the cow but that does not work very well.
, Jasper St. Pierre wrote:
On Fri, Feb 20, 2015 at 1:47 AM, Olivier Fourdan ofour...@redhat.com
mailto:ofour...@redhat.com wrote:
Hi Jasper,
I was working on the same issue
(https://bugzilla.redhat.com/__show_bug.cgi?id=1188289
https://bugzilla.redhat.com/show_bug.cgi?id=1188289
Hi Jasper,
On 20/02/15 18:05, Olivier Fourdan wrote:
Hi
Sorry, I probably didn't express myself correctly here. What I've been
trying to say is:
- The patch does not work for me, it makes things worse than before,
the X window field is not consistent depending on where the event
occurs. So
() if the limit is lower than 128.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=88316
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: * Check for GL version 30
v3: * Remove use of GLAMOR_MIN_ALU_INSTRUCTIONS environment variable,
* Use LogMessage() in place of ErrorF() for warning when
Hi
Really sorry, I did not send the correct patch, this one had a typo
(missing closing parenthesis), new one to follow in a second.
Cheers,
Olivier
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info:
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: Missing closing parenthesis
hw/kdrive/ephyr/hostx.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c
index f64861b..6c4d61c 100644
--- a/hw/kdrive/ephyr
So that Xwayland gets re-linked each time glamor is modified.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
hw/xwayland/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/xwayland/Makefile.am b/hw/xwayland/Makefile.am
index 9945540..ab1bbb6 100644
--- a/hw/xwayland
() if the limit is lower than 128.
Can be overridden with the environment variable
GLAMOR_MIN_ALU_INSTRUCTIONS for testing and debugging purpose.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=88316
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: Check for GL version 30
glamor/glamor.c
On 28/01/15 21:17, Ian Romanick wrote:
Do we know which GPUs cannot meet this limit and also do not have true
integer support? I wonder if we should go ahead and do the
GL_MESA_shading_language_130 or GL_MESA_gpu_shader_int32 extensions that
we had previously discussed, and remove support for
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
hw/kdrive/ephyr/hostx.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c
index f64861b..6c4d61c 100644
--- a/hw/kdrive/ephyr/hostx.c
+++ b/hw/kdrive/ephyr/hostx.c
Hi
On 21/01/15 19:32, patrick keshishian wrote:
Excuse my naive observation; I'm possibly missing something.
The comment states status length is CARD8 but the header
file (If I'm looking at the correct one) states it is CARD16:
the XdmcpFatal() code to use a simpler string format
instead.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
v2: Use malloc() instead of a fixed char array
os/xdmcp.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/os/xdmcp.c b/os/xdmcp.c
index b6e97c9
the XdmpcpFatal() code to use a simpler string format
instead.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
os/xdmcp.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/os/xdmcp.c b/os/xdmcp.c
index b6e97c9..374ac08 100644
--- a/os/xdmcp.c
+++ b/os/xdmcp.c
And install the header as part of the SDK, so that applications interfacing
with the libinput driver do not have to copy paste all the properties' names.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
Makefile.am | 2 +-
configure.ac | 1 +
include
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
autogen.sh | 15 +++
1 file changed, 15 insertions(+)
create mode 100755 autogen.sh
diff --git a/autogen.sh b/autogen.sh
new file mode 100755
index 000..4d3c878
--- /dev/null
+++ b/autogen.sh
@@ -0,0 +1,15 @@
+#! /bin/sh
And install the header as part of the SDK, so that applications interfacing
with the libinput driver do not have to copy paste all the properties' names.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
Makefile.am | 5 +++-
configure.ac | 4
you could drop plen and go
len = *(CARD16*)wire;
...
Will do and send an updated patch.
And there are other occurrences of swapping that will break further down the
code so this not complete yet.
___
xorg-devel@lists.x.org: X.Org development
in the buffer, use variables instead.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
xkb/xkb.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 15c7f34..b9a3ac4 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
.
To allow _GetCountedString() to run reliably more than once with swapped
clients, do not swap the data in the buffer, use a variable instead.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
xkb/xkb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xkb/xkb.c b/xkb/xkb.c
value.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
dsimple.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/dsimple.c b/dsimple.c
index 6432e13..ca746e9 100644
--- a/dsimple.c
+++ b/dsimple.c
@@ -205,6 +205,8 @@ xcb_window_t Select_Window(xcb_connection_t *dpy
to emulate a full press/release
to lock or unlock the modifier.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
hw/kdrive/ephyr/ephyr.c | 8 +++-
hw/xnest/Keyboard.c | 9 -
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr
to emulate a full press/release
to lock or unlock the modifier.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
hw/kdrive/ephyr/ephyr.c | 9 +++--
hw/xnest/Keyboard.c | 9 -
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr
dependency to avoid the problem (LDADD ought
to be enough to get the right libraries linked).
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
hw/xwayland/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/xwayland/Makefile.am b/hw/xwayland/Makefile.am
index 4e0e1bb..9945540
501 - 592 of 592 matches
Mail list logo