Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-07 Thread Keith Packard
Eric Anholt writes: > Keith Packard writes: > >> Any time the colormap is changed, the entire screen needs to be >> repainted to match. > > Revviewed-by: Eric Anholt Merrged: 9eecc9a..ae796d4 master -> master -- keith.pack...@intel.com pgprMFYaxxNwe.pgp Description: PGP signature _

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-07 Thread Eric Anholt
Keith Packard writes: > Any time the colormap is changed, the entire screen needs to be > repainted to match. Revviewed-by: Eric Anholt pgp4JvCVe4emQ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-07 Thread Keith Packard
Adam Jackson writes: > On Thu, 2014-02-06 at 19:17 -0800, Keith Packard wrote: >> Any time the colormap is changed, the entire screen needs to be >> repainted to match. >> >> Signed-off-by: Keith Packard > > Which works for kdrive, because kdrive as a base class doesn't support > more than one

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-07 Thread Adam Jackson
On Thu, 2014-02-06 at 19:17 -0800, Keith Packard wrote: > Any time the colormap is changed, the entire screen needs to be > repainted to match. > > Signed-off-by: Keith Packard Which works for kdrive, because kdrive as a base class doesn't support more than one installed colormap. I'm still not

[PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-06 Thread Keith Packard
Any time the colormap is changed, the entire screen needs to be repainted to match. Signed-off-by: Keith Packard --- hw/kdrive/ephyr/ephyr.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c index da80c95..9681273 100644 --- a/

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-06 Thread Keith Packard
Eric Anholt writes: > That appears to be what DamageReportDamage() does. (As opposed to > DamageDamageRegion(), which I suspect you were thinking of). Oh, good point. I'd forgotten all about that function. I should probably use that instead; respecting the interface and all. -- keith.pack...@

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-06 Thread Eric Anholt
Keith Packard writes: > Eric Anholt writes: > >> I expected DamageReportDamage() to be used instead, but this is safe >> because we're using DamageReportNone (and leaving the blockhandler to do >> our paint). > > I didn't want other root damage trackers to receive damage though, this > avoids th

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-06 Thread Keith Packard
Eric Anholt writes: > I expected DamageReportDamage() to be used instead, but this is safe > because we're using DamageReportNone (and leaving the blockhandler to do > our paint). I didn't want other root damage trackers to receive damage though, this avoids that. We could also expose a new per-

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-06 Thread Eric Anholt
Keith Packard writes: > Any time the colormap is changed, the entire screen needs to be > repainted to match. > > Signed-off-by: Keith Packard > --- > hw/kdrive/ephyr/ephyr.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c

[PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-06 Thread Keith Packard
Any time the colormap is changed, the entire screen needs to be repainted to match. Signed-off-by: Keith Packard --- hw/kdrive/ephyr/ephyr.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c index da80c95..73d7b87 100644 --- a/hw/k