[PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-01-03 Thread Kenneth Graunke
Mesa's implementation of glBindBuffer() checks to see if the supplied buffer name happens to be already bound. If so, it returns immediately, skipping the hash table lookup (mapping the GLuint buffer handle to the actual struct), the associated locking, and reference counting. Glamor uses a singl

Re: [PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-01-03 Thread Eric Anholt
Kenneth Graunke writes: > Mesa's implementation of glBindBuffer() checks to see if the supplied > buffer name happens to be already bound. If so, it returns immediately, > skipping the hash table lookup (mapping the GLuint buffer handle to the > actual struct), the associated locking, and refere

Re: [PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-01-04 Thread Keith Packard
Eric Anholt writes: > I think this will break glamor_xv.c and Xephyr, but I'm definitely in > favor of just making those explicitly bind their VBO state instead (or > maybe just use the same VBO if we can). I think we're going to rework a bunch of this code when we switch to vertex arrays anyway

Re: [PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-01-04 Thread Kenneth Graunke
On Sunday, January 04, 2015 04:47:49 PM Keith Packard wrote: > Eric Anholt writes: > > > I think this will break glamor_xv.c and Xephyr, but I'm definitely in > > favor of just making those explicitly bind their VBO state instead (or > > maybe just use the same VBO if we can). > > I think we're

Re: [PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-01-04 Thread Keith Packard
Kenneth Graunke writes: > That's true. I should probably just resurrect your Xephyr VAO patch, and > extend it for the rest of Glamor as well. Yeah, would be good as that's required for 3.0 core context support. Note that most of the VAO work is actually in the Render extension drawing code, an

Re: [PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-01-05 Thread Eric Anholt
Keith Packard writes: > Kenneth Graunke writes: > >> That's true. I should probably just resurrect your Xephyr VAO patch, and >> extend it for the rest of Glamor as well. > > Yeah, would be good as that's required for 3.0 core context > support. Note that most of the VAO work is actually in the

Re: [PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-02-04 Thread Eric Anholt
Kenneth Graunke writes: > Mesa's implementation of glBindBuffer() checks to see if the supplied > buffer name happens to be already bound. If so, it returns immediately, > skipping the hash table lookup (mapping the GLuint buffer handle to the > actual struct), the associated locking, and refere