Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread walter harms
Am 08.07.2011 21:10, schrieb Kees Cook: > Hi, > > On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote: >> On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: >>> This replaces sprintf with snprintf to avoid crashing when creating >>> various labels. >>> >>> https://bugs.launchpad

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Julien Cristau
On Fri, Jul 8, 2011 at 12:10:31 -0700, Kees Cook wrote: > I've been told in the past not use asprintf because it isn't portable, Right. > and I do not find XtAsprintf in the include files: > > ../xclipboard/xclipboard.c:337:2: warning: implicit declaration of function > ‘XtAsprintf’ > ... > .

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Kees Cook
Hi, On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote: > On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: > > This replaces sprintf with snprintf to avoid crashing when creating > > various labels. > > > > https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 > > >

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Julien Cristau
On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: > This replaces sprintf with snprintf to avoid crashing when creating > various labels. > > https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 > > Signed-off-by: Kees Cook > --- > xclipboard.c |3 ++- > xcutsel.c|

Re: [PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Alan Coopersmith
On 07/ 8/11 11:01 AM, Kees Cook wrote: > This replaces sprintf with snprintf to avoid crashing when creating > various labels. > > https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 > > Signed-off-by: Kees Cook > --- > xclipboard.c |3 ++- > xcutsel.c|4 ++-- > 2 files c

[PATCH] xclipboard: avoid overflow crash when building labels

2011-07-08 Thread Kees Cook
This replaces sprintf with snprintf to avoid crashing when creating various labels. https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 Signed-off-by: Kees Cook --- xclipboard.c |3 ++- xcutsel.c|4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/xclip