Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-20 Thread Olivier Fourdan
Hi Jasper, On 20/02/15 18:05, Olivier Fourdan wrote: Hi Sorry, I probably didn't express myself correctly here. What I've been trying to say is: - The patch does not work for me, it makes things worse than before, the X window field is not consistent depending on where the event occurs. So i

Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-20 Thread Olivier Fourdan
Hi Sorry, I probably didn't express myself correctly here. What I've been trying to say is: - The patch does not work for me, it makes things worse than before, the X window field is not consistent depending on where the event occurs. So it works with some menus, but other mouse events won'

Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-20 Thread Jasper St. Pierre
On Fri, Feb 20, 2015 at 1:47 AM, Olivier Fourdan wrote: > Hi Jasper, > > I was working on the same issue (https://bugzilla.redhat.com/ > show_bug.cgi?id=1188289) but did not think about translating the > coordinates! > > I applied your patch along with the patch for mutter (on mutter 3.14.3 as >

Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-20 Thread Jasper St. Pierre
The guard window is supposed to be capturing input. That's the whole point. We stack windows below the guard window when minimizing them so that input won't go to them, but we can still show live-previews for them in Alt-Tab. On Fri, Feb 20, 2015 at 4:57 AM, Daniel Stone wrote: > Hi, > > On 20

Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-20 Thread Daniel Stone
Hi, On 20 February 2015 at 09:47, Olivier Fourdan wrote: > It works, as long as the window is not moved, as soon as the toplevel window > is moved, the translated coordinates seem correct but the window returned by > miSpriteTrace() is not, e.g. I get the "mutter guard window" instead of the > ac

Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-20 Thread Olivier Fourdan
On 20/02/15 10:47, Olivier Fourdan wrote: [...] +cs = GetCompScreen(screen); +if (cs->pOverlayWin && cs->pOverlayWin->mapped) { Although GetCompScreen() is actually a macro which calls dixLookupPrivate() so maybe not a good idea to do that for every every pointer event. Che

Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-20 Thread Olivier Fourdan
Hi Jasper, I was working on the same issue (https://bugzilla.redhat.com/show_bug.cgi?id=1188289) but did not think about translating the coordinates! I applied your patch along with the patch for mutter (on mutter 3.14.3 as found in F21) not to map the cow but that does not work very well.

[PATCH] xwayland-input: Don't assume all input is children of the focused window

2015-02-18 Thread Jasper St. Pierre
Some toolkits implement comboboxes or menus or other things through O-R windows, which aren't children of the focused window. In order to properly get input on them during grab conditions, we need to trace the whole input tree, not just the focused window down. Signed-off-by: Jasper St. Pierre --