[PATCH 28/44] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print _X_ATTRIBUTE_PRINTF

2013-12-11 Thread Keith Packard
And fix resulting warnings. Signed-off-by: Keith Packard Reviewed-by: Ian Romanick --- hw/xfree86/dri/dri.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c index 6292e87..056fdfc 100644 --- a/hw/

Re: [PATCH 28/44] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print _X_ATTRIBUTE_PRINTF

2013-12-13 Thread Adam Jackson
On Wed, 2013-12-11 at 12:24 -0800, Keith Packard wrote: > And fix resulting warnings. > > Signed-off-by: Keith Packard > Reviewed-by: Ian Romanick Just tried to build this and got: dri.c: In function 'DRILock': dri.c:2228:46: error: cast to pointer from integer of different size [-Werror=int-

Re: [PATCH 28/44] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print _X_ATTRIBUTE_PRINTF

2013-12-13 Thread Mark Kettenis
> From: Adam Jackson > Date: Fri, 13 Dec 2013 15:42:56 -0500 > > On Wed, 2013-12-11 at 12:24 -0800, Keith Packard wrote: > > And fix resulting warnings. > > > > Signed-off-by: Keith Packard > > Reviewed-by: Ian Romanick > > Just tried to build this and got: > > dri.c: In function 'DRILock':

Re: [PATCH 28/44] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print _X_ATTRIBUTE_PRINTF

2013-12-13 Thread Keith Packard
Adam Jackson writes: > Hooray for LP64. These need to be (void *) (uintptr_t) foo. Yeah, I changed all of the handle casts to add (uintptr_t) and pushed an updated branch. -- keith.pack...@intel.com pgpCtIosWHNjA.pgp Description: PGP signature ___

Re: [PATCH 28/44] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print _X_ATTRIBUTE_PRINTF

2013-12-13 Thread Keith Packard
Mark Kettenis writes: > It makes much more sense to consistently print drm_context_t as %u or > 0x%x. It's an unsigned int on both OpenBSD and Linux, so I suspect > that's the case everywhere. I'd like to keep the warning patches separate from semantic changes like this; I think it's easier to

Re: [PATCH 28/44] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print _X_ATTRIBUTE_PRINTF

2013-12-13 Thread Mouse
>> Hooray for LP64. These need to be (void *) (uintptr_t) foo. Actually, I suspect there is a semantic bug here. If the integers are smaller than pointers, they don't have as much information content as pointers, so forcibly shoehorning them into pointers with the help of additional casts is alm