Re: [PATCH modular] Per-component configure options

2012-01-25 Thread Alan Coopersmith
On 01/18/12 01:37 PM, Trevor Woerner wrote: Hi Alan, Thanks for the review. (Please note that I'm purposefully being overly descriptive to help others on the list who might be new to the build.sh script) And thanks for that - it helps me and hopefully others. By default build.sh will run th

Re: [PATCH modular] Per-component configure options

2012-01-19 Thread Trevor Woerner
Hi Gaetan, Thanks for reviewing my patch! On Wed, Jan 18, 2012 at 7:49 PM, Gaetan Nadon wrote: > On 12-01-16 06:22 PM, Trevor Woerner wrote: >> @@ -1009,9 +1017,15 @@ process_module_file() { >>           continue >>       fi >> >> -     module=`echo $line | cut -d'/' -f1` >> -     component=`ech

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Gaetan Nadon
On 12-01-16 06:22 PM, Trevor Woerner wrote: > @@ -1009,9 +1017,15 @@ process_module_file() { > continue > fi > > - module=`echo $line | cut -d'/' -f1` > - component=`echo $line | cut -d'/' -f2` > - build $module $component > + module=`echo $line | cut -d' ' -f1 | c

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Trevor Woerner
On Wed, Jan 18, 2012 at 4:53 PM, Peter Hutterer wrote: > also, while it is overkill I heartily recommend asciidoc as man > page source since I suspect few people will install it and thus have it in > their manpath - asciidoc at least makes the man page human-readable without > special tools. "Ove

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Peter Hutterer
On Wed, Jan 18, 2012 at 02:32:48PM -0500, Gaetan Nadon wrote: > On 12-01-16 06:22 PM, Trevor Woerner wrote: > > From: Trevor Woerner > > > > Allow a user to specify per-component configure options by > > providing them in the --modfile file. Any text remaining on > > a line following a given modul

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Trevor Woerner
Hi Alan, Thanks for the review. (Please note that I'm purposefully being overly descriptive to help others on the list who might be new to the build.sh script) On Wed, Jan 18, 2012 at 4:09 PM, Alan Coopersmith wrote: > However, I wasn't quite clear on how to use it - perhaps because > I've fail

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Trevor Woerner
Thanks for the review Gaetan! I had completely forgot about the CONFFLAGS option. I'll start again and integrate the two (or could this be considered a replacement?). I'll also provide more usage documentation. ___ xorg-devel@lists.x.org: X.Org developm

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Alan Coopersmith
On 01/18/12 08:14 AM, Trevor Woerner wrote: I'm surprised nobody seems interested in this patch, I would have thought a general mechanism to provide per-component configuration options would have been a feature for which people would have been waiting; especially the distribution maintainers. A

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Gaetan Nadon
On 12-01-16 06:22 PM, Trevor Woerner wrote: > From: Trevor Woerner > > Allow a user to specify per-component configure options by > providing them in the --modfile file. Any text remaining on > a line following a given module/component is assumed to be > options which will be passed to the configu

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Gaetan Nadon
On 12-01-18 11:14 AM, Trevor Woerner wrote: > I'm surprised nobody seems interested in this patch, I would have > thought a general mechanism to provide per-component configuration > options would have been a feature for which people would have been > waiting; especially the distribution maintainer

Re: [PATCH modular] Per-component configure options

2012-01-18 Thread Trevor Woerner
I'm surprised nobody seems interested in this patch, I would have thought a general mechanism to provide per-component configuration options would have been a feature for which people would have been waiting; especially the distribution maintainers. I was trying to perform a build from the git rep

[PATCH modular] Per-component configure options

2012-01-16 Thread Trevor Woerner
From: Trevor Woerner Allow a user to specify per-component configure options by providing them in the --modfile file. Any text remaining on a line following a given module/component is assumed to be options which will be passed to the configuration script. Signed-off-by: Trevor Woerner --- bui