Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-19 Thread Peter Hutterer
On Tue, Oct 19, 2010 at 04:59:47PM +0200, walter harms wrote: > > > Mikhail Gusarov schrieb: > > Twas brillig at 10:07:23 19.10.2010 UTC+02 when wha...@bfs.de did gyre and > > gimble: > > > > wh> malloc will return (void *) so there is no need to cast. > > wh> i do not know xmalloc() but i se

Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-19 Thread Peter Hutterer
On Tue, Oct 19, 2010 at 10:07:23AM +0200, walter harms wrote: > > > Peter Hutterer schrieb: > > On Sun, Oct 17, 2010 at 09:25:56PM -0400, Trevor Woerner wrote: > >> From: Trevor Woerner > >> > >> Replace calls to deprecated functions (Xfree(), Xcalloc(), Xmalloc(), etc) > >> with calls to standa

Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-19 Thread walter harms
Mikhail Gusarov schrieb: > Twas brillig at 10:07:23 19.10.2010 UTC+02 when wha...@bfs.de did gyre and > gimble: > > wh> malloc will return (void *) so there is no need to cast. > wh> i do not know xmalloc() but i see no check for OOM condition. > wh> instead of removing xmalloc() it would be

Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-19 Thread Mikhail Gusarov
Twas brillig at 12:18:06 19.10.2010 UTC+02 when jcris...@debian.org did gyre and gimble: >> wh> malloc will return (void *) so there is no need to cast. >> wh> i do not know xmalloc() but i see no check for OOM condition. >> wh> instead of removing xmalloc() it would be more useful to follo

Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-19 Thread Julien Cristau
On Tue, Oct 19, 2010 at 14:03:54 +0400, Mikhail Gusarov wrote: > > Twas brillig at 10:07:23 19.10.2010 UTC+02 when wha...@bfs.de did gyre and > gimble: > > wh> malloc will return (void *) so there is no need to cast. > wh> i do not know xmalloc() but i see no check for OOM condition. > wh> i

Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-19 Thread Mikhail Gusarov
Twas brillig at 10:07:23 19.10.2010 UTC+02 when wha...@bfs.de did gyre and gimble: wh> malloc will return (void *) so there is no need to cast. wh> i do not know xmalloc() but i see no check for OOM condition. wh> instead of removing xmalloc() it would be more useful to follow wh> XtMalloc()

Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-19 Thread walter harms
Peter Hutterer schrieb: > On Sun, Oct 17, 2010 at 09:25:56PM -0400, Trevor Woerner wrote: >> From: Trevor Woerner >> >> Replace calls to deprecated functions (Xfree(), Xcalloc(), Xmalloc(), etc) >> with calls to standard dynamic memory functions (free(), calloc(), malloc(), >> etc) in driver cod

Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-17 Thread Peter Hutterer
On Sun, Oct 17, 2010 at 09:25:56PM -0400, Trevor Woerner wrote: > From: Trevor Woerner > > Replace calls to deprecated functions (Xfree(), Xcalloc(), Xmalloc(), etc) > with calls to standard dynamic memory functions (free(), calloc(), malloc(), > etc) in driver code. > > Signed-off-by: Trevor Wo

[PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

2010-10-17 Thread Trevor Woerner
From: Trevor Woerner Replace calls to deprecated functions (Xfree(), Xcalloc(), Xmalloc(), etc) with calls to standard dynamic memory functions (free(), calloc(), malloc(), etc) in driver code. Signed-off-by: Trevor Woerner --- src/jstk.c |8 src/jstk_key.c |8