Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-19 Thread Egbert Eich
On Thu, Sep 19, 2013 at 10:52:52AM -0400, Mouse wrote: > [PATCH xauth] Look for FamilyLocal if inet or inet6 address is loopback > >> If the address came from resolving a name, as in "xhost +localhost", > >> then I like this. But if the address was specified directly, as in > >> "xhost +::1",

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-19 Thread Mouse
[PATCH xauth] Look for FamilyLocal if inet or inet6 address is loopback >> If the address came from resolving a name, as in "xhost +localhost", >> then I like this. But if the address was specified directly, as in >> "xhost +::1", then I'd go so far as to say that adding FamilyLocal, >> or, w

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-19 Thread Egbert Eich
On Wed, Sep 18, 2013 at 06:26:21PM -0400, Mouse wrote: > >> [PATCH xauth] Look for FamilyLocal if inet or inet6 address is loopback > > Based solely on this description, I'd say this is a "maybe". > > If the address came from resolving a name, as in "xhost +localhost", > then I like this. But if

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Dr. Tilmann Bubeck
Hi Egbert, I developed a patch for xauth to fix some nasty problems. I first asked Alan to apply the patch but he had not enough time to do it. So after some time he gave me access to Xorg as a commiter (I certainly did not do this on my own). So my plan was to look after xauth, which I stil

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Mouse
>> [PATCH xauth] Look for FamilyLocal if inet or inet6 address is loopback Based solely on this description, I'd say this is a "maybe". If the address came from resolving a name, as in "xhost +localhost", then I like this. But if the address was specified directly, as in "xhost +::1", then I'd g

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Dr. Tilmann Bubeck
Egbert, thanks a lot! I will try to look at them during the weekend. Kind regards, Tilmann On 09/18/2013 11:32 PM, Egbert Eich wrote: Hi Tilman, On Wed, Sep 18, 2013 at 10:28:14PM +0200, Dr. Tilmann Bubeck wrote: Hi Egbert, I developed a patch for xauth to fix some nasty problems. I first

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Egbert Eich
Hi Tilman, On Wed, Sep 18, 2013 at 10:28:14PM +0200, Dr. Tilmann Bubeck wrote: > Hi Egbert, > > I developed a patch for xauth to fix some nasty problems. I first asked Alan > to apply the patch but he had not enough time to do it. So after some time > he gave me access to Xorg as a commiter (I c

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Alan Coopersmith
When there were complaints last year that no one was integrating xauth patches since there was no maintainer, he volunteered to maintain it, so I let him try. http://lists.x.org/archives/xorg-devel/2012-October/034079.html http://lists.x.org/archives/xorg-devel/2012-December/034803.html (Yes, we

Re: [REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-09-18 Thread Egbert Eich
Hi! On August 14 I've reposted three patches for xauth to this mailing list. I did so, because I had discovered that a 'Dr. Tilmann Bubeck' has added himself as maintainer of the xauth package to the xorg/doc/xorg-docs/MAINTAINERS file on Jan. 22 2013 - considering the change frequency of this fi

[REPOST PATCH xauth] Don't crash when running past the end of the chain

2013-08-14 Thread Egbert Eich
Running past the end of the chain would cause a SEGV. Signed-off-by: Egbert Eich --- process.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/process.c b/process.c index 166b769..a9466a7 100644 --- a/process.c +++ b/process.c @@ -1280,8 +1280,11 @@ remove_entry(const