Re: [PATCH]libXt-1.0.8/src/Keyboard.c fix NULL-pointer check

2010-10-24 Thread Matt Turner
On Sun, Oct 24, 2010 at 8:42 AM, walter harms wrote: > Alan Coopersmith schrieb: >> While we're accommodating with one-off patches in weird formats, if you're >> going >> to be sending series, or plan on continuing to send patches, you need to >> start >> using git to create them, working of the

Re: [PATCH]libXt-1.0.8/src/Keyboard.c fix NULL-pointer check

2010-10-24 Thread walter harms
gPatches > http://who-t.blogspot.com/2009/12/on-commit-messages.html > > -alan- i will try to make this work for the next patches. re, wh > walter harms wrote: >> _XtGetPerWidgetInput() can return NULL, move check so that >> pwi->queryEventDescendant and friends are co

Re: [PATCH]libXt-1.0.8/src/Keyboard.c fix NULL-pointer check

2010-10-22 Thread Alan Coopersmith
queryEventDescendant and friends are covered > > re, > wh > > Signed-off-by: wha...@bfs.de > > > --- libXt-1.0.8/src/Keyboard.c.org2010-10-20 20:26:05.0 +0200 > +++ libXt-1.0.8/src/Keyboard.c2010-10-20 20:40:35.0 +0200 > @@

[PATCH]libXt-1.0.8/src/Keyboard.c fix NULL-pointer check

2010-10-22 Thread walter harms
_XtGetPerWidgetInput() can return NULL, move check so that pwi->queryEventDescendant and friends are covered re, wh Signed-off-by: wha...@bfs.de --- libXt-1.0.8/src/Keyboard.c.org 2010-10-20 20:26:05.0 +0200 +++ libXt-1.0.8/src/Keyboard.c 2010-10-20 20:40:35.0 +0

[PATCH]libXt-1.0.8/src/TMstate.c avoid possible NULL reference

2010-10-22 Thread walter harms
context->matches could become NULL, add check re, wh Signed-off-by: wha...@bfs.de --- libXt-1.0.8/src/TMstate.c.org 2010-10-20 22:15:07.0 +0200 +++ libXt-1.0.8/src/TMstate.c 2010-10-20 22:35:35.0 +0200 @@ -720,10 +720,13 @@ XtRealloc((char *)cont

[PATCH]libXt-1.0.8/src/TMparse.c: avoid possible NULL reference

2010-10-22 Thread walter harms
*Event could become NULL add check re, wh Signed-off-by: wha...@bfs.de --- libXt-1.0.8/src/TMparse.c.org 2010-10-20 22:04:30.0 +0200 +++ libXt-1.0.8/src/TMparse.c 2010-10-20 22:04:44.0 +0200 @@ -1291,10 +1291,15 @@ *event = timerEventRec

[PATCH]libXt-1.0.8/src/Resources.c avoid possible NULL reference

2010-10-22 Thread walter harms
value.addr could become NULL, add check re, wh Signed-off-by: wha...@bfs.de --- libXt-1.0.8/src/Resources.c.org 2010-09-22 22:37:23.0 +0200 +++ libXt-1.0.8/src/Resources.c 2010-10-20 21:37:01.0 +0200 @@ -971,8 +971,11 @@ if (cache_ptr && *c

Re: libXt-1.0.8: fix dereferenc in TMprint.c

2010-09-23 Thread Alan Coopersmith
walter harms wrote: > NTL did you see the first patch with the array overflow ? Yes, but I chose not to push it yet since Jeremy pointed out it wasn't correct. The dereference fix was easier to see it was correct. -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread Pat Kane
> setting the limit to i=9 would fix that. But then the line (void) memmove((char*)par, (char*)params, i * sizeof(String) ); would be wrong since it would move nine instead of ten things. ___ xorg-devel@lists.x.org: X.Org development Archives: http:

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread Jeremy Huddleston
On Sep 23, 2010, at 11:37, walter harms wrote: > > > Pat Kane schrieb: >> In the original code if 'i' is equal to 10 then the line >> (void) memmove((char*)par, (char*)params, i * sizeof(String) ); >> moves ten things, which is okay. >> >> The next line: >> bzero( &par[i], (10-i) * sizeof(S

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread walter harms
Pat Kane schrieb: > In the original code if 'i' is equal to 10 then the line >(void) memmove((char*)par, (char*)params, i * sizeof(String) ); > moves ten things, which is okay. > > The next line: >bzero( &par[i], (10-i) * sizeof(String) ); > moves zero things to a bad address, which is p

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread Pat Kane
In the original code if 'i' is equal to 10 then the line (void) memmove((char*)par, (char*)params, i * sizeof(String) ); moves ten things, which is okay. The next line: bzero( &par[i], (10-i) * sizeof(String) ); moves zero things to a bad address, which is probably okay, but I bet some code

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread Jeremy Huddleston
onally i prefer > > i%=10; > par=Xtmalloc(i*sizeof(String)); > > but i wanted to fix the overflow first. > > the point i to not understand what do they copy the pointer at all ? > they could yjust do the fprintf() and ready .. > > > re, > wh > > >

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread walter harms
and change to printf below into a loop > Barry > >> re, >> wh >> >> >> --- libXt-1.0.8/src/Error.c.org 2010-09-21 23:23:00.0 +0200 >> +++ libXt-1.0.8/src/Error.c 2010-09-21 23:24:03.0 +0200 >> @@ -257,7 +257,7 @@

Re: libXt-1.0.8: fix dereferenc in TMprint.c

2010-09-23 Thread walter harms
Alan Coopersmith schrieb: > walter harms wrote: >> hi list; >> the current codes checks for >> eventWidget == NULL after accessing >> eventWidget->core.tm.proc_table >> >> now it checks for eventWidget before access eventWidget->core.tm.proc_table. > > Thanks for the fix - it's been pushed to g

Re: libXt-1.0.8: fix dereferenc in TMprint.c

2010-09-22 Thread Alan Coopersmith
walter harms wrote: > hi list; > the current codes checks for > eventWidget == NULL after accessing > eventWidget->core.tm.proc_table > > now it checks for eventWidget before access eventWidget->core.tm.proc_table. Thanks for the fix - it's been pushed to git master now for the upcoming release

Re: libXt-1.0.8:fix possible array averflow

2010-09-22 Thread Jeremy Huddleston
ne as is. On Sep 22, 2010, at 10:18, walter harms wrote: > > hi List, > the code checks the upperlimit to 10 while the upperlimit is actualy 9. > > The org. patch is attacehd since i guess the tabs will be mangeld. > > re, > wh > > Signed-off-by: walter harms >

libXt-1.0.8:fix possible array averflow

2010-09-22 Thread walter harms
hi List, the code checks the upperlimit to 10 while the upperlimit is actualy 9. The org. patch is attacehd since i guess the tabs will be mangeld. re, wh Signed-off-by: walter harms --- libXt-1.0.8/src/Error.c.org 2010-09-21 23:23:00.0 +0200 +++ libXt-1.0.8/src/Error.c 2010-09

libXt-1.0.8: fix dereferenc in TMprint.c

2010-09-22 Thread walter harms
harms --- libXt-1.0.8/src/TMprint.c.org 2010-09-21 23:42:08.0 +0200 +++ libXt-1.0.8/src/TMprint.c 2010-09-21 23:44:44.0 +0200 @@ -782,12 +782,16 @@ PrintRec stackPrints[STACKPRINTSIZE]; PrintRec *prints; TMShortCardnumPrints, max

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-22 Thread Jeremy Huddleston
, >> the code checks the upperlimit to 10 while the upperlimit is actualy 9. >> >> re, >> wh >> >> >> --- libXt-1.0.8/src/Error.c.org 2010-09-21 23:23:00.0 +0200 >> +++ libXt-1.0.8/src/Error.c 2010-09-21 23:24:03.0 +0200 >>

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-22 Thread Jeremy Huddleston
the upperlimit to 10 while the upperlimit is actualy 9. > > re, > wh > > > --- libXt-1.0.8/src/Error.c.org 2010-09-21 23:23:00.0 +0200 > +++ libXt-1.0.8/src/Error.c 2010-09-21 23:24:03.0 +0200 > @@ -257,7 +257,7 @@ > */ >Ca

Re: libXt-1.0.8

2010-08-24 Thread Pedro Parra
4 file but It is not there. So I reinstalled the pkg-config-0.23. ./configure --prefix=/usr make make install then I: autoreconf the libXt-1.0.8 this thime no warnings were diplayed I ran: ./configure --prefix=/usr make make install now when I run: pkg-config --modversion xt I get: 1.0.8

Re: libXt-1.0.8

2010-08-24 Thread Gaetan Nadon
On Mon, 2010-08-23 at 17:59 -0500, Pedro Parra wrote: > It seems as if the pkgconfig packages is not installed but I believe > it is installed, since I can type pkg-config --help and I get the help > menu. I can see all the .pc files from different libraries > under /usr/lib/pkgconfig > Perhaps

libXt-1.0.8

2010-08-23 Thread Pedro Parra
Hi I've been trying to compile the libXt-1.0.8 library for my embedded system but keep getting the same error message. I downloaded the tar.gz archive and I run ./autogen.sh I get the next error message: ./configure: line 12618: syntax error near unexpected token 'XT, ' ./config