[PATCH xserver v2 20/22] xwayland: Add fallback timer for msc counting

2018-02-28 Thread Roman Gilg
When the compositor is not sending frame callbacks while we still wait on buffer release events fake a continuous msc counter with a timer. Having this timer is a prerequisite for queuing events. Signed-off-by: Roman Gilg <subd...@gmail.com> --- hw/xwayland/xwayland-present.

[PATCH xserver v2 19/22] xwayland: Preliminary support for Present's new window flip mode

2018-02-28 Thread Roman Gilg
ake use of this functionality Xwayland must run rootless and with Glamor/GBM. Signed-off-by: Roman Gilg <subd...@gmail.com> --- hw/xwayland/Makefile.am| 1 + hw/xwayland/meson.build| 1 + hw/xwayland/xwayland-present.c | 365 + hw

[PATCH xserver v2 21/22] xwayland: Implement queuing present vblanks

2018-02-28 Thread Roman Gilg
Queue present events to msc values. Fake msc events with a refresh rate of about 60fps when flips are not possible. When flips are executed rely on frame callbacks with a slow updating timer as fallback. This is important for applications, that want to limit their framerate. Signed-off-by: Roman

[PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

2018-02-28 Thread Roman Gilg
to an erroneous 64 to 32bit conversion. The sample client, that triggers this behavior, is the Steam client. Signed-off-by: Roman Gilg <subd...@gmail.com> --- hw/xwayland/xwayland-present.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/xwayland/xwayland-present.c b/hw/xwayland/xw

[PATCH xserver v2 18/22] xwayland: Add arguments to glamor_pixmap_get_wl_buffer

2018-02-28 Thread Roman Gilg
Add arguments to give the caller more information and control over the creation of a wl_buffer with GBM, in particular let the caller determine the size of the buffer. Signed-off-by: Roman Gilg <subd...@gmail.com> --- hw/xwayland/xwayland-glamor.c | 19 +++ hw/xwayland/xway

[PATCH xserver v2 16/22] present: Add cleanups for window flip mode

2018-02-28 Thread Roman Gilg
Make sure that vblanks and windows get cleaned up correctly in window flip mode. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present_screen.c | 33 - present/present_vblank.c | 2 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff

[PATCH xserver v2 02/22] present: Preliminary internal flip mode API

2018-02-28 Thread Roman Gilg
Add some basic function hooks to our future present-internal flip mode API, that will allow us to share functionality in between modes and move more code in separate files. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present_priv.h | 26 +++--- p

[PATCH xserver v2 00/22] Per window flips in Present with support for them in Xwayland

2018-02-28 Thread Roman Gilg
This revision provides changes requested by Michel Dänzer. In particular flips without copies in window flip mode are now possible and clients can queue flips on Xwayland. ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH xserver v2 01/22] present: Move screen flip functionality in separate file

2018-02-28 Thread Roman Gilg
As a preperation for future flip mode alternatives move most of the functionality from 'present.c' into a separate file. Leave some functions needed by future other flip modes in 'present.c'. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/Makefile.am| 1 + present/meson

[PATCH xserver v2 04/22] present: Add flip mode API hooks for several functions

2018-02-28 Thread Roman Gilg
Add 'queue_vblank', 'flush' and 're_execute' hooks, that are supposed to be shared with other flip modes. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present_priv.h | 12 present/present_scmd.c | 3 +++ 2 files changed, 15 insertions(+) diff --git a/p

[PATCH xserver v2 07/22] present: Move timings adjustment in common part of flip mode API

2018-02-28 Thread Roman Gilg
To reduce future code duplication refactor timings adjustment out as a separate function. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present.c | 38 ++ present/present_priv.h | 7 +++ present/present_scmd.

[PATCH xserver v2 03/22] present: Move vblank functionality in seperate file

2018-02-28 Thread Roman Gilg
With the new internal flip mode API move vblank creation and so on into a seperate file, such that it can be shared between flip modes. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/Makefile.am | 3 +- present/meson.build | 1 + present/present_priv.h

[PATCH xserver v2 08/22] present: Add more hooks to internal flip mode API

2018-02-28 Thread Roman Gilg
Add hooks to query caps, get crtcs, abort vblanks and destroy a flip. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present.c| 28 present/present_priv.h | 33 + present/present_scmd.c

[PATCH xserver v2 06/22] present: Add flip mode API hook for present_pixmap

2018-02-28 Thread Roman Gilg
Make present_pixmap a common function callable by any flip mode. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present.c | 57 ++ present/present_priv.h | 68 +++--- present/present_scmd.

[PATCH xserver v2 12/22] present: Adapt flip mode API hooks for window flip mode

2018-02-28 Thread Roman Gilg
Flipping pixmaps per window needs additional arguments in the flip mode API. Add these as preperation for window flip mode. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present_execute.c | 2 ++ present/present_priv.h| 10 +++--- present/present_scmd.c

[PATCH xserver v2 05/22] present: Refactor execute in separate file

2018-02-28 Thread Roman Gilg
To be shared by multiple flip modes, refactor execute functionality, such that logical chunks can go in new separate file. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/Makefile.am | 1 + present/meson.build | 1 + present/present_execute.c

[PATCH xserver v2 09/22] present: Refactor present_screen_init

2018-02-28 Thread Roman Gilg
To initialize easily different flip modes, refactor 'present_screen_init'. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present_screen.c | 46 +- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/present/present_scre

[PATCH xserver v2 10/22] present: Add present_window_priv properties for window flip mode

2018-02-28 Thread Roman Gilg
For window flip mode data about flips needs to be stored per window. Add properties to 'present_window_priv' and initialize them on creation. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present_priv.h | 10 ++ present/present_screen.c | 6 ++ 2 files chang

[PATCH xserver v2 17/22] present: Add exported init function of window flip mode

2018-02-28 Thread Roman Gilg
Allow drivers now to initialize window flip mode. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present.h| 2 ++ present/present_screen.c | 23 ++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/present/present.h b/present/present.h

[PATCH xserver v2 13/22] present: Add driver facing window flip mode hooks

2018-02-28 Thread Roman Gilg
To enable special functionality of window flips introduce for window flips a separate set of driver facing function hooks. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present.h | 43 +++ present/present_priv.h | 1 + 2 files chang

[PATCH xserver v2 15/22] present: In window flip mode report damage on flip to driver

2018-02-28 Thread Roman Gilg
Calculate damage before trying to flip and report it to the driver. This allows drivers to optimize their rendering. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present.h | 3 ++- present/present_wnmd.c | 24 +--- 2 files changed, 15 insertions(

[PATCH xserver v2 11/22] present: Add flip_idler vblank property

2018-02-28 Thread Roman Gilg
Introduce vblank property for flip modes, that demand explicite allowance by the driver for vblanks to become idle. Signed-off-by: Roman Gilg <subd...@gmail.com> --- present/present_priv.h | 1 + present/present_vblank.c | 1 + 2 files changed, 2 insertions(+) diff --git a/p

Re: [PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

2018-02-28 Thread Roman Gilg
On Wed, Feb 28, 2018 at 6:43 PM, Michel Dänzer wrote: > I'm unable to reproduce the issue you described with Steam (without this > patch series applied). I'd really like to know where the bogus target > MSC values you're seeing are coming from. What are the values of the >

Re: xserver 1.20 RC1 tomorrow

2018-02-27 Thread Roman Gilg
On Tue, Feb 27, 2018 at 10:59 PM, Adam Jackson wrote: > 4) https://patchwork.freedesktop.org/series/37274/ > Per-window flips for Xwayland. No xfree86 changes. Michel gave me feedback on my patches in the last weeks and I did changes to some parts because of that. I planned on

Re: [PATCH xserver] xwayland: use wl_surface_damage_buffer

2018-11-07 Thread Roman Gilg
On Tue, Nov 6, 2018 at 7:50 AM Simon Ser wrote: > > On Monday, November 5, 2018 3:24 PM, Pekka Paalanen > wrote: > > I don't think it's a good idea to break Xwayland completely on > > compositors that don't implement wl_surface version 4 or greater. > > > > It would make sense to bind

Re: [PATCH xserver 1/2] present: cancel flip on reparenting

2018-10-03 Thread Roman Gilg
I'm a bit unsure on that one. I thought there is no cleanup code necessary in Present on a reparent because in theory the current Present code alone allows clients to flip arbitrary many child windows to a certain parent window as long as they have the same dimension as the parent. Of course a

Re: [RFC PATCH xserver] xwayland: Avoid assert failure in flips_stop()

2018-09-21 Thread Roman Gilg
Great detailed analysis in the backtrace! :) What confused me at first was that the present_wnmd_flips_stop function is called at all in this state because it should only be called when at least one flip has been done and in this case xwl_window->present_window must have been set to the

Re: [PATCH] Xwayland: fix output changes not getting applied in some, cases

2019-04-22 Thread Roman Gilg
On Mon, Apr 22, 2019 at 1:30 PM Ferdi265 wrote: > > Hello, > > I investigated a bug I encountered while using the Sway Compositor and > traced it back to some behaviour in Xwayland: > > The xdg_output and wl_output events are handled in such a way that > output changes (e.g. position) sometimes

Re: Individuals interested in VESA memberships?

2019-11-03 Thread Roman Gilg
On Fri, Nov 1, 2019 at 9:06 PM Lyude Paul wrote: > > Hi! Recently I've been working with the rest of the X.Org board to try to get > X.org access to VESA memberships so that contributors that don't have an > employer who is able/willing to join VESA can potentially get access to the > various

Re: libXfont2 strlcat/strlcpy patch

2019-11-03 Thread Roman Gilg
On Wed, Oct 23, 2019 at 5:33 PM Alan Coopersmith wrote: > > On 10/23/19 12:48 AM, Michael Joost wrote: > > Hi Alan, > > > > regarding your recent patch in xorg/libXfont2 (strlcat/strlcpy fallbacks) I > > ran into a problem on Linux while having libbsd installed. The configure > > correctly

Re: libXfont2 strlcat/strlcpy patch

2019-12-06 Thread Roman Gilg
On Wed, Nov 20, 2019 at 1:53 AM Guillem Jover wrote: > > Hi! > > On Sun, 2019-11-03 at 18:08:00 +0100, Roman Gilg wrote: > > On Wed, Oct 23, 2019 at 5:33 PM Alan Coopersmith wrote: > > > On 10/23/19 12:48 AM, Michael Joost wrote: > > > > regarding your

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-18 Thread Roman Gilg
On Wed, Mar 11, 2020 at 8:21 PM Jason Ekstrand wrote: > > On Wed, Mar 11, 2020 at 12:31 PM Jason Ekstrand wrote: > > > > All, > > > > Sorry for casting such a broad net with this one. I'm sure most people > > who reply will get at least one mailing list rejection. However, this > > is an issue

The Compositor Modules are released, the modular C++ library for writing Wayland compositors

2024-03-06 Thread Roman Gilg
I'm happy to announce the first publicly available release of The Compositor Modules, the modular C++ library to easily write a Wayland compositor. The release is available on GitHub. [1] You can read the full announcement with more details about the library exclusively on Phoronix. [2] The goal

<    1   2