[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-07-01 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049566#comment-14049566 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- bq. Talked with Vinod offlin

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043684#comment-14043684 ] Hudson commented on YARN-2074: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1812 (See [htt

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043501#comment-14043501 ] Hudson commented on YARN-2074: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1785 (See [https://

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1404#comment-1404 ] Hudson commented on YARN-2074: -- FAILURE: Integrated in Hadoop-Yarn-trunk #594 (See [https://b

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-24 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042285#comment-14042285 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- Tx for the reviews [~leftnot

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042253#comment-14042253 ] Hudson commented on YARN-2074: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5761 (See [https:

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-24 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042223#comment-14042223 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- This looks good, +1. Checkin

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038300#comment-14038300 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-19 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038264#comment-14038264 ] Jian He commented on YARN-2074: --- Seem to find a bug in ResourceManager#RMContainerPreemptEve

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-19 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038169#comment-14038169 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- Also appAttempt.isLastAttemp

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033531#comment-14033531 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033496#comment-14033496 ] Jian He commented on YARN-2074: --- Thanks for pointing out RMAppAttemptImpl.isLastAttempt, ther

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033479#comment-14033479 ] Wangda Tan commented on YARN-2074: -- [~jianhe], thanks for your clarification. I think the

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033423#comment-14033423 ] Jian He commented on YARN-2074: --- sorry, I meant testAMPreemptedNotCountedForAMFailures > Pre

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033421#comment-14033421 ] Jian He commented on YARN-2074: --- testPreemptedAMRestartOnRMRestart is doing with multiple at

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033402#comment-14033402 ] Wangda Tan commented on YARN-2074: -- [~jianhe], changes almost LGTM, one comment in test, C

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033396#comment-14033396 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033356#comment-14033356 ] Hadoop QA commented on YARN-2074: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Tsuyoshi OZAWA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1405#comment-1405 ] Tsuyoshi OZAWA commented on YARN-2074: -- {quote} amContainerExitStatus will be set to C

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-16 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033327#comment-14033327 ] Wangda Tan commented on YARN-2074: -- Hi Jian, I've reviewed your patch, one question, Is f

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031083#comment-14031083 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031007#comment-14031007 ] Hadoop QA commented on YARN-2074: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-12 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030269#comment-14030269 ] Wangda Tan commented on YARN-2074: -- [~jianhe], I just found this patch is failed to apply

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-06-05 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019510#comment-14019510 ] Wangda Tan commented on YARN-2074: -- Can we populate "attemptFailureCount" to AM when AM re

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007851#comment-14007851 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-22 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006743#comment-14006743 ] Jian He commented on YARN-2074: --- Talked with Vinod offline, the big problem with this is even

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-22 Thread Mayank Bansal (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006735#comment-14006735 ] Mayank Bansal commented on YARN-2074: - +1 LGTM Thanks, Mayank > Preemption of AM cont

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-22 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006525#comment-14006525 ] Jian He commented on YARN-2074: --- Thanks Xuan and Mayank for the review ! bq. maxAppAttempts

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-22 Thread Mayank Bansal (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006459#comment-14006459 ] Mayank Bansal commented on YARN-2074: - Thanks [~jianhe] for the patch. Overall looks go

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005564#comment-14005564 ] Jian He commented on YARN-2074: --- bq. Use this condition to decide whether this RMAppAttempt i

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-21 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005370#comment-14005370 ] Xuan Gong commented on YARN-2074: - Comments: 1. {code} RMAppAttempt attempt = n

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004146#comment-14004146 ] Hadoop QA commented on YARN-2074: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-20 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003960#comment-14003960 ] Vinod Kumar Vavilapalli commented on YARN-2074: --- [~sunilg], Agree that as muc

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003892#comment-14003892 ] Jian He commented on YARN-2074: --- I'd like to work on this. Taking this over.. > Preemption o

[jira] [Commented] (YARN-2074) Preemption of AM containers shouldn't count towards AM failures

2014-05-19 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002800#comment-14002800 ] Sunil G commented on YARN-2074: --- Hi Vinod As per the description I understood that the AM co