[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14349038#comment-14349038
]
Varun Vasudev commented on YARN-2190:
-
+1 for the latest patch.
Provide a Windows
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347431#comment-14347431
]
Remus Rusanu commented on YARN-2190:
From my experience patches containing .sln or
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348306#comment-14348306
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346876#comment-14346876
]
Varun Vasudev commented on YARN-2190:
-
[~chuanliu] here's the error I got on my mac -
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346889#comment-14346889
]
Varun Vasudev commented on YARN-2190:
-
Also, the java portion of the patch looks ok to
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346911#comment-14346911
]
Varun Vasudev commented on YARN-2190:
-
[~chuanliu] one more issue with the patch -
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345734#comment-14345734
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345858#comment-14345858
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345996#comment-14345996
]
Chuan Liu commented on YARN-2190:
-
bq. -1 patch. The patch command could not apply the
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344337#comment-14344337
]
Chuan Liu commented on YARN-2190:
-
[~venkateshrin], sound good! I will post a new patch
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343220#comment-14343220
]
Ram Venkatesh commented on YARN-2190:
-
Apologies for the wrong reference in the comment
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341531#comment-14341531
]
Ram Venkatesh commented on YARN-2190:
-
[~chliu] There are two changes here:
1. Memory
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335826#comment-14335826
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231073#comment-14231073
]
Remus Rusanu commented on YARN-2190:
{
+#ifdef NTDDI_WIN8
}
I think you need a runtime
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222776#comment-14222776
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176209#comment-14176209
]
Ivan Mitic commented on YARN-2190:
--
Thanks Chuan, the latest patch looks good to me. There
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150348#comment-14150348
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147086#comment-14147086
]
Varun Vasudev commented on YARN-2190:
-
[~chuanliu] thank you answering my questions.
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147134#comment-14147134
]
Chuan Liu commented on YARN-2190:
-
[~vvasudev], I see. I am not aware of that JIRA. I will
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142770#comment-14142770
]
Chuan Liu commented on YARN-2190:
-
[~vvasudev], thanks for the review! Please see my
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137903#comment-14137903
]
Varun Vasudev commented on YARN-2190:
-
[~chuanliu] thanks for the patch! Some questions
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137905#comment-14137905
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101097#comment-14101097
]
Ivan Mitic commented on YARN-2190:
--
Thanks Chuan for the new patch. I have a few minor
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099747#comment-14099747
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096610#comment-14096610
]
Ivan Mitic commented on YARN-2190:
--
Thanks Chuan for the patch. Looks great overall!
A
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048016#comment-14048016
]
Hadoop QA commented on YARN-2190:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048051#comment-14048051
]
Hadoop QA commented on YARN-2190:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040259#comment-14040259
]
Chuan Liu commented on YARN-2190:
-
bq. 1. what would the implications for the move windows
[
https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039973#comment-14039973
]
Steve Loughran commented on YARN-2190:
--
# what would the implications for the move
29 matches
Mail list logo
