[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203469#comment-14203469 ] Hudson commented on YARN-2753: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1951 (See [htt

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203444#comment-14203444 ] Hudson commented on YARN-2753: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1927 (See [https://

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203399#comment-14203399 ] Hudson commented on YARN-2753: -- FAILURE: Integrated in Hadoop-Yarn-trunk #737 (See [https://b

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202847#comment-14202847 ] zhihai xu commented on YARN-2753: - thanks [~vinodkv] for the thorough review and commit, th

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202824#comment-14202824 ] Hudson commented on YARN-2753: -- FAILURE: Integrated in Hadoop-trunk-Commit #6485 (See [https:

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202802#comment-14202802 ] Vinod Kumar Vavilapalli commented on YARN-2753: --- Thanks [~zxu], this looks go

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202729#comment-14202729 ] zhihai xu commented on YARN-2753: - The two test failures are not related to my patch. All t

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202579#comment-14202579 ] Hadoop QA commented on YARN-2753: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202517#comment-14202517 ] Wangda Tan commented on YARN-2753: -- +1, thanks for update! > Fix potential issues and cod

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202491#comment-14202491 ] zhihai xu commented on YARN-2753: - Hi [~leftnoteasy], Good finding, addressed your comment

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202440#comment-14202440 ] Wangda Tan commented on YARN-2753: -- [~zxu], One minor comment is, when the newLabels is em

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201795#comment-14201795 ] zhihai xu commented on YARN-2753: - Cool, good catch. addressed your comment in the new patc

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201384#comment-14201384 ] Vinod Kumar Vavilapalli commented on YARN-2753: --- Let me look.. > Fix potenti

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201038#comment-14201038 ] zhihai xu commented on YARN-2753: - Hi [~xgong], Could you help review and commit the patch

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200973#comment-14200973 ] Wangda Tan commented on YARN-2753: -- +1 for latest patch, thanks for update! [~zxu] > Fix

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200048#comment-14200048 ] Hadoop QA commented on YARN-2753: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1427#comment-1427 ] zhihai xu commented on YARN-2753: - Hi [~leftnoteasy], thanks for the thorough review. item

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197206#comment-14197206 ] Wangda Tan commented on YARN-2753: -- Hi Zhihai, I just review your patch, some comments:

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192724#comment-14192724 ] zhihai xu commented on YARN-2753: - Hi [~leftnoteasy], thanks to review the patch. zhihai >

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192017#comment-14192017 ] Wangda Tan commented on YARN-2753: -- [~zxu], I haven't reviewed the consolidated patch yet,

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191173#comment-14191173 ] zhihai xu commented on YARN-2753: - Hi [~xgong], since [~leftnoteasy] agreed to my patch(YAR

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189707#comment-14189707 ] Hadoop QA commented on YARN-2753: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187718#comment-14187718 ] Hadoop QA commented on YARN-2753: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187703#comment-14187703 ] Hadoop QA commented on YARN-2753: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187619#comment-14187619 ] zhihai xu commented on YARN-2753: - I remove YARN-2756 from this JIRA YARN-2753, so we can d

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187584#comment-14187584 ] Wangda Tan commented on YARN-2753: -- [~zxu], I agree with other fixes but this one: bq. use

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187579#comment-14187579 ] zhihai xu commented on YARN-2753: - The new patch YARN-2753.004.patch will include 4 patches

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187575#comment-14187575 ] zhihai xu commented on YARN-2753: - Hi [~leftnoteasy], thanks for your suggestion. I also me

[jira] [Commented] (YARN-2753) Fix potential issues and code clean up for *NodeLabelsManager

[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187114#comment-14187114 ] Wangda Tan commented on YARN-2753: -- [~zxu], I've changed the title and description, I sugg