[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-04 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797542#comment-15797542 ] Junping Du commented on YARN-3866: -- I have commit branch-2.8.addendum.4.patch to branch-2.

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797285#comment-15797285 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797280#comment-15797280 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796972#comment-15796972 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-03 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796822#comment-15796822 ] Junping Du commented on YARN-3866: -- bq. I forgot to make changes to proto file which sugge

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796642#comment-15796642 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-03 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796470#comment-15796470 ] Wangda Tan commented on YARN-3866: -- Thanks [~djp] for reviewing this! Once you committed

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2017-01-03 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796464#comment-15796464 ] Junping Du commented on YARN-3866: -- The unit tests failed shouldn't be relevant to the pat

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786956#comment-15786956 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-29 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786464#comment-15786464 ] Wangda Tan commented on YARN-3866: -- Backported YARN-4567 to branch-2.8 to fix javadocs war

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786434#comment-15786434 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768708#comment-15768708 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753429#comment-15753429 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-15 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752785#comment-15752785 ] Wangda Tan commented on YARN-3866: -- Thanks [~andrew.wang] for the comment. We all aware th

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-15 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752768#comment-15752768 ] Andrew Wang commented on YARN-3866: --- Our compat guidelines available on the website, e.g.

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747051#comment-15747051 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-13 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746387#comment-15746387 ] Arun Suresh commented on YARN-3866: --- [~leftnoteasy], wondering if updating yarn_service_p

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-13 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746288#comment-15746288 ] Junping Du commented on YARN-3866: -- addendum.2 patch LGTM. For some reason Jenkins test ge

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15737328#comment-15737328 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736114#comment-15736114 ] Hadoop QA commented on YARN-3866: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-09 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736065#comment-15736065 ] Arun Suresh commented on YARN-3866: --- Thanks for working on the [~leftnoteasy], In, yarn_

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-08 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733018#comment-15733018 ] Junping Du commented on YARN-3866: -- Thanks [~leftnoteasy]! I will go ahead to reopen this

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-08 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732979#comment-15732979 ] Wangda Tan commented on YARN-3866: -- Sounds everybody agrees to add these APIs back and mar

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731369#comment-15731369 ] Junping Du commented on YARN-3866: -- Thanks for your additional input, Jian! I totally unde

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731145#comment-15731145 ] Jian He commented on YARN-3866: --- IIUC, the value of adding back this API is to avoid the Unkn

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730322#comment-15730322 ] Arun Suresh commented on YARN-3866: --- bq. No. It is already get released in 2.7.3 .. Ah..

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730256#comment-15730256 ] Junping Du commented on YARN-3866: -- bq. As Wangda Tan mentioned, the ApplicationMasterPro

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730171#comment-15730171 ] Arun Suresh commented on YARN-3866: --- As [~leftnoteasy] mentioned, the {{ApplicationMaster

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730115#comment-15730115 ] Wangda Tan commented on YARN-3866: -- Thanks [~ajisakaa], [~djp] for working on 2.8 release

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729997#comment-15729997 ] Junping Du commented on YARN-3866: -- That's nice catch, Akira! Actually, I think we probabl

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729904#comment-15729904 ] Jian He commented on YARN-3866: --- I think all patches are committed to branch-2.8. it should

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2016-12-07 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728125#comment-15728125 ] Akira Ajisaka commented on YARN-3866: - Now I'm looking at compatibility report between

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-09-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905753#comment-14905753 ] Hudson commented on YARN-3866: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2348 (See [https://

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-09-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905704#comment-14905704 ] Hudson commented on YARN-3866: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2375 (See [htt

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-09-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905635#comment-14905635 ] Hudson commented on YARN-3866: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #409 (See [htt

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-09-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905530#comment-14905530 ] Hudson commented on YARN-3866: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #1169 (See [https://

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-09-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905423#comment-14905423 ] Hudson commented on YARN-3866: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #429 (See

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-09-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905350#comment-14905350 ] Hudson commented on YARN-3866: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #436 (See [htt

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-09-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905316#comment-14905316 ] Hudson commented on YARN-3866: -- FAILURE: Integrated in Hadoop-trunk-Commit #8505 (See [https:

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-13 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625632#comment-14625632 ] Wangda Tan commented on YARN-3866: -- BTW, the findbugs warning is resolved by https://issu

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-13 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625629#comment-14625629 ] Jian He commented on YARN-3866: --- Committed into branch YARN-1197, thanks [~mding] ! Thanks [

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625583#comment-14625583 ] Hadoop QA commented on YARN-3866: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-13 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625521#comment-14625521 ] Wangda Tan commented on YARN-3866: -- Rekicked Jenkins to see if the problem still exists.

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-13 Thread MENG DING (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625513#comment-14625513 ] MENG DING commented on YARN-3866: - * The FindBugs doesn't seem to be working in YARN-1197 b

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625486#comment-14625486 ] Hadoop QA commented on YARN-3866: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-13 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625137#comment-14625137 ] Wangda Tan commented on YARN-3866: -- Latest patch looks good, [~mding], could you set statu

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-12 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623901#comment-14623901 ] Wangda Tan commented on YARN-3866: -- bq. 1. DecreasedContainer.java/IncreasedContainer.java

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-10 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623084#comment-14623084 ] Jian He commented on YARN-3866: --- thanks for the feedback. [~mding], we can keep that as is th

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-10 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623047#comment-14623047 ] Sandy Ryza commented on YARN-3866: -- Hi [~jianhe]. Most application writers should be usin

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621494#comment-14621494 ] Jian He commented on YARN-3866: --- I think thats ok. > AM-RM protocol changes to support cont

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-09 Thread MENG DING (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621422#comment-14621422 ] MENG DING commented on YARN-3866: - bq. DecreasedContainer.java/IncreasedContainer.java - ho

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620946#comment-14620946 ] Jian He commented on YARN-3866: --- bq. increaseRequests/decreaseRequests - We may just pass one

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-09 Thread MENG DING (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620718#comment-14620718 ] MENG DING commented on YARN-3866: - Thanks [~jianhe] for the review! bq. Mark all getters/s

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-07-08 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619590#comment-14619590 ] Jian He commented on YARN-3866: --- [~mding], thanks for the work ! some comments on the patch:

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-06-30 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609056#comment-14609056 ] Wangda Tan commented on YARN-3866: -- And could you add ContainerStatus PB-related changes a

[jira] [Commented] (YARN-3866) AM-RM protocol changes to support container resizing

2015-06-30 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609055#comment-14609055 ] Wangda Tan commented on YARN-3866: -- Hi [~mding], Thanks for working on the patch, some com