[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071225#comment-15071225
]
Junping Du commented on YARN-4234:
--
Thanks all for fixing this. :)
> New put APIs in TimelineClient for
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070805#comment-15070805
]
Tsuyoshi Ozawa commented on YARN-4234:
--
[~djp] [~iwasakims] committed addendum patch by Masatake to
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070808#comment-15070808
]
Hudson commented on YARN-4234:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9023 (See
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070799#comment-15070799
]
Tsuyoshi Ozawa commented on YARN-4234:
--
[~iwasakims] thanks for following up. +1, checking this in.
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070915#comment-15070915
]
Tsuyoshi Ozawa commented on YARN-4234:
--
sorry, I just forgot to push. thanks for following up!
> New
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070868#comment-15070868
]
Akira AJISAKA commented on YARN-4234:
-
bq. committed addendum patch by Masatake to trunk and
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069621#comment-15069621
]
Hudson commented on YARN-4234:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9018 (See
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069625#comment-15069625
]
Junping Du commented on YARN-4234:
--
Forget to mention, I think we need to document new APIs that we are
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070495#comment-15070495
]
Masatake Iwasaki commented on YARN-4234:
[~djp], file named "q" seemed to be accidentally added to
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067853#comment-15067853
]
Junping Du commented on YARN-4234:
--
Thanks [~xgong] for updating the patch. +1 on latest patch. I will
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067327#comment-15067327
]
Li Lu commented on YARN-4234:
-
Thanks for the work [~xgong] and [~djp]! Once this patch is committed, would
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067352#comment-15067352
]
Junping Du commented on YARN-4234:
--
bq. Once this patch is committed, would anyone of you please ping me
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067385#comment-15067385
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067394#comment-15067394
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066537#comment-15066537
]
Junping Du commented on YARN-4234:
--
Hi Xuan, thanks for updating the patch! There are still some checksyte
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064364#comment-15064364
]
Junping Du commented on YARN-4234:
--
Thanks [~xgong] for updating the patch. The latest patch LGTM in
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064917#comment-15064917
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064816#comment-15064816
]
Xuan Gong commented on YARN-4234:
-
upload a patch to fix the checkstyle issue
> New put APIs in
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062294#comment-15062294
]
Junping Du commented on YARN-4234:
--
Thanks [~xgong] for updating the patch. I just go through the latest
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062956#comment-15062956
]
Xuan Gong commented on YARN-4234:
-
Thanks for the review. [~djp]. Attached a new patch to address all your
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063175#comment-15063175
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014731#comment-15014731
]
Vinod Kumar Vavilapalli commented on YARN-4234:
---
As I [commented on
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011918#comment-15011918
]
Xuan Gong commented on YARN-4234:
-
The new patch addressed the comments
> New put APIs in TimelineClient
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012107#comment-15012107
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012782#comment-15012782
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009877#comment-15009877
]
Li Lu commented on YARN-4234:
-
Hi [~xgong], the current fix will force to close the current FD if the incoming
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007196#comment-15007196
]
Xuan Gong commented on YARN-4234:
-
Fix the testcase failures and whitespace warning.
> New put APIs in
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007357#comment-15007357
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007493#comment-15007493
]
Li Lu commented on YARN-4234:
-
One more problem: Looking into the writer, I can see the writer maintains one
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007208#comment-15007208
]
Li Lu commented on YARN-4234:
-
Hi [~xgong], not sure if you've noticed [~sjlee0]'s comments in YATN-4183:
bq.
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007736#comment-15007736
]
Xuan Gong commented on YARN-4234:
-
bq. While this is totally fine for summary logs, it will cause entities
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007841#comment-15007841
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006232#comment-15006232
]
Xuan Gong commented on YARN-4234:
-
bq. TimelineClientImpl is doing two many things. Let's have a
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006231#comment-15006231
]
Xuan Gong commented on YARN-4234:
-
Thanks for the review.
bq. Do we want to add those configs into
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006262#comment-15006262
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003290#comment-15003290
]
Li Lu commented on YARN-4234:
-
Hi [~xgong], thanks for the update! General design LGTM, a few quick issues:
#
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001455#comment-15001455
]
Naganarasimha G R commented on YARN-4234:
-
Hi [~jlowe] & [~gtCarrera],
AFAIK, YARN-4183 wanted to
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001621#comment-15001621
]
Naganarasimha G R commented on YARN-4234:
-
Thanks [~gtCarrera] it would be helpful if you can also
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001476#comment-15001476
]
Li Lu commented on YARN-4234:
-
Hi [~Naganarasimha], I'm not extremely familiar with the delegation token stuff
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001334#comment-15001334
]
Jason Lowe commented on YARN-4234:
--
One issue of having the client need to contact the server is it adds a
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001380#comment-15001380
]
Li Lu commented on YARN-4234:
-
I think here are some miscommunications, please feel free to correct me if I'm
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000962#comment-15000962
]
Xuan Gong commented on YARN-4234:
-
Attached a new patch with the renamed configurations.
bq. CacheId ->
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001108#comment-15001108
]
Li Lu commented on YARN-4234:
-
Hi [~Naganarasimha], IIUC the TIMELINE_SERVICE_VERSION config is describing the
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001093#comment-15001093
]
Naganarasimha G R commented on YARN-4234:
-
Hi [~xgong] & [~gtCarrera],
Before we go ahead with
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001171#comment-15001171
]
Naganarasimha G R commented on YARN-4234:
-
Hi [~gtCarrera], IIUC YARN-3488 is talking about if this
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001224#comment-15001224
]
Li Lu commented on YARN-4234:
-
Well let me clarify one thing: ATS v1.5 supports all ATS v1 features, while ATS
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001202#comment-15001202
]
Li Lu commented on YARN-4234:
-
[~Naganarasimha] Sure, we can certainly add those extra sanity checks on the
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001318#comment-15001318
]
Naganarasimha G R commented on YARN-4234:
-
Thanks [~gtCarrera], for updating offline about the
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001325#comment-15001325
]
Li Lu commented on YARN-4234:
-
Thanks [~Naganarasimha], this is a good suggestion. Maybe we can put those
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999157#comment-14999157
]
Hadoop QA commented on YARN-4234:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999673#comment-14999673
]
Vinod Kumar Vavilapalli commented on YARN-4234:
---
Please also look at
51 matches
Mail list logo