[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459690#comment-15459690
]
Karthik Kambatla commented on YARN-5264:
+1. Committing this.
> Use FSQueue to sto
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453690#comment-15453690
]
Hadoop QA commented on YARN-5264:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453518#comment-15453518
]
Karthik Kambatla commented on YARN-5264:
Nice! The code is so much cleaner. Thanks
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453503#comment-15453503
]
Hadoop QA commented on YARN-5264:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453353#comment-15453353
]
Yufei Gu commented on YARN-5264:
The patch 006 fixed the last comment. Thanks a lot for the
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453346#comment-15453346
]
Daniel Templeton commented on YARN-5264:
Looks good to me. +1 (non-binding)
> Use
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453283#comment-15453283
]
Daniel Templeton commented on YARN-5264:
Darn it, I found something I had missed be
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453274#comment-15453274
]
Yufei Gu commented on YARN-5264:
The check style issues are OK to let alone.
> Use FSQueue
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450556#comment-15450556
]
Hadoop QA commented on YARN-5264:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450429#comment-15450429
]
Yufei Gu commented on YARN-5264:
Thanks [~templedf]'s latest comment. I think we comment co
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450391#comment-15450391
]
Yufei Gu commented on YARN-5264:
Hi [~templedf], thanks a lot for the review. I agree with
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450368#comment-15450368
]
Hadoop QA commented on YARN-5264:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450332#comment-15450332
]
Daniel Templeton commented on YARN-5264:
Per our offline discussion, this patch is
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449031#comment-15449031
]
Daniel Templeton commented on YARN-5264:
Thanks for cleaning this mess up, [~yufeig
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423286#comment-15423286
]
Hadoop QA commented on YARN-5264:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388191#comment-15388191
]
Hadoop QA commented on YARN-5264:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334188#comment-15334188
]
Karthik Kambatla commented on YARN-5264:
This should make the code much cleaner. On
17 matches
Mail list logo