[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655814#comment-15655814 ] Hadoop QA commented on YARN-5819: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655248#comment-15655248 ] Karthik Kambatla commented on YARN-5819: Since updating {{Resource}} is not atomic, it seemed safer

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655170#comment-15655170 ] Daniel Templeton commented on YARN-5819: Do you need to synchronize {{getPreemptedResources()}}?

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653242#comment-15653242 ] Hadoop QA commented on YARN-5819: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652915#comment-15652915 ] Hadoop QA commented on YARN-5819: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652786#comment-15652786 ] Karthik Kambatla commented on YARN-5819: Patch v3 incorporates most recent review feedback except

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651747#comment-15651747 ] Daniel Templeton commented on YARN-5819: bq. Is there a good reason to not use for-loops here? It

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649685#comment-15649685 ] Hadoop QA commented on YARN-5819: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646541#comment-15646541 ] Karthik Kambatla commented on YARN-5819: [~templedf] - would you like me to post the patch on

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646534#comment-15646534 ] Karthik Kambatla commented on YARN-5819: Thanks for the prompt and thorough first pass,

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645799#comment-15645799 ] Daniel Templeton commented on YARN-5819: This is just a first-pass review. After we settle on

[jira] [Commented] (YARN-5819) Verify fairshare and minshare preemption

[ https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631873#comment-15631873 ] Karthik Kambatla commented on YARN-5819: This patch applies on top of YARN-5783. > Verify