[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879569#comment-15879569 ] Hudson commented on YARN-6210: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11291 (See

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879472#comment-15879472 ] Karthik Kambatla commented on YARN-6210: I like what we have better. It is clearer; nested ifs are

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879463#comment-15879463 ] Daniel Templeton commented on YARN-6210: You're gonna love me for this one... We now have: {code}

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879433#comment-15879433 ] Karthik Kambatla commented on YARN-6210: I got two +1s from Jenkins. [~templedf] - don't you think

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879241#comment-15879241 ] Hadoop QA commented on YARN-6210: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878914#comment-15878914 ] Daniel Templeton commented on YARN-6210: bq I am happy to accommodate any valid suggestions. How

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878912#comment-15878912 ] Karthik Kambatla commented on YARN-6210: bq. FSAppAttempt.isStarved(Resource usage, Resource

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878818#comment-15878818 ] Daniel Templeton commented on YARN-6210: Looks good. A couple tiny nits: *

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877489#comment-15877489 ] Hadoop QA commented on YARN-6210: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877405#comment-15877405 ] Karthik Kambatla commented on YARN-6210: Thanks for the prompt review, Daniel. The updated patch

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877010#comment-15877010 ] Daniel Templeton commented on YARN-6210: Thanks for the patch, [~kasha]. A few comments: *

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875764#comment-15875764 ] Hadoop QA commented on YARN-6210: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875753#comment-15875753 ] Hadoop QA commented on YARN-6210: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875620#comment-15875620 ] Karthik Kambatla commented on YARN-6210: Patch (v2) fixes: # The javadoc warnings #

[jira] [Commented] (YARN-6210) FS: Node reservations can interfere with preemption

[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875360#comment-15875360 ] Hadoop QA commented on YARN-6210: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||