[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150552#comment-14150552
]
Hudson commented on YARN-668:
-
FAILURE: Integrated in Hadoop-Yarn-trunk #693 (See
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150607#comment-14150607
]
Hudson commented on YARN-668:
-
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1884 (See
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150633#comment-14150633
]
Hudson commented on YARN-668:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1909 (See
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149952#comment-14149952
]
Jian He commented on YARN-668:
--
Looks good overall, minor comments:
- In
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150155#comment-14150155
]
Hadoop QA commented on YARN-668:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150300#comment-14150300
]
Hudson commented on YARN-668:
-
SUCCESS: Integrated in Hadoop-trunk-Commit #6130 (See
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150440#comment-14150440
]
Junping Du commented on YARN-668:
-
Thanks [~jianhe] for review and commit. Filed YARN-2615
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147476#comment-14147476
]
Hadoop QA commented on YARN-668:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148074#comment-14148074
]
Vinod Kumar Vavilapalli commented on YARN-668:
--
Quick look at the patch
- None
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148125#comment-14148125
]
Jian He commented on YARN-668:
--
- containerManagerImpl, TestApplicationMasterService changes
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148326#comment-14148326
]
Junping Du commented on YARN-668:
-
Thanks [~vinodkv] and [~jianhe] for review and comments!
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148405#comment-14148405
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148734#comment-14148734
]
Hadoop QA commented on YARN-668:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146343#comment-14146343
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146518#comment-14146518
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146925#comment-14146925
]
Jian He commented on YARN-668:
--
Thanks Junping ! some comments on the patch:
- The newly added
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147052#comment-14147052
]
Junping Du commented on YARN-668:
-
bq. The newly added version id may not be needed. For
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147204#comment-14147204
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147332#comment-14147332
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145480#comment-14145480
]
Junping Du commented on YARN-668:
-
Fix test failure and add more test cases.
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145575#comment-14145575
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145653#comment-14145653
]
Junping Du commented on YARN-668:
-
Fix unit tests in v3.
TokenIdentifier serialization
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145736#comment-14145736
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145784#comment-14145784
]
Junping Du commented on YARN-668:
-
These failures should be unrelated, filed YARN-2593 to
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141791#comment-14141791
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140434#comment-14140434
]
Junping Du commented on YARN-668:
-
bq. Drop all the getters from each tokens to avoid more
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139731#comment-14139731
]
Vinod Kumar Vavilapalli commented on YARN-668:
--
One more thing. Let's version
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139748#comment-14139748
]
Junping Du commented on YARN-668:
-
Thanks [~vinodkv] for comments, and I also tested it
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137912#comment-14137912
]
Vinod Kumar Vavilapalli commented on YARN-668:
--
I think [~sseth]'s solution in
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137952#comment-14137952
]
Junping Du commented on YARN-668:
-
bq. I think Siddharth Seth's solution in the description
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137999#comment-14137999
]
Tsuyoshi OZAWA commented on YARN-668:
-
+1(non-binding) for making TokenIdentifier
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138293#comment-14138293
]
Junping Du commented on YARN-668:
-
[~vinodkv], can you confirm that this is the way we are
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138295#comment-14138295
]
Junping Du commented on YARN-668:
-
Skip the last two files which should be unrelated.
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138385#comment-14138385
]
Hadoop QA commented on YARN-668:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064530#comment-14064530
]
Junping Du commented on YARN-668:
-
Hi [~vinodkv], I think here we are talking about to
[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062331#comment-14062331
]
Vinod Kumar Vavilapalli commented on YARN-668:
--
One other important point from
36 matches
Mail list logo
