[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170165#comment-16170165 ] Hudson commented on YARN-7192: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12896 (See

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-18 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170141#comment-16170141 ] Jason Lowe commented on YARN-7192: -- Thanks for updating the patch! The test failure is unrelated and

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168793#comment-16168793 ] Hadoop QA commented on YARN-7192: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168767#comment-16168767 ] Hadoop QA commented on YARN-7192: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-15 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168606#comment-16168606 ] Jason Lowe commented on YARN-7192: -- +1 lgtm. I'd rather see the multi-listener support added up front.

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-15 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168473#comment-16168473 ] Arun Suresh commented on YARN-7192: --- Thanks for the review [~miklos.szeg...@cloudera.com].. [~jlowe], are

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168451#comment-16168451 ] Hadoop QA commented on YARN-7192: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-15 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168403#comment-16168403 ] Miklos Szegedi commented on YARN-7192: -- +1 (non-binding) Thank you [~asuresh], the latest patch looks

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-15 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168238#comment-16168238 ] Miklos Szegedi commented on YARN-7192: -- Thank you [~asuresh] for the updated patch. bq. Hmm.. it is

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167282#comment-16167282 ] Arun Suresh commented on YARN-7192: --- The testcase failure is tracked in YARN-7196. Think the checkstyle

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167278#comment-16167278 ] Hadoop QA commented on YARN-7192: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167172#comment-16167172 ] Miklos Szegedi commented on YARN-7192: -- Thank you, [~asuresh] for the patch. I have a couple of

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167124#comment-16167124 ] Miklos Szegedi commented on YARN-7192: -- Thank you, [~asuresh] and [~roniburd] for the replies. I

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Roni Burd (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167093#comment-16167093 ] Roni Burd commented on YARN-7192: - I agree with the performance/concurrency concerns but think Arun's

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167028#comment-16167028 ] Arun Suresh commented on YARN-7192: --- Thanks for the detailed review [~jlowe]. bq. Would it make sense for

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166969#comment-16166969 ] Miklos Szegedi commented on YARN-7192: -- [~asuresh], thank you, I think this is very useful. I worked

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-14 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166341#comment-16166341 ] Jason Lowe commented on YARN-7192: -- Took a quick look at the patch, some initial comments: Would it make

[jira] [Commented] (YARN-7192) Add a pluggable StateMachine Listener that is notified of NM Container State changes

2017-09-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165560#comment-16165560 ] Hadoop QA commented on YARN-7192: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||