[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-15 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293323#comment-16293323 ] Jason Lowe commented on YARN-7595: -- +1 for the branch-2.8 patch as well. I agree the unit

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-15 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292968#comment-16292968 ] Jim Brennan commented on YARN-7595: --- I believe these junit test failures are not related

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-15 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292923#comment-16292923 ] genericqa commented on YARN-7595: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-15 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292669#comment-16292669 ] genericqa commented on YARN-7595: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-14 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291330#comment-16291330 ] Jason Lowe commented on YARN-7595: -- Thanks for providing the branch-2 patch! +1 lgtm. It

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291151#comment-16291151 ] Jim Brennan commented on YARN-7595: --- This is ready for review for branch-2. > Container

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-14 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291112#comment-16291112 ] genericqa commented on YARN-7595: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288383#comment-16288383 ] Hudson commented on YARN-7595: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1336

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288371#comment-16288371 ] Jim Brennan commented on YARN-7595: --- Will do. Thanks! > Container launching code suppr

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288348#comment-16288348 ] Jason Lowe commented on YARN-7595: -- Thanks for updating the patch! The unit test failure

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286708#comment-16286708 ] Jim Brennan commented on YARN-7595: --- The unit test failure is the same one as before. The

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286700#comment-16286700 ] genericqa commented on YARN-7595: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286450#comment-16286450 ] genericqa commented on YARN-7595: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284381#comment-16284381 ] Jason Lowe commented on YARN-7595: -- Thanks for the patch! Looks good overall, just a few

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-07 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282541#comment-16282541 ] Jim Brennan commented on YARN-7595: --- The JUnit test that failed (testValidEnvVariableSubs

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-07 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282511#comment-16282511 ] genericqa commented on YARN-7595: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7595) Container launching code suppresses close exceptions after writes

2017-12-01 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274494#comment-16274494 ] Jason Lowe commented on YARN-7595: -- This code pattern appears in the following places rela