[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-10 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470866#comment-16470866 ] Haibo Chen commented on YARN-7715: -- +1. Checking this in shortly. > Update CPU and Memory cgroups params

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-08 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468025#comment-16468025 ] genericqa commented on YARN-7715: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-08 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468012#comment-16468012 ] Haibo Chen commented on YARN-7715: -- Makes sense. Can you add containerId to all the warning message to

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-07 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466631#comment-16466631 ] genericqa commented on YARN-7715: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-07 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466274#comment-16466274 ] Miklos Szegedi commented on YARN-7715: -- Thank you for the review [~haibochen]. I added a unit test

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-06 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465285#comment-16465285 ] Haibo Chen commented on YARN-7715: -- I think the new patch would still call updateContainer() even when the

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-04 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464351#comment-16464351 ] genericqa commented on YARN-7715: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-04 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464275#comment-16464275 ] Miklos Szegedi commented on YARN-7715: -- Thank you for the review [~haibochen]. I updated the patch. >

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-04 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464221#comment-16464221 ] Haibo Chen commented on YARN-7715: -- Thanks [~miklos.szeg...@cloudera.com] for the patch! I have two

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463276#comment-16463276 ] genericqa commented on YARN-7715: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463202#comment-16463202 ] genericqa commented on YARN-7715: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-02 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461797#comment-16461797 ] Miklos Szegedi commented on YARN-7715: -- [~asuresh], [~haibo.chen] I attached a patch of my proposal.

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-05-02 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461741#comment-16461741 ] Miklos Szegedi commented on YARN-7715: -- I am working on a preliminary patch to discuss. Do you think

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-01-10 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321730#comment-16321730 ] Miklos Szegedi commented on YARN-7715: -- I would separate {{preStart}} into two functions, {{preStart}}

[jira] [Commented] (YARN-7715) Update CPU and Memory cgroups params on container update as well.

2018-01-08 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316871#comment-16316871 ] Arun Suresh commented on YARN-7715: --- I was thinking we introduce callbacks into the ResourceHandler