[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478053#comment-16478053 ] Hudson commented on YARN-7933: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14212 (See

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-16 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477991#comment-16477991 ] Haibo Chen commented on YARN-7933: -- Thanks [~rohithsharma] for the patch! I have checked it in trunk. >

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-16 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1648#comment-1648 ] Haibo Chen commented on YARN-7933: -- +1 on the 06 patch. Will commit it later today. > [atsv2 read acls]

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-16 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477211#comment-16477211 ] genericqa commented on YARN-7933: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-14 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474761#comment-16474761 ] Haibo Chen commented on YARN-7933: -- I am okay with just remove the TODO comment, and have the discussion

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-14 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474759#comment-16474759 ] Haibo Chen commented on YARN-7933: -- If it's not in our design, I am inclined to remove it at this point in

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-14 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474013#comment-16474013 ] Rohith Sharma K S commented on YARN-7933: - bq. Isn't it the case that a TimelineClient must be

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-11 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472082#comment-16472082 ] Haibo Chen commented on YARN-7933: -- While thinking of the appId issue, there's one question that occurred

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-11 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472077#comment-16472077 ] Haibo Chen commented on YARN-7933: -- [~rohithsharma] There is TODO comment in TimelineCollector.putDomain()

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471853#comment-16471853 ] genericqa commented on YARN-7933: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-11 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471744#comment-16471744 ] Rohith Sharma K S commented on YARN-7933: - bq. probably we can remove the change to

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-10 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470490#comment-16470490 ] Haibo Chen commented on YARN-7933: -- {quote} For storing in TimelineEntity, we should discuss it separately

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-03 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462813#comment-16462813 ] Rohith Sharma K S commented on YARN-7933: - {quote} Does the patch require a domain id for every

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-03 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462638#comment-16462638 ] Haibo Chen commented on YARN-7933: -- Thanks [~rohithsharma] for updating the patch!  Looks good to me in

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-05-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461968#comment-16461968 ] genericqa commented on YARN-7933: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-04-30 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458540#comment-16458540 ] genericqa commented on YARN-7933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-04-30 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458483#comment-16458483 ] Rohith Sharma K S commented on YARN-7933: - Updated the patch with Hbase writer implementation. cc:/

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-04-12 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436056#comment-16436056 ] Vrushali C commented on YARN-7933: -- In the weekly call today, we discussed about adding in the hbase

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-03-16 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401510#comment-16401510 ] Rohith Sharma K S commented on YARN-7933: - Apache doc has good explanation for this.

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-03-15 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401145#comment-16401145 ] Haibo Chen commented on YARN-7933: -- Is there a doc from ATSv1 (or 1.5) that describes the domain ACL

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-02-28 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380264#comment-16380264 ] genericqa commented on YARN-7933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-02-28 Thread Rohith Sharma K S (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380096#comment-16380096 ] Rohith Sharma K S commented on YARN-7933: - As discussed offline with [~vrushalic], scope of this

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-02-27 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379802#comment-16379802 ] Vrushali C commented on YARN-7933: -- Thanks [~rohithsharma]! I looked through the patch and I think I need

[jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain

2018-02-22 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372762#comment-16372762 ] genericqa commented on YARN-7933: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||