[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753714#comment-16753714 ] Rohith Sharma K S commented on YARN-8270: - In branch-3.1, this was causing error while publishing

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631355#comment-16631355 ] Rohith Sharma K S commented on YARN-8270: - I back ported to branch-3.1 also. Updated the Fix

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631353#comment-16631353 ] Rohith Sharma K S commented on YARN-8270: - [~vrushalic] I updated the fix version to 3.2.0. Patch

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631181#comment-16631181 ] Hudson commented on YARN-8270: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15069 (See

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629761#comment-16629761 ] Rohith Sharma K S commented on YARN-8270: - +1 lgtm.. [~vrushalic] Please do the honor by

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628666#comment-16628666 ] Hadoop QA commented on YARN-8270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627676#comment-16627676 ] Vrushali C commented on YARN-8270: -- bq. Vrushali C Does it make sense to to go 3.1.2 release? If so then

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627576#comment-16627576 ] Hadoop QA commented on YARN-8270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626847#comment-16626847 ] Rohith Sharma K S commented on YARN-8270: - Thanks [~Sushil-K-S] for the patch.. It looks good to

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621628#comment-16621628 ] Hadoop QA commented on YARN-8270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567978#comment-16567978 ] Vrushali C commented on YARN-8270: -- As discussed in the call - raise a jira to add the MutableQuantiles

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567442#comment-16567442 ] genericqa commented on YARN-8270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567415#comment-16567415 ] genericqa commented on YARN-8270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551518#comment-16551518 ] Vrushali C commented on YARN-8270: -- No worries, thanks for letting us know [~haibochen] ! > Adding JMX

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550063#comment-16550063 ] Haibo Chen commented on YARN-8270: -- [~vrushalic] [~Sushil-K-S] My apologies for my late response. Please

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540967#comment-16540967 ] Vrushali C commented on YARN-8270: -- A couple of more questions: - perhaps a bit dumb, but what is the 10

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540965#comment-16540965 ] Vrushali C commented on YARN-8270: -- Hi [~haibochen] Gentle ping for any further thoughts on Sushil's

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522094#comment-16522094 ] Sushil Ks commented on YARN-8270: - Thanks [~haibochen] for reviewing, I have resolved your comments in the

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521971#comment-16521971 ] genericqa commented on YARN-8270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511938#comment-16511938 ] Haibo Chen commented on YARN-8270: -- Thanks [~Sushil-K-S] for updating the patch! The unit test failures

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504477#comment-16504477 ] genericqa commented on YARN-8270: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480124#comment-16480124 ] Sushil Kumar S commented on YARN-8270: -- Hi Haibo, thanks for reviewing please find my comments below,

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479178#comment-16479178 ] Haibo Chen commented on YARN-8270: -- The getInstance() methods are not thread-safe, if two threads happen

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479169#comment-16479169 ] Haibo Chen commented on YARN-8270: -- Thanks [~Sushil-K-S] for the patch! I don't know much about the metric

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470755#comment-16470755 ] Sushil Kumar S commented on YARN-8270: -- [~rohithsharma] Kindly grant permission to assign the JIRA

[jira] [Commented] (YARN-8270) Adding JMX Metrics for Timeline Collector and Reader

[ https://issues.apache.org/jira/browse/YARN-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469522#comment-16469522 ] genericqa commented on YARN-8270: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||