[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807068#comment-16807068
]
Hudson commented on YARN-8967:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16321 (See
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801420#comment-16801420
]
Hudson commented on YARN-8967:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16283 (See
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801415#comment-16801415
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Thank you [~yufeigu] for the commit.
> Change
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801412#comment-16801412
]
Yufei Gu commented on YARN-8967:
Committed to trunk. Thanks [~wilfreds] for the contribution.
> Change
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799736#comment-16799736
]
Yufei Gu commented on YARN-8967:
+1. Will commit later.
> Change FairScheduler to use PlacementRule
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799129#comment-16799129
]
Hadoop QA commented on YARN-8967:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799020#comment-16799020
]
Wilfred Spiegelenburg commented on YARN-8967:
-
3) I need two pieces back from the child when
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798814#comment-16798814
]
Yufei Gu commented on YARN-8967:
Hi [~wilfreds], thanks for the patch.
3) Yeah, the xml DOM looks like a
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798645#comment-16798645
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Junit test failure is not related.
The
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797926#comment-16797926
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797873#comment-16797873
]
Wilfred Spiegelenburg commented on YARN-8967:
-
1) I missed that one too, fixed now
3) The two
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796846#comment-16796846
]
Yufei Gu commented on YARN-8967:
Hi [~wilfreds], the patch v9 looks really good.
{quote}
Based on all
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795771#comment-16795771
]
Hadoop QA commented on YARN-8967:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795640#comment-16795640
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Cleaned up the checkstyle issues and fixed the
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795184#comment-16795184
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795049#comment-16795049
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Thank you for the review [~yufeigu]
1) yes it
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791411#comment-16791411
]
Yufei Gu commented on YARN-8967:
Hi [~wilfreds], thanks for the patch. Some comments:
1. Nice cleanup in
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791169#comment-16791169
]
Wilfred Spiegelenburg commented on YARN-8967:
-
[~haibochen] or [~templedf] could either of you
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786365#comment-16786365
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786306#comment-16786306
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Fixed the newly introduced checkstyle issues.
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785921#comment-16785921
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766813#comment-16766813
]
Wilfred Spiegelenburg commented on YARN-8967:
-
After talking off line with a number of people
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759601#comment-16759601
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759579#comment-16759579
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Rebased to trunk, the mockito changes prevented
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759562#comment-16759562
]
Yufei Gu commented on YARN-8967:
Hi [~wilfreds], the patch v4 doesn't apply to the trunk. Can you rebase
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757815#comment-16757815
]
Wilfred Spiegelenburg commented on YARN-8967:
-
[~sunilg] can you please have a review of this
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734923#comment-16734923
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734881#comment-16734881
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Updated the patch with fixes for the tests and
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733723#comment-16733723
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Thank you [~leftnoteasy] It has been a long
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733580#comment-16733580
]
Wangda Tan commented on YARN-8967:
--
Thanks [~wilfreds], I'm very glad to see that the original YARN-3635
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733225#comment-16733225
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733104#comment-16733104
]
Sunil Govindan commented on YARN-8967:
--
Hi [~wilfreds]
I will definitely take a look at this. Please
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733094#comment-16733094
]
Wilfred Spiegelenburg commented on YARN-8967:
-
Update to fix the tests and the checkstyle
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732713#comment-16732713
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732656#comment-16732656
]
Wilfred Spiegelenburg commented on YARN-8967:
-
new patch rebased to the latest trunk: fixed
[
https://issues.apache.org/jira/browse/YARN-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732619#comment-16732619
]
Hadoop QA commented on YARN-8967:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
36 matches
Mail list logo
