[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776499#comment-16776499
]
Zhankun Tang commented on YARN-9121:
[~snemeth] , thanks for the patch.
Looks good to me. +1
> Users
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776005#comment-16776005
]
Szilard Nemeth commented on YARN-9121:
--
UT failure is unrelated.
> Users of
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776004#comment-16776004
]
Hadoop QA commented on YARN-9121:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775975#comment-16775975
]
Szilard Nemeth commented on YARN-9121:
--
Hi [~sunilg]!
Addressed the findbugs issue with the new
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775827#comment-16775827
]
Sunil Govindan commented on YARN-9121:
--
Findbugs are something need to be addressed. Could you please
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775614#comment-16775614
]
Szilard Nemeth commented on YARN-9121:
--
[~sunilg]: Findbugs complains about
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775547#comment-16775547
]
Hadoop QA commented on YARN-9121:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775469#comment-16775469
]
Szilard Nemeth commented on YARN-9121:
--
[~sunilg]: Sure, {{new GpuDiscoverer()}} only happens once in
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775451#comment-16775451
]
Sunil Govindan commented on YARN-9121:
--
On a second thought, will multiple instance of GpuDiscoverer
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775353#comment-16775353
]
Adam Antal commented on YARN-9121:
--
Thanks, +1 (non-binding).
> Users of GpuDiscoverer.getInstance() are
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775256#comment-16775256
]
Szilard Nemeth commented on YARN-9121:
--
Hi [~adam.antal]!
Fair enough. Updated the description.
Does
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774426#comment-16774426
]
Adam Antal commented on YARN-9121:
--
Hi Szilard,
As I see through this patch, this is a patch rather about
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763743#comment-16763743
]
Szilard Nemeth commented on YARN-9121:
--
Hi [~sunilg]!
We discussed with [~pbacsko] offline that
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763729#comment-16763729
]
Sunil Govindan commented on YARN-9121:
--
+1. Thanks [~snemeth]
kindly address comments from
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748066#comment-16748066
]
Peter Bacsko commented on YARN-9121:
LGTM +1 (non-binding)
Consider using
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723867#comment-16723867
]
Szilard Nemeth commented on YARN-9121:
--
[~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg],
[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720488#comment-16720488
]
Hadoop QA commented on YARN-9121:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
17 matches
Mail list logo