[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-24 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776499#comment-16776499 ] Zhankun Tang commented on YARN-9121: [~snemeth] , thanks for the patch. Looks good to me. +1 > Users

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-23 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776005#comment-16776005 ] Szilard Nemeth commented on YARN-9121: -- UT failure is unrelated. > Users of

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776004#comment-16776004 ] Hadoop QA commented on YARN-9121: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-23 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775975#comment-16775975 ] Szilard Nemeth commented on YARN-9121: -- Hi [~sunilg]! Addressed the findbugs issue with the new

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-23 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775827#comment-16775827 ] Sunil Govindan commented on YARN-9121: -- Findbugs are something need to be addressed. Could you please

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-22 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775614#comment-16775614 ] Szilard Nemeth commented on YARN-9121: -- [~sunilg]: Findbugs complains about

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775547#comment-16775547 ] Hadoop QA commented on YARN-9121: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-22 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775469#comment-16775469 ] Szilard Nemeth commented on YARN-9121: -- [~sunilg]: Sure, {{new GpuDiscoverer()}} only happens once in

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775451#comment-16775451 ] Sunil Govindan commented on YARN-9121: -- On a second thought, will multiple instance of GpuDiscoverer

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-22 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775353#comment-16775353 ] Adam Antal commented on YARN-9121: -- Thanks, +1 (non-binding). > Users of GpuDiscoverer.getInstance() are

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-22 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775256#comment-16775256 ] Szilard Nemeth commented on YARN-9121: -- Hi [~adam.antal]! Fair enough. Updated the description. Does

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-21 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774426#comment-16774426 ] Adam Antal commented on YARN-9121: -- Hi Szilard, As I see through this patch, this is a patch rather about

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-08 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763743#comment-16763743 ] Szilard Nemeth commented on YARN-9121: -- Hi [~sunilg]! We discussed with [~pbacsko] offline that

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763729#comment-16763729 ] Sunil Govindan commented on YARN-9121: -- +1. Thanks [~snemeth] kindly address comments from

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-01-21 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748066#comment-16748066 ] Peter Bacsko commented on YARN-9121: LGTM +1 (non-binding) Consider using

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2018-12-18 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723867#comment-16723867 ] Szilard Nemeth commented on YARN-9121: -- [~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg],

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2018-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720488#comment-16720488 ] Hadoop QA commented on YARN-9121: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||