[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-21 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748107#comment-16748107 ] Wangda Tan commented on YARN-9173: -- Cherry-picked to branch-3.1.2 as well. Updated fix version >

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736780#comment-16736780 ] Wilfred Spiegelenburg commented on YARN-9173: - Sorry for the typo in the patch name, I did not

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736762#comment-16736762 ] Weiwei Yang commented on YARN-9173: --- +1, committing to branch-3.1 and lower versions shortly. >

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736748#comment-16736748 ] Hadoop QA commented on YARN-9173: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736668#comment-16736668 ] Hadoop QA commented on YARN-9173: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736490#comment-16736490 ] Wilfred Spiegelenburg commented on YARN-9173: - [~cheersyang] I have added a patch for branch

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735562#comment-16735562 ] Hudson commented on YARN-9173: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15718 (See

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735557#comment-16735557 ] Weiwei Yang commented on YARN-9173: --- [~wilfreds] I met some conflicts when cherry-pick this to

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-07 Thread liyakun (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735556#comment-16735556 ] liyakun commented on YARN-9173: --- [~cheersyang] I will fix the problem in branch-2 with considering of

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-06 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735533#comment-16735533 ] Weiwei Yang commented on YARN-9173: --- Thanks [~yoelee], [~wilfreds], patch also looks good to me. +1, I

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-06 Thread liyakun (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735506#comment-16735506 ] liyakun commented on YARN-9173: --- [~wilfreds] I have read your patch, it LGTM.  The goal of YARN-8833 is to

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735465#comment-16735465 ] Hadoop QA commented on YARN-9173: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-06 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735398#comment-16735398 ] Wilfred Spiegelenburg commented on YARN-9173: - Thank you [~cheersyang] for the review. Updated

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-05 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734906#comment-16734906 ] Weiwei Yang commented on YARN-9173: --- Hi [~wilfreds] Thanks for fixing this and adding more UTs. You are

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-04 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734240#comment-16734240 ] Wilfred Spiegelenburg commented on YARN-9173: - Test failure is not related to the change. I

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734190#comment-16734190 ] Hadoop QA commented on YARN-9173: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833

2019-01-04 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734135#comment-16734135 ] Weiwei Yang commented on YARN-9173: --- Sure, thanks [~wilfreds] for working on this, I will take a look