[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883896#comment-16883896
]
Szilard Nemeth commented on YARN-9235:
--
Committed to trunk, 3.2 and 3.1 branches.
Thanks
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883897#comment-16883897
]
Hudson commented on YARN-9235:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16905 (See
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883877#comment-16883877
]
Szilard Nemeth commented on YARN-9235:
--
Latest patch looks good, giving +1 and committing soon!
> If
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883599#comment-16883599
]
Hadoop QA commented on YARN-9235:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883573#comment-16883573
]
Szilard Nemeth commented on YARN-9235:
--
Re-uploading latest patch in order to have a fresh Jenkins
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883284#comment-16883284
]
Szilard Nemeth commented on YARN-9235:
--
Hi [~bsteinbach]!
If you don't mind, [~adam.antal] could take
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812350#comment-16812350
]
Antal Bálint Steinbach commented on YARN-9235:
--
Hi [~jojochuang] ,
as we discussed before
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803934#comment-16803934
]
Hadoop QA commented on YARN-9235:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803896#comment-16803896
]
Antal Bálint Steinbach commented on YARN-9235:
--
[~snemeth] , it already has a +1, thanks
>
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803882#comment-16803882
]
Antal Bálint Steinbach commented on YARN-9235:
--
Hi,
LOGGER is renamed to LOG.
I agree that
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803881#comment-16803881
]
Szilard Nemeth commented on YARN-9235:
--
Hi [~bsteinbach]!
Do you need help with the review?
> If
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792736#comment-16792736
]
Hadoop QA commented on YARN-9235:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787844#comment-16787844
]
Adam Antal commented on YARN-9235:
--
It seems that the depending patches all got resolved, so this one can
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779061#comment-16779061
]
Zoltan Siegl commented on YARN-9235:
LGTM +1 (non-binding)
> If linux container executor is not set
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777812#comment-16777812
]
Hadoop QA commented on YARN-9235:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777105#comment-16777105
]
Hadoop QA commented on YARN-9235:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777016#comment-16777016
]
Antal Bálint Steinbach commented on YARN-9235:
--
Hi [~sunilg] ,
Tests are added as requested.
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776011#comment-16776011
]
Szilard Nemeth commented on YARN-9235:
--
[~sunilg]: Just an FYI, This depends on YARN-9121 and not
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775202#comment-16775202
]
Sunil Govindan commented on YARN-9235:
--
Thanks [~bsteinbach]. Make sense. Lets visit and review
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769357#comment-16769357
]
Antal Bálint Steinbach commented on YARN-9235:
--
Hi [~pbacsko], [~sunilg] ,
Yeah, that would
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768463#comment-16768463
]
Hadoop QA commented on YARN-9235:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768438#comment-16768438
]
Sunil Govindan commented on YARN-9235:
--
Yes. I agree to [~pbacsko]
Pls help to add a test case here.
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768325#comment-16768325
]
Antal Bálint Steinbach commented on YARN-9235:
--
Hi [~sunilg] ,
I uploaded a very simple
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768331#comment-16768331
]
Peter Bacsko commented on YARN-9235:
[~bsteinbach] can you add a simple unit test for this scenario?
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763722#comment-16763722
]
Sunil Govindan commented on YARN-9235:
--
Its a good point. Thanks [~bsteinbach]
Could we add a
25 matches
Mail list logo