[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829490#comment-13829490
]
Zhijie Shen commented on YARN-955:
--
bq. As discussed , We will do the changes as part of YA
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829488#comment-13829488
]
Mayank Bansal commented on YARN-955:
As discussed , We will do the changes as part of YA
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829246#comment-13829246
]
Zhijie Shen commented on YARN-955:
--
This patch may need to be changed according to the comm
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828178#comment-13828178
]
Hadoop QA commented on YARN-955:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828153#comment-13828153
]
Mayank Bansal commented on YARN-955:
Thanks [~vinodkv] for the review.
bq. One nit: Can
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826773#comment-13826773
]
Vinod Kumar Vavilapalli commented on YARN-955:
--
One nit: Can you rename history
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826193#comment-13826193
]
Zhijie Shen commented on YARN-955:
--
+1, LGMT
> [YARN-321] Implementation of ApplicationHis
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826062#comment-13826062
]
Hadoop QA commented on YARN-955:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826014#comment-13826014
]
Mayank Bansal commented on YARN-955:
Thanks [~zjshen] for review.
bq. Please add the co
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822141#comment-13822141
]
Zhijie Shen commented on YARN-955:
--
The patch is almost fine. One more comment. Please add
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820712#comment-13820712
]
Hadoop QA commented on YARN-955:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820652#comment-13820652
]
Mayank Bansal commented on YARN-955:
Thanks [~zjshen] fir review
bq. 1. It's not necess
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816872#comment-13816872
]
Zhijie Shen commented on YARN-955:
--
1. It's not necessary, and shouldn't be public.
{code}
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815532#comment-13815532
]
Hadoop QA commented on YARN-955:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815501#comment-13815501
]
Mayank Bansal commented on YARN-955:
bq. Not necessary. The default value can be read fr
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814622#comment-13814622
]
Zhijie Shen commented on YARN-955:
--
1. Not necessary. The default value can be read from ya
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813787#comment-13813787
]
Hadoop QA commented on YARN-955:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813712#comment-13813712
]
Mayank Bansal commented on YARN-955:
Thanks [~zjshen] for the review
bq. 1. Is there an
[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794196#comment-13794196
]
Zhijie Shen commented on YARN-955:
--
[~mayank_bansal], thanks for the work on the implementa
19 matches
Mail list logo
