[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

2019-02-28 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780688#comment-16780688 ] Sunil Govindan commented on YARN-9138: -- Thanks [~snemeth]. i ll check on same now > Test error

[jira] [Commented] (YARN-9139) Simplify initializer code of GpuDiscoverer

2019-02-27 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779594#comment-16779594 ] Sunil Govindan commented on YARN-9139: -- [~snemeth] pls rebase this patch if necessary > Simplify

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

2019-03-03 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782989#comment-16782989 ] Sunil Govindan commented on YARN-9138: -- Thanks [~snemeth]. For messages, if its reused, you can

[jira] [Commented] (YARN-9319) YARN-9060 does not compile

2019-02-21 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774352#comment-16774352 ] Sunil Govindan commented on YARN-9319: -- +1 > YARN-9060 does not compile > --

[jira] [Commented] (YARN-9087) Improve logging for initialization of Resource plugins

2019-02-26 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778954#comment-16778954 ] Sunil Govindan commented on YARN-9087: -- Thanks [~snemeth]. Pulled to branch-3.2/3.1 > Improve

[jira] [Commented] (YARN-9121) Replace GpuDiscoverer.getInstance() to a readable object for easy access control

2019-02-26 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778971#comment-16778971 ] Sunil Govindan commented on YARN-9121: -- Hi [~snemeth] Post YARN-9087 commit to these branch, I was

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

2019-03-06 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785572#comment-16785572 ] Sunil Govindan commented on YARN-9265: -- + [~tangzhankun] Could you please help to review this patch.

[jira] [Updated] (YARN-9138) Improve test coverage for nvidia-smi binary execution of GpuDiscoverer

2019-03-06 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-9138: - Summary: Improve test coverage for nvidia-smi binary execution of GpuDiscoverer (was: Test error

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

2019-03-06 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785485#comment-16785485 ] Sunil Govindan commented on YARN-9138: -- +1 on latest patch. > Test error handling of nvidia-smi

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

2019-03-06 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785702#comment-16785702 ] Sunil Govindan commented on YARN-9265: -- Thanks [~pbacsko] Few comments: # I would prefer to take 

[jira] [Updated] (YARN-8891) Documentation of the pluggable device framework

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-8891: - Component/s: documentation > Documentation of the pluggable device framework >

[jira] [Commented] (YARN-9118) Handle issues with parsing user defined GPU devices in GpuDiscoverer

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775204#comment-16775204 ] Sunil Govindan commented on YARN-9118: -- I am happy with latest patch. Lets get this in later

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775233#comment-16775233 ] Sunil Govindan commented on YARN-9213: -- lemme kick jenkins again. some issues.  > RM Web UI v1 does

[jira] [Commented] (YARN-9235) If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775202#comment-16775202 ] Sunil Govindan commented on YARN-9235: -- Thanks [~bsteinbach]. Make sense. Lets visit and review 

[jira] [Updated] (YARN-9118) Handle exceptions with parsing user defined GPU devices in GpuDiscoverer

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-9118: - Summary: Handle exceptions with parsing user defined GPU devices in GpuDiscoverer (was: Handle

[jira] [Commented] (YARN-9121) Replace GpuDiscoverer.getInstance() to a readable object for easy access control

2019-02-25 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776706#comment-16776706 ] Sunil Govindan commented on YARN-9121: -- Hi [~snemeth] Thanks for branch-3.1 patch. This patch is not

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775288#comment-16775288 ] Sunil Govindan commented on YARN-9213: -- Hi [~snemeth] branch-3.2 patch seems not good. Could you

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775324#comment-16775324 ] Sunil Govindan commented on YARN-9213: -- [~snemeth] YARN-9051 is a feature change. And i am not very

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775451#comment-16775451 ] Sunil Govindan commented on YARN-9121: -- On a second thought, will multiple instance of GpuDiscoverer

[jira] [Commented] (YARN-9121) Replace GpuDiscoverer.getInstance() to a readable object for easy access control

2019-02-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776542#comment-16776542 ] Sunil Govindan commented on YARN-9121: -- [~snemeth] I committed to trunk. pls share branch-3.2 and

[jira] [Updated] (YARN-9121) Replace GpuDiscoverer.getInstance() to a readable object for easy access control

2019-02-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-9121: - Summary: Replace GpuDiscoverer.getInstance() to a readable object for easy access control (was:

[jira] [Commented] (YARN-9121) Replace GpuDiscoverer.getInstance() to a readable object for easy access control

2019-02-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776549#comment-16776549 ] Sunil Govindan commented on YARN-9121: -- If branch-3.2 can be applied on branch-3.1, separate patches

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

2019-03-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781705#comment-16781705 ] Sunil Govindan commented on YARN-9138: -- Hi [~snemeth] Few comments: # Could GPU_SCRIPT_REFERENCE

[jira] [Comment Edited] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

2019-03-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781705#comment-16781705 ] Sunil Govindan edited comment on YARN-9138 at 3/1/19 2:59 PM: -- Hi [~snemeth]

[jira] [Commented] (YARN-9139) Simplify initializer code of GpuDiscoverer

2019-02-27 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780029#comment-16780029 ] Sunil Govindan commented on YARN-9139: -- Failed test case looks related > Simplify initializer code

[jira] [Commented] (YARN-9121) Replace GpuDiscoverer.getInstance() to a readable object for easy access control

2019-02-28 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780300#comment-16780300 ] Sunil Govindan commented on YARN-9121: -- This issue is merged in trunk/branch-3.2 and branch-3.1. Cud

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-23 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775827#comment-16775827 ] Sunil Govindan commented on YARN-9121: -- Findbugs are something need to be addressed. Could you please

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-22 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775824#comment-16775824 ] Sunil Govindan commented on YARN-9213: -- Could you try to avoid the use of 

[jira] [Commented] (YARN-8891) Documentation of the pluggable device framework

2019-02-21 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774786#comment-16774786 ] Sunil Govindan commented on YARN-8891: -- Thanks [~tangzhankun]. A very detailed doc, thank you very

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

2019-03-11 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789353#comment-16789353 ] Sunil Govindan commented on YARN-9266: -- + [~tangzhankun] > Various fixes are needed in

[jira] [Commented] (YARN-8947) [UI2] Active User info missing from UI2

2019-03-07 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786497#comment-16786497 ] Sunil Govindan commented on YARN-8947: -- +1. This patch looks good to me. Thanks for attaching the

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

2019-03-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787992#comment-16787992 ] Sunil Govindan commented on YARN-9266: -- Thanks [~pbacsko] for the efforts. I ll look into details of

[jira] [Commented] (YARN-9265) FPGA plugin fails to recognize Intel Processing Accelerator Card

2019-03-07 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786993#comment-16786993 ] Sunil Govindan commented on YARN-9265: -- [~pbacsko] cud u pls check the ASF license pblm. > FPGA

[jira] [Updated] (YARN-9266) General improvements in IntelFpgaOpenclPlugin

2019-03-12 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-9266: - Summary: General improvements in IntelFpgaOpenclPlugin (was: Various fixes are needed in

[jira] [Commented] (YARN-9266) General improvements in IntelFpgaOpenclPlugin

2019-03-12 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791022#comment-16791022 ] Sunil Govindan commented on YARN-9266: -- Committed to trunk. Thanks [~pbacsko], and thank

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

2019-03-12 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791018#comment-16791018 ] Sunil Govindan commented on YARN-9266: -- Thanks. +1 from me as well. Lets get this in. > Various

[jira] [Commented] (YARN-9213) RM Web UI does not show custom resource allocations for containers page

2019-02-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763662#comment-16763662 ] Sunil Govindan commented on YARN-9213: -- Thanks [~snemeth] Could you please attach a screen shot of

[jira] [Commented] (YARN-9118) Handle issues with parsing user defined GPU devices in GpuDiscoverer

2019-02-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763721#comment-16763721 ] Sunil Govindan commented on YARN-9118: -- Barring the above comments, this is fine. [~tangzhankun]

[jira] [Commented] (YARN-9235) If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown

2019-02-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763722#comment-16763722 ] Sunil Govindan commented on YARN-9235: -- Its a good point. Thanks [~bsteinbach] Could we add a

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

2019-02-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763729#comment-16763729 ] Sunil Govindan commented on YARN-9121: -- +1. Thanks [~snemeth] kindly address comments from

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-15 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769073#comment-16769073 ] Sunil Govindan commented on YARN-9213: -- Thanks [~snemeth] I think these checkstyle issues to be

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768971#comment-16768971 ] Sunil Govindan commented on YARN-9213: -- Jenkins result seems a bit old. Kicking jenkins again. > RM

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769020#comment-16769020 ] Sunil Govindan commented on YARN-9213: -- Seems jenkins is pulling the images as it has the latest

[jira] [Updated] (YARN-8295) [UI2] Improve "Resource Usage" tab error message when there are no data available.

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-8295: - Summary: [UI2] Improve "Resource Usage" tab error message when there are no data available.

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770419#comment-16770419 ] Sunil Govindan commented on YARN-9060: -- +1. Lets get this in > [YARN-8851] Phase 1 - Support device

[jira] [Commented] (YARN-7824) [UI2] Yarn Component Instance page should include link to container logs

2019-02-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770423#comment-16770423 ] Sunil Govindan commented on YARN-7824: -- Thanks [~akhilpb] > [UI2] Yarn Component Instance page

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770415#comment-16770415 ] Sunil Govindan commented on YARN-9213: -- +1 Committing shortly. > RM Web UI v1 does not show custom

[jira] [Comment Edited] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770458#comment-16770458 ] Sunil Govindan edited comment on YARN-9213 at 2/17/19 4:22 PM: --- Hi

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770458#comment-16770458 ] Sunil Govindan commented on YARN-9213: -- Hi [~snemeth] Pls name it as 

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770417#comment-16770417 ] Sunil Govindan commented on YARN-9213: -- [~snemeth] pls share branch-3.2/3.1 patches as it cant be

[jira] [Commented] (YARN-7824) [UI2] Yarn Component Instance page should include link to container logs

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768043#comment-16768043 ] Sunil Govindan commented on YARN-7824: -- +1. Lets get this in. Thanks [~akhilpb] > [UI2] Yarn

[jira] [Reopened] (YARN-7761) [UI2] Clicking 'master container log' or 'Link' next to 'log' under application's appAttempt goes to Old UI's Log link

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan reopened YARN-7761: -- reopening to run jenkins for 3.2 patch > [UI2] Clicking 'master container log' or 'Link' next to

[jira] [Commented] (YARN-9293) Optimize MockAMLauncher event handling

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768052#comment-16768052 ] Sunil Govindan commented on YARN-9293: -- +1 to this optimization. Thanks [~bibinchundatt] > Optimize

[jira] [Commented] (YARN-9235) If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768438#comment-16768438 ] Sunil Govindan commented on YARN-9235: -- Yes. I agree to [~pbacsko] Pls help to add a test case here.

[jira] [Updated] (YARN-7761) [UI2] Clicking 'master container log' or 'Link' next to 'log' under application's appAttempt goes to Old UI's Log link

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-7761: - Fix Version/s: 3.1.3 3.2.1 > [UI2] Clicking 'master container log' or 'Link'

[jira] [Commented] (YARN-9118) Handle issues with parsing user defined GPU devices in GpuDiscoverer

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768443#comment-16768443 ] Sunil Govindan commented on YARN-9118: -- Thanks [~snemeth] Could you please add  the Missing

[jira] [Commented] (YARN-7824) [UI2] Yarn Component Instance page should include link to container logs

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768428#comment-16768428 ] Sunil Govindan commented on YARN-7824: -- Thanks [~akhilpb] pls share branch-3.2/3.1/3.0 patches as it

[jira] [Commented] (YARN-9139) Simplify initializer code of GpuDiscoverer

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768504#comment-16768504 ] Sunil Govindan commented on YARN-9139: -- cc [~tangzhankun] could you please take a look > Simplify

[jira] [Commented] (YARN-9213) RM Web UI v1 does not show custom resource allocations for containers page

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768503#comment-16768503 ] Sunil Govindan commented on YARN-9213: -- Thanks [~snemeth] This looks good to go now. Will commit

[jira] [Commented] (YARN-8295) [UI2] The "Resource Usage" tab is pointless for finished applications

2019-02-14 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768589#comment-16768589 ] Sunil Govindan commented on YARN-8295: -- +1 I will commit tomo if there are no objections. > [UI2]

[jira] [Reopened] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

2019-02-06 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan reopened YARN-9206: -- Thanks [~kshukla]. Reopening to run jenkins > RMServerUtils does not count SHUTDOWN as an accepted

[jira] [Commented] (YARN-8498) Yarn NodeManager OOM Listener Fails Compilation on Ubuntu 18.04

2019-02-06 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762425#comment-16762425 ] Sunil Govindan commented on YARN-8498: -- +1. Lets get this in. > Yarn NodeManager OOM Listener Fails

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

2019-02-07 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762488#comment-16762488 ] Sunil Govindan commented on YARN-9206: -- re attached branch-3.1 patch to run jenkins again. >

[jira] [Updated] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

2019-02-07 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-9206: - Attachment: YARN-9206-branch-3.1.002.patch > RMServerUtils does not count SHUTDOWN as an accepted

[jira] [Commented] (YARN-9293) Optimize MockAMLauncher event handling

2019-02-11 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765043#comment-16765043 ] Sunil Govindan commented on YARN-9293: -- Yes, this looks fine. lets get this in. > Optimize

[jira] [Commented] (YARN-9099) GpuResourceAllocator.getReleasingGpus calculates number of GPUs in a wrong way

2019-01-28 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754589#comment-16754589 ] Sunil Govindan commented on YARN-9099: -- +1. Lets get this in. Committing shortly if no objections.

[jira] [Commented] (YARN-9086) [CSI] Run csi-driver-adaptor as aux service

2019-01-28 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754567#comment-16754567 ] Sunil Govindan commented on YARN-9086: -- Hi [~cheersyang] Thanks for the work. Some comments 1.

[jira] [Commented] (YARN-9086) [CSI] Run csi-driver-adaptor as aux service

2019-01-28 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754585#comment-16754585 ] Sunil Govindan commented on YARN-9086: -- +1 to latest patch. pending jenkins. > [CSI] Run

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

2019-01-29 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755646#comment-16755646 ] Sunil Govindan commented on YARN-9206: -- Sorry for the delay here.  Yes, addAll has some cost

[jira] [Commented] (YARN-9089) Add Terminal Link to Service component instance page for UI2

2019-01-25 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752079#comment-16752079 ] Sunil Govindan commented on YARN-9089: -- [~eyang] [~billie.rinaldi] Is this patch applicable for

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

2019-01-25 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752083#comment-16752083 ] Sunil Govindan commented on YARN-8914: -- Hi [~eyang] Is this patch or feature applicable in

[jira] [Commented] (YARN-8914) Add xtermjs to YARN UI2

2019-01-25 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752093#comment-16752093 ] Sunil Govindan commented on YARN-8914: -- I can see this as a new feature altogether. Hence lets keep

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

2019-01-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750881#comment-16750881 ] Sunil Govindan commented on YARN-9206: -- Thanks [~kshukla] This logic seems better as it can avoid

[jira] [Commented] (YARN-9225) user can submit applications even though they are not in the submit acl

2019-01-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750958#comment-16750958 ] Sunil Govindan commented on YARN-9225: -- [~yangjiandan] As per me, current behavior of YARN is fine.

[jira] [Commented] (YARN-9161) Absolute resources of capacity scheduler doesn't support GPU and FPGA

2019-01-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750882#comment-16750882 ] Sunil Govindan commented on YARN-9161: -- Thanks [~yuan_zac] For the first point,  # In

[jira] [Commented] (YARN-9234) NPE Exception Occurred on Resourcemanager

2019-01-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751089#comment-16751089 ] Sunil Govindan commented on YARN-9234: -- YARN-8193 should land on branch-2.9 to fix this issue.

[jira] [Commented] (YARN-8498) Yarn NodeManager OOM Listener Fails Compilation on Ubuntu 18.04

2019-01-24 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751004#comment-16751004 ] Sunil Govindan commented on YARN-8498: -- This should be fine.  Could we get this in? > Yarn

[jira] [Commented] (YARN-9194) Invalid event: REGISTERED and LAUNCH_FAILED at FAILED, and NullPointerException happens in RM while shutdown a NM

2019-01-31 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757905#comment-16757905 ] Sunil Govindan commented on YARN-9194: --

[jira] [Created] (YARN-9262) TestRMAppAttemptTransitions is failing with an NPE

2019-01-31 Thread Sunil Govindan (JIRA)
Sunil Govindan created YARN-9262: Summary: TestRMAppAttemptTransitions is failing with an NPE Key: YARN-9262 URL: https://issues.apache.org/jira/browse/YARN-9262 Project: Hadoop YARN Issue

[jira] [Comment Edited] (YARN-9194) Invalid event: REGISTERED and LAUNCH_FAILED at FAILED, and NullPointerException happens in RM while shutdown a NM

2019-01-31 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757905#comment-16757905 ] Sunil Govindan edited comment on YARN-9194 at 2/1/19 2:46 AM: --

[jira] [Commented] (YARN-9186) [CSI] Upgrade CSI proto to v1.0

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758115#comment-16758115 ] Sunil Govindan commented on YARN-9186: -- Thanks [~cheersyang] for checking CTrox driver as well. Let's

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

2019-01-31 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757915#comment-16757915 ] Sunil Govindan commented on YARN-9206: -- +1. Test case failures are not related and tracked via

[jira] [Commented] (YARN-9161) Absolute resources of capacity scheduler doesn't support GPU and FPGA

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758106#comment-16758106 ] Sunil Govindan commented on YARN-9161: -- Hi [~yuan_zac] I was trying to understand latest change in

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758200#comment-16758200 ] Sunil Govindan commented on YARN-9060: -- Hi [~tangzhankun] Sorry for this late comments. I have some

[jira] [Commented] (YARN-9262) TestRMAppAttemptTransitions is failing with an NPE

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758356#comment-16758356 ] Sunil Govindan commented on YARN-9262: -- +1. Lets get this in shortly. > TestRMAppAttemptTransitions

[jira] [Commented] (YARN-9263) TestConfigurationNodeAttributesProvider fails after Mockito updated

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758352#comment-16758352 ] Sunil Govindan commented on YARN-9263: -- +1. Committing shortly. >

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758364#comment-16758364 ] Sunil Govindan commented on YARN-9060: -- Yes, snprintf ensures a trailing /0 and hence this existing

[jira] [Commented] (YARN-9257) Distributed Shell client throws a NPE for a non-existent queue

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756934#comment-16756934 ] Sunil Govindan commented on YARN-9257: -- Change seems fine. Lets wait for jenkins. > Distributed

[jira] [Updated] (YARN-9099) GpuResourceAllocator#getReleasingGpus calculates number of GPUs in a wrong way

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil Govindan updated YARN-9099: - Summary: GpuResourceAllocator#getReleasingGpus calculates number of GPUs in a wrong way (was:

[jira] [Commented] (YARN-9250) hadoop-yarn-server-nodemanager build failed: make failed with error code 2

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756935#comment-16756935 ] Sunil Govindan commented on YARN-9250: -- Hi [~linlong], are u able to compile trunk code or similar.

[jira] [Commented] (YARN-9161) Absolute resources of capacity scheduler doesn't support GPU and FPGA

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756839#comment-16756839 ] Sunil Govindan commented on YARN-9161: -- Checking jenkins again to rule out the test failure. >

[jira] [Comment Edited] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756896#comment-16756896 ] Sunil Govindan edited comment on YARN-9060 at 1/31/19 6:01 AM: --- Thanks

[jira] [Comment Edited] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756896#comment-16756896 ] Sunil Govindan edited comment on YARN-9060 at 1/31/19 6:01 AM: --- Thanks

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756896#comment-16756896 ] Sunil Govindan commented on YARN-9060: -- Thanks [~tangzhankun]  Few comments. # In below comments,

[jira] [Commented] (YARN-9186) [CSI] Upgrade CSI proto to v1.0

2019-01-31 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757169#comment-16757169 ] Sunil Govindan commented on YARN-9186: -- Hi [~cheersyang] Do we want to support 0.3 version as well OR

[jira] [Commented] (YARN-9186) [CSI] Upgrade CSI proto to v1.0

2019-01-31 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757379#comment-16757379 ] Sunil Govindan commented on YARN-9186: -- Thanks [~cheersyang] for confirming. Since they marked as

[jira] [Commented] (YARN-9257) Distributed Shell client throws a NPE for a non-existent queue

2019-02-05 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760561#comment-16760561 ] Sunil Govindan commented on YARN-9257: -- Hi [~charanh] cud u pls share patch for branch-3.2/3.1 etc

[jira] [Commented] (YARN-9240) YARN UI 2 footer shows the datetime in different timezone

2019-01-25 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752893#comment-16752893 ] Sunil Govindan commented on YARN-9240: -- Thanks [~masatana] for reporting same. cc [~akhilpb] > YARN

[jira] [Commented] (YARN-9206) RMServerUtils does not count SHUTDOWN as an accepted state

2019-02-03 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759668#comment-16759668 ] Sunil Govindan commented on YARN-9206: -- [~kshukla] Thanks. I could commit to trunk and branch-3.2.

[jira] [Commented] (YARN-9262) TestRMAppAttemptTransitions is failing with an NPE

2019-02-04 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759689#comment-16759689 ] Sunil Govindan commented on YARN-9262: -- Thanks [~cheersyang]. backported to branch-3.2 and

<    4   5   6   7   8   9   10   11   >