Re: [yocto] [RFC v2 00/18][eclipse-poky] Storing yocto settings as target profiles

2013-02-03 Thread Timo Müller
Hi Jessica, Zhang, Jessica wrote, On 31.01.2013 20:28: Hi Timo, I'm having a hard time figuring out the sequence of this patch series. You have 01/18-09/18, then 10/17 is obsolete, then you have things > like 12/18 and 12/17 and some have XX/18 and some have XX/17. Sorry, for this mess! I acc

[yocto] [RFC v3 03/18] plugins/sdk.ide: Add method to enable and disable form

2013-02-03 Thread Timo Mueller
From: Atanas Gegov The YoctoUISetting form as a whole can be disabled and enabled using this method. A disabled form can for example show a read-only yocto configuration. Signed-off-by: Timo Mueller --- .../src/org/yocto/sdk/ide/YoctoUISetting.java | 44 ++ 1 file chan

[yocto] [RFC v3 02/18] plugins/sdk.ide: Extract labels to private members

2013-02-03 Thread Timo Mueller
From: Atanas Gegov Extracting the labels as private members allows the modification of the label settings after creation. This is will allow disabling and enabling the labels after creation of the form. Signed-off-by: Timo Mueller --- .../src/org/yocto/sdk/ide/YoctoUISetting.java

[yocto] [RFC v3 04/18] plugins/sdk.ide: Set value of target array on input change

2013-02-03 Thread Timo Mueller
From: Atanas Gegov The value of the target array set in the constructor is now also affected when the input of the element is changed. Signed-off-by: Timo Mueller --- plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plug

[yocto] [RFC v3 01/18] plugins/sdk.ide: Removed unused message

2013-02-03 Thread Timo Mueller
From: Timo Mueller The dialog has been merged with the project settings. Therefor the message is no longer needed. Signed-off-by: Timo Mueller --- .../org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKMessages.properties | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/org.yocto.sdk.

[yocto] [RFC v3 00/18][eclipse-poky] Storing yocto settings as target profiles

2013-02-03 Thread Timo Mueller
From: Timo Mueller Hi, thanks for the feedback, I did some changes to the patch series accordingly. First of all I've fixed the issues with the patches (duplicate method, missing fix for NewYoctoCProjectTemplate.java). I also changed the functionality of the "new" button according to Jessica's

[yocto] [RFC v3 05/18] plugins/sdk.ide: Changed method signature to be more consistent

2013-02-03 Thread Timo Mueller
From: Timo Mueller YoctoUIElement should always be the first element, e.g. as in saveElemToStore(). Signed-off-by: Timo Mueller --- plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKUtils.java | 2 +- .../src/org/yocto/sdk/ide/preferences/YoctoSDKProjectPropertyPage.java | 2 +- 2

[yocto] [RFC v3 08/18] plugins/sdk.ide: Set profile on selection change

2013-02-03 Thread Timo Mueller
From: Timo Mueller When a profile is selected through the combo box the value of the profileElement changed to contain the selected profile. Signed-off-by: Timo Mueller --- .../src/org/yocto/sdk/ide/YoctoProfileSetting.java | 23 ++ 1 file changed, 23 insertions(+) diff --

[yocto] [RFC v3 09/18] plugins/sdk.ide: Add method to allow storing the current settings

2013-02-03 Thread Timo Mueller
From: Timo Mueller The added method calls the performOK method on the provided preference page to store the current content of the page. This callback is needed so the profile UI is able to propagate changes to the preference page it is part of. Signed-off-by: Timo Mueller --- .../src/org/yoc

[yocto] [RFC v3 06/18] plugins/sdk.ide: Create UI element for managing target profiles.

2013-02-03 Thread Timo Mueller
From: Atanas Gegov A target profile is a combination of yocto settings identified by a user-defined name. This UI element allows the user to add new profiles and to rename or delete existing ones. Signed-off-by: Timo Mueller --- .../src/org/yocto/sdk/ide/YoctoProfileElement.java | 104

[yocto] [RFC v3 13/18] plugins/sdk.ide: Add method to change values of the preference page

2013-02-03 Thread Timo Mueller
From: Timo Mueller When switching profile the values of the profile are retrieved from the preference store. The UI is updated using the retrieved values. Signed-off-by: Timo Mueller --- .../org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java | 4 1 file changed, 4 insertion

[yocto] [RFC v3 14/18] plugins/sdk.ide: Add method to rename a profile and its preference store

2013-02-03 Thread Timo Mueller
From: Timo Mueller When renaming a profile the current values are stored in the profile's new preference store. Signed-off-by: Timo Mueller --- .../org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java | 4 1 file changed, 4 insertions(+) diff --git a/plugins/org.yocto.sdk.i

[yocto] [RFC v3 11/18] plugins/sdk.ide: Add UI method to delete a profile

2013-02-03 Thread Timo Mueller
From: Timo Mueller A profile is removed from the list, when the delete button is clicked. The deletion has to be confirmed by the user. Deleting the standard profile is not allowed. Signed-off-by: Timo Mueller --- .../src/org/yocto/sdk/ide/YoctoProfileSetting.java | 34 ++

[yocto] [RFC v3 12/18] plugins/sdk.ide: Add UI method to rename a profile

2013-02-03 Thread Timo Mueller
From: Timo Mueller When the rename button is clicked a dialog shows up and the user has to provide the new name for the profile. The validity of the name is checked during input. If the name is valid and the users confirms the profile is renamed. Renaming the standard profile is not allowed. Sig

[yocto] [RFC v3 07/18] plugins/sdk.ide: Modified preferences storage to support profiles.

2013-02-03 Thread Timo Mueller
From: Timo Mueller Yocto preferences are now stored using a user-defined name that identifies a target profile. To store these preferences eclipse' scoped preferences provider is used. The filename in the eclipse configuration area is derived from the unique target profile name. Signed-off-by: T

[yocto] [RFC v3 10/18] plugins/sdk.ide: Add UI method to create a new profile

2013-02-03 Thread Timo Mueller
From: Timo Mueller When the save as button is clicked a dialog shows up and the user has to provide the name of the new profile. The validity of the name is checked during input. If the name is valid and the users confirms the new profile is created from the current input of the yocto settings fo

[yocto] [RFC v3 15/18] plugins/sdk.ide: Add method to delete a profile

2013-02-03 Thread Timo Mueller
From: Timo Mueller Deletion of a profile currently has no effects on the preference page. Signed-off-by: Timo Mueller --- .../org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java | 4 1 file changed, 4 insertions(+) diff --git a/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/i

[yocto] [RFC v3 18/18] plugins/sdk.ide: Moved save as button to bottom of preference page

2013-02-03 Thread Timo Mueller
From: Timo Mueller Signed-off-by: Timo Mueller --- .../src/org/yocto/sdk/ide/YoctoProfileSetting.java | 18 -- .../sdk/ide/preferences/YoctoSDKPreferencePage.java | 21 + 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/plugins/org.yocto.sd

[yocto] [RFC v3 17/18] plugins/sdk.ide: Added profile UI to the preference page

2013-02-03 Thread Timo Mueller
From: Timo Mueller Adds the UI elements that allow managing profiles to the preference page. Signed-off-by: Timo Mueller --- .../src/org/yocto/sdk/ide/preferences/YoctoSDKPreferencePage.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/org.yocto.sdk.ide/s

[yocto] [RFC v3 16/18] plugins/sdk.ide: Use profiles for the preference page

2013-02-03 Thread Timo Mueller
From: Timo Mueller The preference page is now aware of profiles. By default the standard profile is used and the values are stored to its preference store. If a different profile is selected it's preferences store is used instead. Signed-off-by: Timo Mueller --- .../ide/preferences/YoctoSDKPre