This is the summary for test reports received on the
zope-tests list between 2013-09-16 00:00:00 UTC and 2013-09-17 00:00:00 UTC:
See the footnotes for test reports of unsuccessful builds.
An up-to date view of the builders is also available in our
buildbot documentation:
http://docs.zope.org/
On Tue, Sep 17, 2013 at 09:35:58AM -0400, Jim Fulton wrote:
> On Tue, Sep 17, 2013 at 8:58 AM, Marius Gedminas wrote:
> > FWIW the only reason I'm in favour of self-merges is that this
> > short-circuits the "have you signed the ZF committer agreement?" dance.
> > Only people who have can merge.
>
Certain Subversion commits show up on the checkins@ list misattributed
to "Marius Gedminas ". Examples:
r130062 - https://mail.zope.org/pipermail/checkins/2013-March/065903.html
r130296 - https://mail.zope.org/pipermail/checkins/2013-August/067498.html
r130309 - https://mail.zope.org/piperm
On 9/17/13 3:32 PM, Jim Fulton wrote:
On Tue, Sep 17, 2013 at 8:32 AM, Jan-Wijbrand Kolman
Is this "reviewer role" something someone takes upon himself? I mean, if I
see a pull request for a code base that I know, I could review the request?
These are good questions. I probably don't have sat
On Tue, Sep 17, 2013 at 8:58 AM, Marius Gedminas wrote:
> On Tue, Sep 17, 2013 at 07:47:42AM -0400, Jim Fulton wrote:
>> On Tue, Sep 17, 2013 at 7:00 AM, Marius Gedminas wrote:
>> >> Now that I mended the pull request, should I merge the pull request
>> >> myself? Or is the current etiquette that
On Tue, Sep 17, 2013 at 8:32 AM, Jan-Wijbrand Kolman
wrote:
> On 9/17/13 1:47 PM, Jim Fulton wrote:
>>
>> I strongly prefer that the reviewer do the merge.
>>
>> I'd also really like reviewers to take their responsibility
>> seriously, making comments and suggestions where appropriate.
>>
>> Softw
On Tue, Sep 17, 2013 at 07:47:42AM -0400, Jim Fulton wrote:
> On Tue, Sep 17, 2013 at 7:00 AM, Marius Gedminas wrote:
> >> Now that I mended the pull request, should I merge the pull request
> >> myself? Or is the current etiquette that someone else should merge
> >> the pull request?
> >
> > I th
On 9/17/13 1:47 PM, Jim Fulton wrote:
I strongly prefer that the reviewer do the merge.
I'd also really like reviewers to take their responsibility
seriously, making comments and suggestions where appropriate.
Software review, done well, improves the software, and, more
importantly, improves th
On Tue, Sep 17, 2013 at 7:00 AM, Marius Gedminas wrote:
...
>> 2) fork the repository, make a branch in the fork, do my work, push
>> the changes to my fork, and issue a pull request.
>>
>> The latter is what I did, without explicitly asking for feedback.
>> Luckily someone did give me feedback (t
On 9/17/13 1:00 PM, Marius Gedminas wrote:
On Tue, Sep 17, 2013 at 12:04:04PM +0200, Jan-Wijbrand Kolman wrote:
I wonder if there is a formal or informal write-up of how to
"nicely" contribute code to the repositories under the
zopefoundation umbrella.
I don't think so. I'd like to see one.
On 9/17/13 12:04 PM, Jan-Wijbrand Kolman wrote:
snip
2) fork the repository, make a branch in the fork, do my work, push the
changes to my fork, and issue a pull request.
The latter is what I did, without explicitly asking for feedback.
Luckily someone did give me feedback (thanks!) :-)
Now tha
On Tue, Sep 17, 2013 at 12:04:04PM +0200, Jan-Wijbrand Kolman wrote:
> I wonder if there is a formal or informal write-up of how to
> "nicely" contribute code to the repositories under the
> zopefoundation umbrella.
I don't think so. I'd like to see one.
> Back in the subversion days I would bra
Hi,
I wonder if there is a formal or informal write-up of how to "nicely"
contribute code to the repositories under the zopefoundation umbrella.
Back in the subversion days I would branch a project, amend code, write
tests, commit this to the repository, ask for feedback on the list, and,
wh
13 matches
Mail list logo
