Dennis Allison wrote:
Dieter's point about not includeing the traceback makes sense
if all it does is report on the reporting code.
Yeah, the traceback just shows where the ConflictError was raised, not
what caused it, and theyr'e always in very different places...
Wlorent, do you envision
Florent Guillaume wrote:
If you look at the way their purpose is explained in zLOG, you'll see
that level INFO is reserved for things like server startup and
shutdown.
You must be one of the few humans who's ever read that documentation ;-)
recurring that can happen many times in the lif
Dieter's point about not includeing the traceback makes sense
if all it does is report on the reporting code.
Wlorent, do you envision a single ConflicError or two -- one which
succeeds on retry and another where the retry fails?
On Sun, 4 Dec 2005, Dieter Maurer wrote:
> Florent Guillaume wro
Florent Guillaume wrote at 2005-12-2 22:59 +0100:
> ...
>If you look at the way their purpose is explained in zLOG, you'll see
>that level INFO is reserved for things like server startup and
>shutdown.
>Or, as shown above, initial mounting of databases. Anything
>recurring that can happen man
Paul Winkler wrote:
I'm +1 on having failed retries show up at level ERROR.
With Florent's changes you get 'em twice, with mine, you get 'em once ;-)
I'm neutral on having successful retries show up at level INFO, BLATHER,
or in some other log handler entirely. Conflict errors are a pretty
On 2 Dec 2005, at 20:50, Dieter Maurer wrote:
Florent Guillaume wrote at 2005-12-2 13:33 +0100:
...
Please no. Don't put anything at INFO. A conflict error is either
something normal that should be at level BLATHER or below, or an
ERROR that a sysadmin wants to see logged as such.
I strongly
On 2 Dec 2005, at 20:40, Dieter Maurer wrote:
Florent Guillaume wrote at 2005-12-1 19:49 +0100:
I've improved the logging of ConflictError in Zope 2.9 and trunk.
http://svn.zope.org/?rev=40454&view=rev
Now you'll get two things:
- logs at level BLATHER for each conflict, but it may be retried
Florent Guillaume wrote at 2005-12-2 13:33 +0100:
> ...
>Please no. Don't put anything at INFO. A conflict error is either
>something normal that should be at level BLATHER or below, or an
>ERROR that a sysadmin wants to see logged as such.
I strongly disagree with you:
"ConflictError"s are
Florent Guillaume wrote at 2005-12-1 19:49 +0100:
>I've improved the logging of ConflictError in Zope 2.9 and trunk.
>
>http://svn.zope.org/?rev=40454&view=rev
>
>Now you'll get two things:
>- logs at level BLATHER for each conflict, but it may be retried
>- log at level ERROR when the conflict can
On Fri, Dec 02, 2005 at 02:09:56PM +0100, Florent Guillaume wrote:
> On 2 Dec 2005, at 11:09, Chris Withers wrote:
> >I was planning on rolling my changes out to 2.8, 2.9 and the trunk.
> >Unless anyone strenuously objects, I still intend to do that. I
> >cleaned up a lot of the code and made a
On 2 Dec 2005, at 14:16, Chris Withers wrote:
Please no. Don't put anything at INFO. A conflict error is either
something normal that should be at level BLATHER or below, or an
ERROR that a sysadmin wants to see logged as such.
Not so. If I'm getting 1,000 resolved conflict errors a day,
Florent Guillaume wrote:
Please no. Don't put anything at INFO. A conflict error is either
something normal that should be at level BLATHER or below, or an ERROR
that a sysadmin wants to see logged as such. INFO sucks for recurring
stuff like that that in addition contain the word "error" w
Florent Guillaume wrote:
Please no. Don't put anything at INFO. A conflict error is either
something normal that should be at level BLATHER or below, or an ERROR
that a sysadmin wants to see logged as such.
Incidentally, your changes result in most users seeing two errors in
their logs whe
Florent Guillaume wrote:
It doesn't really matter, zLOG has a compatibility layer that ends up
doing the same thing.
python's logging module has a cleaner, nicer syntax.
Please no. Don't put anything at INFO. A conflict error is either
something normal that should be at level BLATHER or bel
On 2 Dec 2005, at 11:09, Chris Withers wrote:
I was planning on rolling my changes out to 2.8, 2.9 and the trunk.
Unless anyone strenuously objects, I still intend to do that. I
cleaned up a lot of the code and made a few other changes that
generally improve logging.
I strenuously object t
On 2 Dec 2005, at 11:09, Chris Withers wrote:
Damn, I was working on this at the same time :-S
Florent Guillaume wrote:
I've improved the logging of ConflictError in Zope 2.9 and trunk.
http://svn.zope.org/?rev=40454&view=rev
Now you'll get two things:
- logs at level BLATHER for each conflict,
Hi Florent,
Damn, I was working on this at the same time :-S
Florent Guillaume wrote:
I've improved the logging of ConflictError in Zope 2.9 and trunk.
http://svn.zope.org/?rev=40454&view=rev
Now you'll get two things:
- logs at level BLATHER for each conflict, but it may be retried
- log at
+1
On Dec 1, 2005, at 1:49 PM, Florent Guillaume wrote:
I've improved the logging of ConflictError in Zope 2.9 and trunk.
http://svn.zope.org/?rev=40454&view=rev
Now you'll get two things:
- logs at level BLATHER for each conflict, but it may be retried
- log at level ERROR when the conflict
I've improved the logging of ConflictError in Zope 2.9 and trunk.
http://svn.zope.org/?rev=40454&view=rev
Now you'll get two things:
- logs at level BLATHER for each conflict, but it may be retried
- log at level ERROR when the conflict can't be retried anymore and is
returned to the browser as
19 matches
Mail list logo