Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-23 Thread Christian Theune
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 12/21/2009 10:27 PM, Lennart Regebro wrote: | On Mon, Dec 21, 2009 at 22:23, Marius Gedminasmar...@gedmin.as wrote: | On Mon, Dec 21, 2009 at 07:41:24PM +0100, Lennart Regebro wrote: | On Mon, Dec 21, 2009 at 13:20, Marius

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-23 Thread Lennart Regebro
On Wed, Dec 23, 2009 at 10:25, Christian Theune c...@gocept.com wrote: Is this about getting rid of our own doctest and relying on Python's standard doctest module? The deprecations are, yes. The problem (which has now been fixed) is that some BBB imports was not marked as being BBB imports and

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-22 Thread Marius Gedminas
On Mon, Dec 21, 2009 at 10:27:01PM +0100, Lennart Regebro wrote: I added the imports back, and also some deprecation warnings, although I'm not sure how to best add them, Maybe zope.deprecation can help? so I just stuck them in the modules, so the first import will raise a warning. A new

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-22 Thread Lennart Regebro
On Tue, Dec 22, 2009 at 10:26, Marius Gedminas mar...@gedmin.as wrote: On Mon, Dec 21, 2009 at 10:27:01PM +0100, Lennart Regebro wrote: I added the imports back, and also some deprecation warnings, although I'm not sure how to best add them, Maybe zope.deprecation can help? I didn't find

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-21 Thread Lennart Regebro
On Sun, Dec 20, 2009 at 23:55, Marius Gedminas mar...@gedmin.as wrote: I don't know if 'doctestunit' was ever a part of the official zope.testing API, I just know that I've learned to use I've looked through the history of doctestunit, and it seems like it once was. This was changed 5 years

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-21 Thread Marius Gedminas
On Mon, Dec 21, 2009 at 10:32:42AM +0100, Lennart Regebro wrote: On Sun, Dec 20, 2009 at 23:55, Marius Gedminas mar...@gedmin.as wrote: I don't know if 'doctestunit' was ever a part of the official zope.testing API, I just know that I've learned to use So, Monday! I take a deeper look at

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-21 Thread Marius Gedminas
On Mon, Dec 21, 2009 at 02:20:54PM +0200, Marius Gedminas wrote: On Mon, Dec 21, 2009 at 10:32:42AM +0100, Lennart Regebro wrote: On Sun, Dec 20, 2009 at 23:55, Marius Gedminas mar...@gedmin.as wrote: I don't know if 'doctestunit' was ever a part of the official zope.testing API, I just

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-21 Thread Lennart Regebro
On Mon, Dec 21, 2009 at 13:20, Marius Gedminas mar...@gedmin.as wrote: Can you please make it a PendingDeprecationWarning first? Yeah, I guess, but why? Yes, it had bugfixes, and I have monkey-patches of doctest in the branch to fix them. But it's not like they are going to get fixed in 2.4

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-21 Thread Marius Gedminas
On Mon, Dec 21, 2009 at 07:41:24PM +0100, Lennart Regebro wrote: On Mon, Dec 21, 2009 at 13:20, Marius Gedminas mar...@gedmin.as wrote: Can you please make it a PendingDeprecationWarning first? Yeah, I guess, but why? Because I hate it when my code emits DeprecationWarnings, and I wasn't

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-21 Thread Lennart Regebro
On Mon, Dec 21, 2009 at 22:23, Marius Gedminas mar...@gedmin.as wrote: On Mon, Dec 21, 2009 at 07:41:24PM +0100, Lennart Regebro wrote: On Mon, Dec 21, 2009 at 13:20, Marius Gedminas mar...@gedmin.as wrote: Can you please make it a PendingDeprecationWarning first? Yeah, I guess, but why?

[Zope-dev] zope.testing.doctestunit and BBB

2009-12-20 Thread Marius Gedminas
My app's buildbot went all red last night, because its config wants the latest zope.testing (for our developers' convenience), and the latest zope.testing release no longer ships its own copy of doctest.py, I guess: from zope.testing.doctestunit import DocTestSuite ImportError: cannot import

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-20 Thread Lennart Regebro
On Sun, Dec 20, 2009 at 17:36, Marius Gedminas mar...@gedmin.as wrote: My app's buildbot went all red last night, because its config wants the latest zope.testing (for our developers' convenience), and the latest zope.testing release no longer ships its own copy of doctest.py, I guess: No,

Re: [Zope-dev] zope.testing.doctestunit and BBB

2009-12-20 Thread Marius Gedminas
On Sun, Dec 20, 2009 at 11:12:14PM +0100, Lennart Regebro wrote: On Sun, Dec 20, 2009 at 17:36, Marius Gedminas mar...@gedmin.as wrote: My app's buildbot went all red last night, because its config wants the latest zope.testing (for our developers' convenience), and the latest zope.testing