Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/api-var-annot into lp:zorba

2014-05-07 Thread Federico Cavalieri
Review: Approve I have the same question as Matthias, maybe it make sense to offer the feature for all module level variable declarations. Apart from that, it looks good. -- https://code.launchpad.net/~zorba-coders/zorba/api-var-annot/+merge/218485 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-boost-typedef into lp:zorba

2014-05-01 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-boost-typedef/+merge/217976 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-boost-typedef into lp:zorba

2014-05-01 Thread Federico Cavalieri
The choice of the data structure to hold the flags is open to discussion. I considered: - std::bitset - uint64 - vectorbool (storage optimized specialization is mandated by the standard) The size of std::bitset is determined at compile time, boost:dynamic_bitset brings the boost dependency,

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-boost-typedef into lp:zorba

2014-05-01 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/fix-boost-typedef into lp:zorba. Commit message: Removed boost dependency Fixed typedef Requested reviews: Matthias Brantner (matthias-brantner) Federico Cavalieri (fcavalieri) Paul J. Lucas (paul-lucas) For more details, see

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-caching into lp:zorba

2014-04-17 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-caching/+merge/216291 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-caching-annotations into lp:zorba

2014-04-17 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-caching-annotations/+merge/216293 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/feature-caching. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-update into lp:zorba

2014-04-16 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/http-client-update/+merge/216204 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-update into lp:zorba

2014-04-16 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/http-client-update into lp:zorba. Commit message: Updated http client with deterministic send-request functions, improved documentation, transparent retries and patch method support. Requested reviews: Matthias Brantner (matthias

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fncall-iterator into lp:zorba

2014-04-15 Thread Federico Cavalieri
I found a regression, investigating -- https://code.launchpad.net/~zorba-coders/zorba/fix-fncall-iterator/+merge/215934 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fncall-iterator into lp:zorba

2014-04-15 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-fncall-iterator/+merge/215934 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-external_func_exceptions into lp:zorba

2014-01-09 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-external_func_exceptions/+merge/200922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-accesses-dyn-ctx into lp:zorba

2014-01-02 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/fix-accesses-dyn-ctx into lp:zorba. Commit message: Fixed dynamic context access declaration in the General Functions and Operators on Sequences module Requested reviews: Federico Cavalieri (fcavalieri) For more details, see

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-accesses-dyn-ctx into lp:zorba

2014-01-02 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-accesses-dyn-ctx/+merge/200322 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-random-annotation into lp:zorba

2013-12-20 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation/+merge/199706 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-dbedit-parse-xml-segfault into lp:zorba

2013-12-20 Thread Federico Cavalieri
Review: Approve Validation queue result for https://code.launchpad.net/~zorba-coders/zorba /fix-dbedit-parse-xml-segfault/+merge/199707 Stage CommitZorba failed. Check console output at http://jenkins.lambda.nu:8180/job/CommitZorba/260/console to view the results. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-random-annotation into lp:zorba

2013-12-19 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/fix-random-annotation into lp:zorba. Commit message: Fixed random#0 function annotation. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-dbedit-parse-xml-segfault into lp:zorba

2013-12-19 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/fix-dbedit-parse-xml-segfault into lp:zorba. Commit message: Fixed db:edit and fn:parse-xml segfault Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-dbedit

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-30 Thread Federico Cavalieri
Thanks for the feedback. Merging -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-16 Thread Federico Cavalieri
Thanks for the review. Can you explain me why SYNC_CODE(theCollection-theLatch.rlock();) and SYNC_CODE(theCollection-theLatch.unlock();) has been commented in this branch? They were already commented in the branch when I started working on it. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Federico Cavalieri
Ready for review -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Federico Cavalieri
nope, let me fix it On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny ghislain.fou...@28msec.com wrote: One of the tests uses ext:nomaterialization without dash. Is this intented? -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Federico Cavalieri
Fixed and pushed On Wed, Aug 14, 2013 at 9:36 PM, Federico Cavalieri federico.cavali...@28msec.com wrote: nope, let me fix it On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny ghislain.fou...@28msec.com wrote: One of the tests uses ext:nomaterialization without dash. Is this intented

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1207668 into lp:zorba

2013-08-02 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/bug1207668 into lp:zorba. Commit message: Fixed bug 1207668 Requested reviews: Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1207668/+merge/178223 Fixed bug

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-08-02 Thread Federico Cavalieri
- The indentation has several problems. Could you please make it consistent. Especially in the C++ code. sure. - Why don't you use the same approach as we did for xbrl-cloud and keep the connection map in JSONiq (using the map module)? I think that would be more appropriate for this module

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-external-cloudant-module into lp:zorba

2013-08-02 Thread Federico Cavalieri
Module in lp:~zorba-coders/zorba/cloudant-module -- https://code.launchpad.net/~zorba-coders/zorba/feature-external-cloudant-module/+merge/178255 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-08-02 Thread Federico Cavalieri
Review: Resubmit External module merge proposal in lp:~zorba-coders/zorba/feature-external-cloudant-module and lp:~zorba-coders/zorba/cloudant-module -- https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-29 Thread Federico Cavalieri
I did not find a description of the process necessary to propose a new module in the wiki. What should I do? Thanks -- https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Federico Cavalieri
Given the comments I received for the http-module I fear that the way I am disconnecting from cloudant is not correct, because curl_global_init/cleanup must not be called multiple times from different modules. I tried disconnecting invoking an XQuery function but this does not work because the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Federico Cavalieri
Hi Chris, thanks for the quick review. I think it is currently a core module due to the auto-disconnect functionality. External module can have cpp external functions? However, as I wrote in my previous comment, this feature is almost certainly wrong at the moment. If I recall correctly,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Federico Cavalieri
Actually, a few code problems: 1. ConnectionMap::destroy() invokes a function in the http://28msec.io/modules/cloudant namespace. I think that should be in http://zorba.io/modules/cloudant, right? This is commented out :) I tried doing it in XQuery but I didn't manage so I left the code

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Federico Cavalieri
Ahh, I see, that call in ConnectionMap::destroy() is commented out. Didn't notice that the first time. Regarding the curl disconnect problems: That would all go away if this module used the http-client module, rather than using C++ to invoke CURL directly. Is there a reason this module

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-26 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module has been updated. Commit Message changed to: Updated the expath http client on top of the json http client For more details, see:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-26 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module has been updated. Commit Message changed to: Updated the expath http client to use the json http client For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Federico Cavalieri
I agree that an external module is best suited for this module. I will look in the wiki to see the submit procedure. -- https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-25 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has been updated. Commit Message changed to: Added JSON HTTP client module. Fixed initialization, error reporting and encoding bugs in the XML HTTP client. Reimplemented XML HTTP client on top of the JSON HTTP client

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module

2013-07-25 Thread Federico Cavalieri
Review: Needs Information 1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the public API exactly the same, as defined by EXpath? I understand the implementation is different, but I don't believe that's relevant for module versioning. 2. (Possibly the same question)

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba

2013-07-25 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module

2013-07-25 Thread Federico Cavalieri
Depends on lp:~zorba-coders/zorba/http-client-wrapper -- https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578 Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba

2013-07-25 Thread Federico Cavalieri
To avoid replicating conversion code (600-700 lines) between the core XML http client and the Expath http client as discussed in: https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578 I introduced a wrapper module for doing all conversions. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-25 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module. Requested reviews: Cezar Andrei (cezar-andrei) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-25 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-25 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module. Requested reviews: Cezar Andrei (cezar-andrei) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-25 Thread Federico Cavalieri
Ready for review. This is updates the expath http client to be based on the wrapper module introduced in lp:~zorba-coders/zorba/http-client-wrapper The comments of the previous branch (outdated links, wrapper conversion module) have been addressed. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba

2013-07-25 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba has been updated. Commit Message changed to: HTTP client request/response conversion in a separate module For more details, see: https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-25 Thread Federico Cavalieri
Apparently the Expath HTTP Client queries 2 and 3 fail on the zorba demo website (http://zorbawebsite2.my28msec.com/html/demo) This does not seem to depend on the latest http client merge which apparently is not there yet. Is this a known problem? --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-24 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-24 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-19 Thread Federico Cavalieri
Chris, thanks for the comments. I think I resolved all reported issues with the module. The old http module is xquery only now. I also did a cleaning pass over the cpp and removed two small initialization bugs. -- https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-12 Thread Federico Cavalieri
The old http-module when you send an http-request, specifying a non textual mime-type, the current http-client invokes the serializer specifiying the (unaccessible from XQuery code) binary method. If the body is an xml node it gets converted in a very strange way: hellothere/hello becomes

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-12 Thread Federico Cavalieri
The old http-module when you send an http-request, specifying a non textual mime-type, the current http-client invokes the serializer specifiying the (unaccessible from XQuery code) binary method. I meant The old http-module when you send an http-request, specifying a non textual

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-09 Thread Federico Cavalieri
Thank you for your feedback. 3. The module error codes need to be changed to match the coding guidelines: http://my.zorba.io/dokuwiki/doku.php?id=coding-guidelines#error_codes I updated the error codes according to the guidelines --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-09 Thread Federico Cavalieri
1. OMG code duplication: the entire contents of http-client.xq.src is copied (and modified?) from the original http-client module. That's nearly 3000 lines of some of the ugliest and most error-filled code we've got. No way do we want to maintain two copies of it. Also, they both call

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-21 Thread Federico Cavalieri
I merged the trunk into the branch and added the ability to use hexbinary as a body type. Note that this required a further API extension beside in addtion to the hexbinary stream which has been merged into the trunk a few hours ago. Removed the jsoniq note from docs --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-20 Thread Federico Cavalieri
In the Doc examples use WWW.zorba.io... but the module is registered without WWW: xqDoc: import module namespace http=http://www.zorba.io/modules/http-client;; http:get(http://www.example.com;) Fixed timeout option has a bug. Uncomment timeout in the following script and get this

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-20 Thread Federico Cavalieri
Cezar, it is not necessary for users to have a jsoniq version header in their queries to use this module. They can use (field) object accessors instead of .field . My point was to mention these options somewhere in the doc and link to a page which better describes this. IMHO it's

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-20 Thread Federico Cavalieri
Cezar, it is not necessary for users to have a jsoniq version header in their queries to use this module. They can use (field) object accessors instead of .field . My point was to mention these options somewhere in the doc and link to a page which better describes this. IMHO it's

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1189636 into lp:zorba

2013-06-20 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1189636/+merge/170471 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1189636 into lp:zorba

2013-06-20 Thread Federico Cavalieri
The proposal to merge lp:~paul-lucas/zorba/bug-1189636 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/bug-1189636/+merge/170471 -- https://code.launchpad.net/~paul-lucas/zorba/bug-1189636/+merge/170471

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/nullcasts into lp:zorba

2013-05-28 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/nullcasts into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/nullcasts/+merge/166094 -- https://code.launchpad.net/~zorba-coders/zorba/nullcasts/+merge/166094

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-05-20 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/164563 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

[Zorba-coders] [Bug 912586] Re: Zorba Internal Fatal error when applying a PUL changes the type of a typed node

2012-01-24 Thread Federico Cavalieri
** Changed in: zorba Assignee: Federico Cavalieri (fcavalieri) = Cezar Andrei (cezar-andrei) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/912586 Title: Zorba Internal Fatal error when

[Zorba-coders] [Bug 912722] Re: A validate lax {}-validated element may cause assertion failures

2012-01-24 Thread Federico Cavalieri
** Changed in: zorba Assignee: Federico Cavalieri (fcavalieri) = Cezar Andrei (cezar-andrei) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/912722 Title: A validate lax {}-validated

[Zorba-coders] [Bug 912593] Re: Validate in-place causes Zorba Internal Fatal error if a node which might have a simple type contains other nodes

2012-01-24 Thread Federico Cavalieri
** Changed in: zorba Assignee: Federico Cavalieri (fcavalieri) = (unassigned) ** Changed in: zorba Assignee: (unassigned) = Cezar Andrei (cezar-andrei) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-01-24 Thread Federico Cavalieri
I transferred the bugs to Cezar, thanks. They are blocking the merge of the PUL production/application. When those are fixed I think there will be another very small issue to cope with validation, which occur when I try to validate an element against a specific type definition. However, maybe

[Zorba-coders] [Bug 912722] [NEW] A validate lax {}-validated element may cause assertion failures

2012-01-06 Thread Federico Cavalieri
- COMMAND LINE: /home/federico/zorba/build/bugs2/bin/zorba -f -q /home/federico/zorba/repository/bugs2/./test/rbkt/Queries/zorba/updates/upd14.xq - ** Affects: zorba Importance: High Assignee: Federico Cavalieri (fcavalieri) Status: New -- You

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs2 into lp:zorba

2012-01-06 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~fcavalieri/zorba/bugs2 into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs2/+merge/87749 Fixed bug #912586, #912593 and #912722 (assertion failures with lax

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs2 into lp:zorba

2012-01-06 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/bugs2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs2/+merge/87749 -- https://code.launchpad.net/~fcavalieri/zorba/bugs2/+merge/87749 Your team Zorba Coders

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2012-01-06 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/87750 -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/87750 Your team Zorba Coders is

[Zorba-coders] [Bug 912586] Re: Zorba Internal Fatal error when applying a PUL changes the type of a typed node

2012-01-05 Thread Federico Cavalieri
/home/federico/zorba/build/bugs2/src/libzorba_simplestore.so.2.1.0(+0x9e8f99) [0x7ff30bbf5f99] /home/federico/zorba/build/bugs2/src/libzorba_simplestore.so.2.1.0(+0x9e9066) [0x7ff30bbf6066] /home/federico/zorba/build/bugs2/src/libzorba_simplestore.so.2.1.0(+0x1217b7d) [0x7ff30c424b7d]

[Zorba-coders] [Bug 912586] [NEW] Zorba Internal Fatal error when applying a PUL changes the type of a typed node

2012-01-05 Thread Federico Cavalieri
/ /xs:restriction /xs:simpleType xs:simpleType name=cType xs:restriction base=xs:string xs:maxLength value=50/ /xs:restriction /xs:simpleType /xs:schema ** Affects: zorba Importance: High Assignee: Federico Cavalieri (fcavalieri) Status: New -- You

[Zorba-coders] [Bug 912593] [NEW] Validate in-place causes Zorba Internal Fatal error if a node which might have a simple type contains other nodes

2012-01-05 Thread Federico Cavalieri
; xmlns=http://www.zorba-xquery.org/schema; elementFormDefault=qualified xs:element name=root type=xs:int/ /xs:schema ** Affects: zorba Importance: High Assignee: Federico Cavalieri (fcavalieri) Status: New -- You received this bug notification because you

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-24 Thread Federico Cavalieri
Second, when you say that you rely on it, does it mean that you may need to compare 2 node positions that were obtained in different snapshots? And if so, do you expect that the result of such a comparison says anything about the positional relationship of the two corresponding nodes at any

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-20 Thread Federico Cavalieri
Connection dropped... Do you know why document nodes have a component less than any other kind of node when they are the root of their tree? I finally found out what you meant (the code is in the OrdPathNode ctor, not the OrdPath ctor). I think the reason why element node as root

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-17 Thread Federico Cavalieri
Hi Markos, i noticed that the parse uri function now uses strtoul without checking errno with the following effects: A missing component is considered 0: np:in-same-tree-of(xs:anyURI(zorba:..1.50),xs:anyURI(zorba:0.0.1.50)) -true Out of ulong value-space == ULONG_MAX

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Federico Cavalieri
Renamed the module and function to node-position. How should I replace structural information in the functions comments? node position uri? -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Federico Cavalieri
Should StructuralAnyUriItem::isDescendant() check that the other node is not an attribute? Yes, you are right! Descendant doesn't include attributes. May I add a in-subtree-of function with the same semantics as the current descendant? Thanks Federico --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Federico Cavalieri
Federico, I don't think it is necessary to put the position uris into the uri pool because they are not likely to be shared by multiple data items so you won't really be saving much space (you may be actually end-up wasting space because the uri pool storage has some overhead by itself). Do

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba

2011-10-13 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 --

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba

2011-10-13 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 --

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba

2011-10-13 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 --

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 --

[Zorba-coders] [Bug 872799] Re: validate-in-place can set incorrect types

2011-10-13 Thread Federico Cavalieri
** Changed in: zorba Status: New = Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/872799 Title: validate-in-place can set incorrect types Status in Zorba - The XQuery

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
Sure, but to me it looks like no change has been made at all (Preview Diff contains only the word Empty) and no In a few minutes the diff will be updated. Maybe I just have to wait... Yes I just had to wait -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned but never read? Good question :) The easy answer is to just remove it. But I think it can actually be used to replace the myList.size() in the 2 for loops at lines 1289 and 1308. Even though new entries can be

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-12 Thread Federico Cavalieri
Federico Cavalieri has proposed merging lp:~fcavalieri/zorba/bugs into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 Fixed bug #872697 Updated Changelog for bugs #872697, #871623 and #871629

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-12 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/bugs into lp:zorba has been updated. Commit Message changed to: Fixed bug #872697 Updated Changelog for bugs #872697, #871623 and #871629 For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 --

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-12 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 Your team Zorba Coders is

[Zorba-coders] [Bug 871623] Re: Assertion failed with insert after in a collection

2011-10-12 Thread Federico Cavalieri
** Changed in: zorba Status: New = Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/871623 Title: Assertion failed with insert after in a collection Status in Zorba - The

[Zorba-coders] [Bug 869025] Re: Segmentation fault with getReference

2011-10-12 Thread Federico Cavalieri
** Changed in: zorba Status: New = Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/869025 Title: Segmentation fault with getReference Status in Zorba - The XQuery Processor:

[Zorba-coders] [Bug 869024] Re: Zorba crashes with getReference

2011-10-12 Thread Federico Cavalieri
** Changed in: zorba Status: New = Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/869024 Title: Zorba crashes with getReference Status in Zorba - The XQuery Processor:

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-12 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-12 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs2 into lp:zorba

2011-10-12 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~fcavalieri/zorba/bugs2/+merge/78401 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs2 into lp:zorba

2011-10-12 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/bugs2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs2/+merge/78401 -- https://code.launchpad.net/~fcavalieri/zorba/bugs2/+merge/78401 Your team Zorba Coders

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/setsatundo into lp:zorba

2011-10-12 Thread Federico Cavalieri
The proposal to merge lp:~fcavalieri/zorba/setsatundo into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/setsatundo/+merge/79093 -- https://code.launchpad.net/~fcavalieri/zorba/setsatundo/+merge/79093 Your

  1   2   >