Minimal comments: test/sun/security/smartcardio/TestAll.java ========================================== Looks like there is no actual update.
test/sun/security/smartcardio/* =============================== - 32 //This test requires special hardware. + 32 // This test requires special hardware. Looks nicer if there is leading space. test/sun/security/smartcardio/TestConnectAgain.java =================================================== - 29 * @run main/manual TestTransmit + 29 * @run main/manual TestConnectAgain Maybe a typo here. Would you please make the update? test/sun/security/ssl/X509TrustManagerImpl/ClientServer.java =================================================== - 35 * JSSE supports algorithm constraints with CR 6916074, - 36 * need to update this test case in JDK 7 soon + + 35 * JSSE supports algorithm constraints with CR 6916074, need to + 36 * update this test case in JDK 7 soon Would you mind add a blank line and join the two line accordingly? Otherwise, looks fine to me. Thanks, Xuelei On 3/15/2014 8:52 AM, Rajan Halade wrote: > Thanks Xuelei for your comment. I updated all tests as per your > suggestion - > > http://cr.openjdk.java.net/~wetmore/8033271/webrev.02/ > > Please review again. > > Thanks, > Rajan > On 3/14/2014 16:39, Xuelei Fan wrote: >> I like the changes. I'm afraid the lines following the @summary tag will >> be joined into one line during testing. We had such bad experiences in >> a lot JSSE tests. Would you like put the manual testing comment into a >> separated commend block? >> >> For example, change the update >> >> * @summary Ensure authentication via GSS-API/Kerberos v5 works. >> - * @ignore see runwjaas.csh for instructions for how to run this test >> - */ >> -/* >> - * Can set logging to FINEST to view exchange. >> + * Set logging to FINEST to view exchange. >> + * See runwjaas.csh for instructions for how to run this test >> + * >> + * @run main/manual AuthOnly >> >> To >> >> * @summary Ensure authentication via GSS-API/Kerberos v5 works. >> - * @ignore see runwjaas.csh for instructions for how to run this test >> + * @run main/manual AuthOnly >> */ >> >> /* >> - * Can set logging to FINEST to view exchange. >> + * Set logging to FINEST to view exchange. >> + * See runwjaas.csh for instructions for how to run this test >> */ >> >> Thanks, >> Xuelei >> >> On 3/15/2014 4:07 AM, Rajan Halade wrote: >>> Please review this fix: >>> >>> http://cr.openjdk.java.net/~wetmore/8033271/webrev.01/ >>> >>> I removed @ignore from all these tests and marked them with manual for >>> now. These tests will be considered for automation as a separate effort >>> and will be executed manually for now. >>> >>> Thanks, >>> Rajan >>> >
