Thanks again! Updated review with corrections - http://cr.openjdk.java.net/~wetmore/8033271/webrev.03/
- Rajan On 3/14/2014 18:36, Xuelei Fan wrote:
Minimal comments: test/sun/security/smartcardio/TestAll.java ========================================== Looks like there is no actual update. test/sun/security/smartcardio/* =============================== - 32 //This test requires special hardware. + 32 // This test requires special hardware. Looks nicer if there is leading space. test/sun/security/smartcardio/TestConnectAgain.java =================================================== - 29 * @run main/manual TestTransmit + 29 * @run main/manual TestConnectAgain Maybe a typo here. Would you please make the update? test/sun/security/ssl/X509TrustManagerImpl/ClientServer.java =================================================== - 35 * JSSE supports algorithm constraints with CR 6916074, - 36 * need to update this test case in JDK 7 soon + + 35 * JSSE supports algorithm constraints with CR 6916074, need to + 36 * update this test case in JDK 7 soon Would you mind add a blank line and join the two line accordingly? Otherwise, looks fine to me. Thanks, Xuelei
